From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1048AA0C4E; Thu, 22 Jul 2021 12:28:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 89F874014D; Thu, 22 Jul 2021 12:28:06 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 16B8640040 for ; Thu, 22 Jul 2021 12:28:04 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10052"; a="297181134" X-IronPort-AV: E=Sophos;i="5.84,260,1620716400"; d="scan'208";a="297181134" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2021 03:28:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,260,1620716400"; d="scan'208";a="495766623" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga004.fm.intel.com with ESMTP; 22 Jul 2021 03:28:00 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 22 Jul 2021 03:27:42 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Thu, 22 Jul 2021 03:27:42 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.108) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Thu, 22 Jul 2021 03:27:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BU88z6zHEBz9CZ8OwKyGxVtrmvj57dHIfdaTrDy1pbsu6qhzbWzK+sLQ57edV5Z3M2c3VwaU1/hfNyFEBO63nnQuZ90adbsliPoHs4CZARwlSEU7N5wdyGZbQa51HpM5A8hShfSYvL/CG4zgFoDoRO9ExR0ypZx5wEJo72huB3hiR9vlOm3KLCAXlMvrA8K5rn6pPVznprs87rgdvcFd6VZWtY/t5Xl9RWzV59pJH3hYnrWkOUJUAeXndhxuW1728Rb3UGSxjJgCcGna4aASKbpzDKOvxamFOoKPQmeZYdZ8qSxv7OEYAmav0ALQbLQGxrC2/Suy8bvlJKeiSC+Q8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N9DUcXeTvtjU5G1emIrbHjx6Sk81OCbHUPfUogcqE2k=; b=kNVFA0yPxZVforjUecmoF87C000SyplSoQ6FQEa5ZpSlkyTtsy9uAygnTImBHhpYNd4MQThRHdjmKjkQECZ9+G/sc5BbpuCIsRkJDVLAqwfNskSMOyKFtkF2El4/UJgjLZ/2Figjelxfg5HNGmLTz6yyV+E186agJc9xqLZ67aTgBDNZbwJzNqJ9a4u1pk1DlHBZw12aBxzs68ywo8Q2oad1hWgBFu+6+fa4vEGaYRcgdS8cvxh/UfDf0LdzegKMa/ir0FEsV//mY5zGYB/yrsQwyCWShtYS/11egSr1xPeORlO5G88xBN5UV1TPkjX3CnXF2Mr8rN6NtOcd2nSE0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N9DUcXeTvtjU5G1emIrbHjx6Sk81OCbHUPfUogcqE2k=; b=XKjfU52VurizcSPDsJBSku+iPRXP6KbwaQxzQNdPQ9YfZqyMabdPTf37AHJzaCPJJnifax0bhFuy3uTV7PnxZ1FM0VRgky06pm1QBriq0y/WmAmSx+BdzAt/rR6IqaWRpau/tVawed+GvG+KqX6tTM33APeGYPAw8H9IIQQLhmw= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4822.namprd11.prod.outlook.com (2603:10b6:510:39::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.24; Thu, 22 Jul 2021 10:27:39 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bde5:66de:e755:c5bb]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bde5:66de:e755:c5bb%5]) with mapi id 15.20.4352.026; Thu, 22 Jul 2021 10:27:39 +0000 To: Ajit Khaparde CC: Andrew Rybchenko , Jerin Jacob , Xiaoyun Li , Chas Williams , "Min Hu (Connor)" , Hemant Agrawal , Sachin Saxena , Qi Zhang , Xiao Wang , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Harman Kalra , Maciej Czekaj , Ray Kinsella , Neil Horman , Bernard Iremonger , Bruce Richardson , Konstantin Ananyev , John McNamara , "Igor Russkikh" , Pavel Belous , Steven Webster , Matt Peters , Somalapuram Amaranath , Rasesh Mody , Shahed Shaikh , Somnath Kotur , "Nithin Dabilpuram" , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Rahul Lakkireddy , Haiyue Wang , Marcin Wojtas , "Michal Krawczyk" , Guy Tzalik , "Evgeny Schemeilin" , Igor Chauskin , "Gagandeep Singh" , John Daley , Hyong Youb Kim , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , "Yisen Zhuang" , Lijun Ou , Beilei Xing , Jingjing Wu , Qiming Yang , Andrew Boyer , Rosen Xu , Shijith Thotton , Srisivasubramanian Srinivasan , Zyta Szpak , Liron Himi , Heinrich Kuhn , Devendra Singh Rawat , Keith Wiles , Jiawen Wu , Jian Wang , "Maxime Coquelin" , Chenbo Xia , Nicolas Chautru , David Hunt , Harry van Haaren , Cristian Dumitrescu , Radu Nicolau , Akhil Goyal , Tomasz Kantecki , Declan Doherty , "Pavan Nikhilesh" , Kirill Rybalchenko , Jasvinder Singh , Thomas Monjalon , dpdk-dev References: <20210709172923.3369846-1-ferruh.yigit@intel.com> <6655b8c1-82d8-27af-087c-c63153e79d3d@oktetlabs.ru> <61fbde10-1e3e-45a4-9877-f57f0aac2360@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <749d44ad-d7c5-307b-17a0-5b5dd9780674@intel.com> Date: Thu, 22 Jul 2021 11:27:19 +0100 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0004.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::23) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.0.206] (37.228.236.146) by FR3P281CA0004.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.7 via Frontend Transport; Thu, 22 Jul 2021 10:27:24 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 21630bb4-2b99-4b47-3d36-08d94cfb5423 X-MS-TrafficTypeDiagnostic: PH0PR11MB4822: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wZbk1p7PcWSDCXTfOCTtisEFmF76GPQKcuOwHV7l+vVshF+IUERrNrvog53X8MHWp2NwWEKqcON5JNWdyPFq7LH9jf0ARHs+gWiNCgJfoZDYCrklsAKTidq3e9KBzTgGjUJ0Ov5C4D+aV9wJ1TK0wJwhvFJw4erx0r8PwkSyh3fnJ78ryVR+ZVY7w9MdRINSi+1iukN25dAye3JU2pT/ITRKrF9l3fMO/VEafcJAUMdErrmrZbX8eNr46i00tZDAPrtE8oxuFWOjt7yWL+M4VmKH6umvOhJQOqJ35qjvrFXYquYNs5gOzXFeYwmEFR/Uv2ZrqG+IsFiwM39hjuye1vv03sqtxzOSbo8+G50+eUWlJiy1zhCbX5xHYy9AnRl5vngasCgpHr3ZiRJ7bt2W1Jjt19kYGrM5bUUsjhYexyLyNLRhi3lifUeRvtB/RBo4ioNbkFx0QTP6LtBxI1NQdXQhIZkGfN8nnP7/9AnYiI+AN8TolSciTp+8PZr8D0XWe/NDfE5yaDOYSJSPD62ll4HNDgSv+y9EHQT7GdGzy2CzEhMjvo+xDBdeHqbQgu5MI/eGsr27o38H9kgybEkZ1fbRkCYwcOEXrtLmFN0LOppDTJ+7OcA0NyzTlP2STy4jTl88DJXvwy8jcnlAf5r6srKdGaL2JVmcsbtWH+fPUqBd+AYFHt9NcCD9RWtZR9lAfbDjgSeIk3z5PLHkIjr8hQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(376002)(396003)(136003)(346002)(366004)(31686004)(5660300002)(8676002)(2906002)(478600001)(31696002)(4326008)(7406005)(7416002)(66946007)(66556008)(36756003)(66476007)(316002)(54906003)(16576012)(38100700002)(7366002)(8936002)(956004)(2616005)(6666004)(86362001)(44832011)(6916009)(6486002)(26005)(53546011)(186003)(83380400001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b1JXRVZab2Z4Ym5MWkxCcFMyZTVMNHZHbFZ4Mzgxajdvd1dBRXJXOFpNTkcv?= =?utf-8?B?ckhYWWh0QmhYdXpEV0ZocHVUdTVuNGFQS0lXM3dIeGxRd0k1R3dRd3EweEpV?= =?utf-8?B?VWMwMks0TWtPMlQvM1hWdVpKTi94QU9jYUpnNXA5ekNZSFBrbmVPM3lHVjB5?= =?utf-8?B?bUFnN2hGQnJFVm1sRHhRTC9JTUdnSzQzRWRISk1KTjFFSGxSQm91N0N4RmRW?= =?utf-8?B?MDlVV280S204Qy9tc1lOcWRVZUdvd1ByQTB5aDJSWGMxZ1FZM3QzeU1ycGl1?= =?utf-8?B?SjNTL3FqLzk2MEFQemxJUzVyd0NvRS9CYXVIcVdWT3pzRWVFMjRJS0ZiblY4?= =?utf-8?B?eUdvSzQxTWV6OGswRGlDa0VuaG9qLzNTRXE3cWtzbmFKSDVrL1ZQWk5OWXc3?= =?utf-8?B?ZTR0UklpUHgvekdoSU5CN2xPRFpWRVUreXM2RGVDWlBZdTJIa1RtSDZXWnhk?= =?utf-8?B?SmU4blFMZEdKV0g5VDFOZ1dKTUlBUUJTQU1lQWpkSXVsYmNPNUNPMG0xd3h0?= =?utf-8?B?eDdOWnZPZUFNRG5acURQMmV2Z1kxWUZVdU4ra0d6SHhOQXpkOUFERXVVbU5k?= =?utf-8?B?czFIS1p1Nm5uWm9iOERnTmcxeEhONFcrY1RqaXpkeldmZWYwMGNYZVIxMG5T?= =?utf-8?B?eXJlSFVQeE1WZXc2MEpUSlhyaFVGYldOSklxWmtvQjBPZXdxTkhRMmxURGxh?= =?utf-8?B?SDFqaU9Gc2R6cDZ4eEJYOCtnM1Jpc2xJaWtzUzZndDJFRGJTWkJqVmNkSkk5?= =?utf-8?B?TDlWWEpaeUxWRk1abmNVTEN6UTdVa01kcU5lYTB5dEpzbFVMaWZnWmR2RFJZ?= =?utf-8?B?NHVpb1dqTS81Tm9GMEtmZmtGVTEyQlRRZk0xczdMUlFsaXBRM0tEMHZ1aFJP?= =?utf-8?B?N2ZUclM4WWZ6YWgvZFdoK0pjSnYvdWp2cHoxb0lNbFpyZ0lONG51Z0FCS0px?= =?utf-8?B?eFJ2UVNDVjFTRDVpRENBVFdDN0hxM282ek5Eb0dTeTA1cFJuY3lzRVIwQ3hr?= =?utf-8?B?Z0lZLzI5UTJHcWZZN0hCM0xYZjErcitjWUlHYnY4Sks3QVlsNXVrb201Qmhr?= =?utf-8?B?WGROTmR6UmdrVTdyVTI5UjdZdG9zWm04TEdaWFdreEtyS2d1WDlqTER3eExM?= =?utf-8?B?QjNQL1Q0MGFFem5rdTJVaE4yUVNUZlB6NXVKMzlBdmZkZlBOdzhmZTF0VG03?= =?utf-8?B?d3EwSks5V3hzcHFpOHdseExQQ01IcGVRdGNkdmxHZi9OS1FYUlpGZDAxSlZI?= =?utf-8?B?aVY1emI4dkRXdzVsZ1hsWFlvUUtYV1ZhK0ExZitld1F2Z0pUaURMbFBmV3NW?= =?utf-8?B?TXMyVnEwaU8yWTZhZFgwWHJoSi9xOUNlaTgwTzBiNzNwcXBTMEQ2MTRaVVFZ?= =?utf-8?B?WWlvUGZNb01pVVhrbWdoNk4rWW40a3IrYXI1ZEF1Sy9XOXJpY3hjeithNStJ?= =?utf-8?B?WldVMlNocHdCanhUaG9UTCtEeU1wUmkvN1lNSmRJZ3ZKS0F4L2lnU0szL3kr?= =?utf-8?B?dGIxWXpmUFQ3YWVVYlJFNldsalUyak0rclBFZWorZTdFWlBnWjI5dTd0MnZL?= =?utf-8?B?eDJYRmcxL216OTZNVjJUMCtYa0UvTVRzejRrOFhab0R5V0hKWm1TV0ZQeFB5?= =?utf-8?B?NThLRDJqa0JEdTk4Wm9xYTcxNUhQcjJUL0l1blA4OU9tdU1SZXVETFZTZW1v?= =?utf-8?B?SnQ2elkvbjlVbHR1c1FkdXVwV1RZUnR4YW8vK3QvYVQ3MjdraEM3LzkrZm5p?= =?utf-8?Q?gSXqZKFZJYjbY0B+tGg9mg2HgdG1jpvg8EibBw7?= X-MS-Exchange-CrossTenant-Network-Message-Id: 21630bb4-2b99-4b47-3d36-08d94cfb5423 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2021 10:27:38.4989 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Es+GDtqC+lHHKountyhFuWlEVPjVCerxPH46AtqEeTXhfyEN9sspKBHwthIRNA5nvESq8kCCp407M6PD8SJh+Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4822 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 1/4] ethdev: fix max Rx packet length X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/22/2021 2:31 AM, Ajit Khaparde wrote: > > > > > [snip] > > > >> diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h > >> index faf3bd901d75..9f288f98329c 100644 > >> --- a/lib/ethdev/rte_ethdev.h > >> +++ b/lib/ethdev/rte_ethdev.h > >> @@ -410,7 +410,7 @@ enum rte_eth_tx_mq_mode { > >>  struct rte_eth_rxmode { > >>      /** The multi-queue packet distribution mode to be used, e.g. RSS. */ > >>      enum rte_eth_rx_mq_mode mq_mode; > >> -    uint32_t max_rx_pkt_len;  /**< Only used if JUMBO_FRAME enabled. */ > >> +    uint32_t mtu;  /**< Requested MTU. */ > > > > Maximum Transmit Unit looks a bit confusing in Rx mode > > structure. > > > > True, but I think it is already used for Rx already as concept, I believe the > intention will be clear enough. Do you think will be more clear if we pick a > DPDK specific variable name? > > Maybe use MRU - Max Receive Unit. >   It can be an option, but this patch unifies 'max_rx_pkt_len' & 'mtu' => mtu, if we switch to 'mru', we should switch all usage to 'mru', including 'rte_eth_dev_set_mtu()' API name change, to not cause a new confusion between 'mru' & 'mtu' difference. Does 'mtu' really cause this much confusion to do all this change? > > >>      /** Maximum allowed size of LRO aggregated packet. */ > >>      uint32_t max_lro_pkt_size; > >>      uint16_t split_hdr_size;  /**< hdr buf size (header_split enabled).*/ > > > > [snip] > > >