From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ciara.loftus@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
by dpdk.org (Postfix) with ESMTP id B74257F48
for <dev@dpdk.org>; Thu, 18 Dec 2014 18:01:44 +0100 (CET)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
by orsmga103.jf.intel.com with ESMTP; 18 Dec 2014 08:59:19 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.07,601,1413270000"; d="scan'208";a="626084525"
Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96])
by orsmga001.jf.intel.com with ESMTP; 18 Dec 2014 09:01:40 -0800
Received: from irsmsx106.ger.corp.intel.com ([169.254.8.18]) by
IRSMSX154.ger.corp.intel.com ([169.254.12.15]) with mapi id 14.03.0195.001;
Thu, 18 Dec 2014 17:01:39 +0000
From: "Loftus, Ciara" <ciara.loftus@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH] vhost: add interface name to virtio-net struct
Thread-Index: AQHQGtLEcjdlFXE5jESNg2FD7ncNQpyVejoAgAAYGeA=
Date: Thu, 18 Dec 2014 17:01:30 +0000
Message-ID: <74F120C019F4A64C9B78E802F6AD4CC212578FCB@IRSMSX106.ger.corp.intel.com>
References: <1418914523-24530-1-git-send-email-ciara.loftus@intel.com>
<2861628.6qtiPmT13X@xps13>
In-Reply-To: <2861628.6qtiPmT13X@xps13>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, Anthony Fee <anthonyx.fee@intel.com>
Subject: Re: [dpdk-dev] [PATCH] vhost: add interface name to virtio-net
struct
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Dec 2014 17:01:45 -0000
Hi Thomas,
A basic vHost use case will work, for example a single Virtual Machine with=
a vHost port. However normal vSwitching use cases will require the use of =
multiple vHost ports and multiple VMs. With that in mind, it is essential t=
hat the vSwitch has some way of knowing which vHost port it is sending to a=
nd receiving packets from. This patch resolves this issue by exposing the t=
ap device name of the vHost device. Without that information we cannot dete=
rmine the particular vHost port to send/receive from, which in the context =
of switching, is a critical problem.
Thanks,
Ciara
-----Original Message-----
From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] =
Sent: Thursday, December 18, 2014 3:33 PM
To: Loftus, Ciara
Cc: dev@dpdk.org; Anthony Fee
Subject: Re: [dpdk-dev] [PATCH] vhost: add interface name to virtio-net str=
uct
2014-12-18 14:55, ciara.loftus@intel.com:
> This patch fixes the issue whereby when using userspace vhost ports in =
> the context of vSwitching, the name provided to the hypervisor/QEMU of =
> the vhost tap device needs to be exposed in the library, in order for =
> the vSwitch to be able to direct packets to the correct device.
Do you mean that vhost was not working at all?
Please precise the context and how it is critical.
More informations are needed to understand wether it should be merged in re=
lease 1.8.0 or not.
> --- a/lib/librte_vhost/rte_virtio_net.h
> +++ b/lib/librte_vhost/rte_virtio_net.h
> @@ -96,6 +96,7 @@ struct virtio_net {
> uint64_t features; /**< Negotiated feature set. */
> uint64_t device_fh; /**< device identifier. */
> uint32_t flags; /**< Device flags. Only used to check if device is ru=
nning on data core. */
> + char ifname[32]; /** Name of the tap device **/
Wrong comment style.
--
Thomas
--------------------------------------------------------------
Intel Shannon Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263
Business address: Dromore House, East Park, Shannon, Co. Clare
This e-mail and any attachments may contain confidential material for the s=
ole use of the intended recipient(s). Any review or distribution by others =
is strictly prohibited. If you are not the intended recipient, please conta=
ct the sender and delete all copies.