From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id DC87A7EE4 for ; Thu, 27 Apr 2017 09:41:04 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Apr 2017 00:41:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,257,1488873600"; d="scan'208";a="254062069" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by fmsmga004.fm.intel.com with ESMTP; 27 Apr 2017 00:41:02 -0700 Received: from irsmsx106.ger.corp.intel.com ([169.254.8.202]) by IRSMSX152.ger.corp.intel.com ([169.254.6.231]) with mapi id 14.03.0319.002; Thu, 27 Apr 2017 08:41:02 +0100 From: "Loftus, Ciara" To: "Yang, Zhiyong" , "dev@dpdk.org" CC: "yuanhan.liu@linux.intel.com" , "maxime.coquelin@redhat.com" Thread-Topic: [PATCH] vhost: fix MQ fails to startup Thread-Index: AQHSvyEO6koMUHi5iU2/oZ2uYd2ccqHY1LUg Date: Thu, 27 Apr 2017 07:41:01 +0000 Message-ID: <74F120C019F4A64C9B78E802F6AD4CC24FA3D848@IRSMSX106.ger.corp.intel.com> References: <1493274893-40764-1-git-send-email-zhiyong.yang@intel.com> In-Reply-To: <1493274893-40764-1-git-send-email-zhiyong.yang@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTQzMDZlYzEtZDZhMC00NjlhLWE4ODAtMDlhZGIxMTVjYjg0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Im1lQ2xvTXA5VWVsS0N5UWNWZVwvQkdLa1wvUU9lZGVLUlNYN0M1TXNWUGNGbz0ifQ== x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] vhost: fix MQ fails to startup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Apr 2017 07:41:05 -0000 >=20 > vhost since dpdk17.02 + qemu2.7 and above will cause failures of > new connection when negotiating to set MQ. (one queue pair works > well).Because there exist some bugs in qemu code when introducing > VHOST_USER_PROTOCOL_F_REPLY_ACK to qemu. when dealing with the > vhost > message VHOST_USER_SET_MEM_TABLE for the second time, qemu indeed > doesn't send the messge (The message needs to be sent only once)but > still will be waiting for dpdk's reply ack, then, qemu is always > freezing. DPDK code works in the right way. But the feature > VHOST_USER_PROTOCOL_F_REPLY_ACK has to be disabled by default at the > dpdk side in order to avoid the feature support of DPDK + qemu at > the same time. if doing like that, MQ can works well. Once Qemu bugs > have been fixed and upstreamed, we can enable it. >=20 > Fixes: 73c8f9f69c6c("vhost: introduce reply ack feature") >=20 > Reported-by: Loftus, Ciara > Signed-off-by: Zhiyong Yang Thanks for the fix Zhiyong. I tested the patch in my environment and it res= olves the issue I was seeing. Tested-by: Ciara Loftus Thanks, Ciara > --- > lib/librte_vhost/vhost_user.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/lib/librte_vhost/vhost_user.h b/lib/librte_vhost/vhost_user.= h > index 2ba22db..a3d2900 100644 > --- a/lib/librte_vhost/vhost_user.h > +++ b/lib/librte_vhost/vhost_user.h > @@ -52,7 +52,7 @@ > #define VHOST_USER_PROTOCOL_FEATURES ((1ULL << > VHOST_USER_PROTOCOL_F_MQ) | \ > (1ULL << > VHOST_USER_PROTOCOL_F_LOG_SHMFD) |\ > (1ULL << > VHOST_USER_PROTOCOL_F_RARP) | \ > - (1ULL << > VHOST_USER_PROTOCOL_F_REPLY_ACK) | \ > + (0ULL << > VHOST_USER_PROTOCOL_F_REPLY_ACK) | \ > (1ULL << > VHOST_USER_PROTOCOL_F_NET_MTU)) >=20 > typedef enum VhostUserRequest { > -- > 2.7.4