From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 18906A2F18 for ; Thu, 3 Oct 2019 15:23:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E02451C0CD; Thu, 3 Oct 2019 15:23:23 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id A172C1C0CC for ; Thu, 3 Oct 2019 15:23:22 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Oct 2019 06:23:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,252,1566889200"; d="scan'208";a="203955097" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by orsmga002.jf.intel.com with ESMTP; 03 Oct 2019 06:23:20 -0700 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX106.ger.corp.intel.com (163.33.3.31) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 3 Oct 2019 14:23:08 +0100 Received: from irsmsx106.ger.corp.intel.com ([169.254.8.184]) by irsmsx111.ger.corp.intel.com ([169.254.2.112]) with mapi id 14.03.0439.000; Thu, 3 Oct 2019 14:23:08 +0100 From: "Loftus, Ciara" To: Stephen Hemminger CC: "dev@dpdk.org" , "Ye, Xiaolong" , "Laatz, Kevin" , "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH v2 2/3] net/af_xdp: support pinning of IRQs Thread-Index: AQHVd65WqjjxpWtTx0OIQh/+EUtsHadEZBuAgASHj+A= Date: Thu, 3 Oct 2019 13:23:07 +0000 Message-ID: <74F120C019F4A64C9B78E802F6AD4CC279226C6C@IRSMSX106.ger.corp.intel.com> References: <20190930164205.19419-1-ciara.loftus@intel.com> <20190930164205.19419-3-ciara.loftus@intel.com> <20190930101137.4919f93e@hermes.lan> In-Reply-To: <20190930101137.4919f93e@hermes.lan> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2Y4N2ExY2YtNjgwZC00ZGVlLTk3MTAtZjY1ZTEyN2E1ZWZkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidWhtYWhBQklXaTBUdDdyTmRRSXh0dnVVZG5SeTZpNGVoYUg0cWdpTEcwc2g4QWpyZllsa3FQekh0XC9WTzNzN1AifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 2/3] net/af_xdp: support pinning of IRQs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Stephen Hemminger > Sent: Monday 30 September 2019 18:12 > To: Loftus, Ciara > Cc: dev@dpdk.org; Ye, Xiaolong ; Laatz, Kevin > ; Richardson, Bruce > Subject: Re: [dpdk-dev] [PATCH v2 2/3] net/af_xdp: support pinning of IRQ= s >=20 > On Mon, 30 Sep 2019 16:42:04 +0000 > Ciara Loftus wrote: >=20 > > +/* drivers supported for the queue_irq option */ > > +enum supported_drivers { > > + I40E_DRIVER, > > + IXGBE_DRIVER, > > + MLX5_DRIVER, > > + NUM_DRIVERS > > +}; >=20 > Anything device specific like this raises a red flag to me. >=20 > This regex etc, seems like a huge hack. Is there a better way using > irqbalance and smp_affinity in kernel drivers? >=20 > NACK Hi Stephen, =20 Thanks for looking at the patch. I understand your concern however unfortun= ately I haven't been able to identify a way to achieve the desired outcome = by using your suggestions of irqbalance and smp_affinity. Did you have some= thing specific in mind or are aware of any generic way of retrieving interr= upt numbers for NICs regardless of vendor or range? =20 I think this feature is really important for the usability of this PMD. Wit= hout it, to configure the IRQs the user has to open up /proc/interrupts, tr= awl through it and identify the correct IRQ number for their given NIC and = qid (the format for which is unlikely to be known off-hand), and manually p= in them by writing the appropriate values in the appropriate format to the = appropriate file - prone to error if not automated IMO. If the user fails to set the affinity it's probably fine for a single pmd, = however with multiple pmds all irqs will by default land on core 0 and lead= to terrible performance. It should be possible to rework the code to remove the regexes and use a di= rect string compare. Would that make the solution more palatable? =20 Let me know what you think. =20 Thanks, Ciara