From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id CA1F62BAA for ; Fri, 24 Feb 2017 12:23:00 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Feb 2017 03:22:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,200,1484035200"; d="scan'208";a="229241696" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.4.61]) ([10.252.4.61]) by fmsmga004.fm.intel.com with ESMTP; 24 Feb 2017 03:22:58 -0800 To: Yong Wang , wenzhuo.lu@intel.com References: <1487669603-13741-1-git-send-email-wang.yong19@zte.com.cn> Cc: dev@dpdk.org From: Ferruh Yigit Message-ID: <74bacad4-63db-8836-25cd-ce9495cc5632@intel.com> Date: Fri, 24 Feb 2017 11:22:57 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <1487669603-13741-1-git-send-email-wang.yong19@zte.com.cn> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2] e1000/base: fix multicast setting in VF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Feb 2017 11:23:01 -0000 On 2/21/2017 9:33 AM, Yong Wang wrote: > In function e1000_update_mc_addr_list_vf(), "msgbuf[0]" is used prior > to initialization at "msgbuf[0] |= E1000_VF_SET_MULTICAST_OVERFLOW". > And "msgbuf[0]" is overwritten at "msgbuf[0] = E1000_VF_SET_MULTICAST". > Fix it by moving the second line prior to the first one that mentioned > above. > > --- > v2: > * According to Thomas's suggestion, modify the title. > > Signed-off-by: Yong Wang It looks like this fix has a history: - Defect introduces with initial version - Fixed with: [1] 06cf9be95ce1 ("lib: fix uninitialized value") - Fix reverted with: [2] dffbaf7880a8 ("e1000: revert fix for multicast in VF") - This patch applies same fix again. Revert does not mention why it has been reverted, this is one of the samples why commit log matters. Since code is clearly wrong, I am for getting the fix, but it would be nice to know why it has been reverted previously. [1] commit 06cf9be95ce16b363c4267d2d17e27c2706629ae Author: Zijie Pan Date: Thu Dec 6 15:36:51 2012 +0800 lib: fix uninitialized value Fix warning "The left expression of the compound assignment is an uninitialized value". Signed-off-by: Zijie Pan Acked-by: Ivan Boule Acked-by: Adrien Mazarguil [2] commit dffbaf7880a8d753a4971971256d6c8b90e7ece1 Author: Intel Date: Fri Nov 8 03:00:00 2013 +0100 e1000: revert fix for multicast in VF Revert fix from commit 06cf9be95ce16b363c4267d2d17e27c2706629ae. Signed-off-by: Intel