From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A4D19A0093; Thu, 23 Jun 2022 14:36:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 902FD4069D; Thu, 23 Jun 2022 14:36:31 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 288404003F for ; Thu, 23 Jun 2022 14:36:30 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id B9188AC; Thu, 23 Jun 2022 15:36:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru B9188AC DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1655987789; bh=/5MSXJ9MXcGz7M0giIDFfycSU56eMQuEqmvpa0d6CNg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=TISP6rFlGZPFxbCtaLm/ZXtIAYyj8VvAjykfMwX0ZB8Echb6UsNBr93CYhXgb9GF3 SE21OQoA9n1lZb/+UdgN3kOKlLaJuDDOScFCly8J/EtsrqMQwcweSYiqExyVmmNd1k 0tsc3utJ8+7Yy1eKFVLFzjZi0hVTO8YGn91KCt1Q= Message-ID: <74bd95f5-8011-079f-eda1-a5db5fcfb09b@oktetlabs.ru> Date: Thu, 23 Jun 2022 15:36:29 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2 09/12] net/nfp: add flower ctrl VNIC rxtx logic Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: niklas.soderlund@corigine.com, Heinrich Kuhn , Thomas Monjalon , Ferruh Yigit References: <1655807588-7320-1-git-send-email-chaoyong.he@corigine.com> <1655807588-7320-10-git-send-email-chaoyong.he@corigine.com> From: Andrew Rybchenko Organization: OKTET Labs In-Reply-To: <1655807588-7320-10-git-send-email-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/21/22 13:33, Chaoyong He wrote: > Add a Rx and Tx function for the control vNIC. The logic is mostly > identical to the normal Rx and Tx functionality of the NFP PMD. > > This commit also makes use of the ctrl vNIC service logic to > service the ctrl vNIC Rx path. > > Signed-off-by: Chaoyong He > Signed-off-by: Heinrich Kuhn > Reviewed-by: Niklas Söderlund [snip] > + /* Flower ctrl vNIC only has a single tx queue */ > + txq = ctrl_dev->data->tx_queues[0]; > + if (unlikely(txq == NULL)) { > + /* > + * DPDK just checks the queue is lower than max queues > + * enabled. But the queue needs to be configured > + */ > + rte_panic("ctrl dev TX Bad queue"); checkpatches.sh warnings about it [1]. Please, rework code to avoid usage of rte_panic(). > + } > + > + txds = &txq->txds[txq->wr_p]; > + txds->vals[0] = 0; > + txds->vals[1] = 0; > + txds->vals[2] = 0; > + txds->vals[3] = 0; > + > + if (nfp_net_nfd3_txq_full(txq)) > + nfp_net_tx_free_bufs(txq); > + > + free_descs = nfp_net_nfd3_free_tx_desc(txq); > + if (unlikely(free_descs == 0)) > + rte_panic("ctrl dev no free descs"); same here [snip] [1] http://mails.dpdk.org/archives/test-report/2022-June/290999.html