From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0060.outbound.protection.outlook.com [104.47.37.60]) by dpdk.org (Postfix) with ESMTP id D6F3E5599 for ; Tue, 26 Sep 2017 10:42:18 +0200 (CEST) Received: from DM5PR03CA0048.namprd03.prod.outlook.com (10.174.189.165) by CO2PR03MB2358.namprd03.prod.outlook.com (10.166.93.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Tue, 26 Sep 2017 08:42:16 +0000 Received: from BY2FFO11FD001.protection.gbl (2a01:111:f400:7c0c::105) by DM5PR03CA0048.outlook.office365.com (2603:10b6:4:3b::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.11 via Frontend Transport; Tue, 26 Sep 2017 08:42:16 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BY2FFO11FD001.mail.protection.outlook.com (10.1.14.123) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.56.11 via Frontend Transport; Tue, 26 Sep 2017 08:42:16 +0000 Received: from [10.232.134.49] ([10.232.134.49]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v8Q8gDsx020306; Tue, 26 Sep 2017 01:42:14 -0700 To: Pablo de Lara , CC: References: <20170913072026.29734-1-pablo.de.lara.guarch@intel.com> <20170922075519.28342-1-pablo.de.lara.guarch@intel.com> <20170922075519.28342-7-pablo.de.lara.guarch@intel.com> From: Akhil Goyal Message-ID: <74d585cc-1dca-a684-c1db-7fe5c73179c9@nxp.com> Date: Tue, 26 Sep 2017 14:12:12 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170922075519.28342-7-pablo.de.lara.guarch@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131508889364067513; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(346002)(39380400002)(376002)(39860400002)(2980300002)(1110001)(1109001)(3190300001)(339900001)(189002)(24454002)(377454003)(199003)(57704003)(5660300001)(83506001)(498600001)(33646002)(58126008)(53546010)(64126003)(86362001)(8936002)(47776003)(50466002)(65806001)(2906002)(189998001)(65956001)(81156014)(76176999)(81166006)(106466001)(77096006)(356003)(8676002)(68736007)(31686004)(104016004)(50986999)(305945005)(97736004)(105606002)(110136005)(230700001)(31696002)(85426001)(54356999)(2950100002)(36756003)(23676002)(65826007)(53936002)(6246003)(4326008)(316002)(229853002); DIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR03MB2358; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD001; 1:qI9qQRoLTm4xYPQML5K+d6LzWm+WS2HilEpiWDj3tPRvNpTVpfuBvCq62RO/+00xWexm++8JXdpycGgsp48OAk881zlv7rnofkF0CGo7oAAI5NY8r+7gj3+h7VTQBOuS X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: df6b7dec-fe69-4f4d-f4b9-08d504ba7dd0 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017052603199)(201703131430075)(201703131517081); SRVR:CO2PR03MB2358; X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2358; 3:1tymIHWnGQSOFL9L9UmeiwBzUCieYS88F4hlMXH2b7d3fcdk0E0SY1UMQAy0K3FNypTivtw4tfovNljkmYWL/lIR/LedDIMcQoPax8EDtlikTiaJWj2fnOb3tXVQsdKTKdEtd4h9/rvZ/E9IrP6lbJADzJFMeE2bRSZgNYIbaG4AjkYSUvCd6IVV19cqU8oz5zDoxmpGq6YnmcnqW/mI5u246NFq9uGfqsAVPJvHAvAc8XbIMDoe+ePUdjKK9/OV0hSnbemJxEK2lKTL+DtciR6svuSWhetx4sImDTHIYQbaO1aYwPqGqd1ZbzOFyxn1oRnQPTJtHm0ENgwabCb7jUrvJKpS9CT9AEAVs/7+/1k=; 25:JQXYGtAeo/Bz3d40d52eSknw1EORkm30RTTwb5UG1eK+robPRG4SdkntxPH+PUq66nVNE/uZ83HP9zamz29DaH+CmYBY/88FWMDeBJ3VouGCaCNgtI1yu5svimvdRw13/ln8+LkYPIOvrWrsEy8s3+RHZXfGCqEnqjQLwwXSeaG9NsCgOFWVlJdVI1n65DNDJkqk1HZmyJKVN57+vGHOUpKPYUGaDe1zIZLOzNyPk3TzQLQN8A5R7I+habGMrYO/s1voCMCBdzMPAAZTpaYxDruki4pjd+sNwnTK4Sam4YvRxjjPn4VB6smii8RBM1GaJytreEx3tNzDuze1slA9Aw== X-MS-TrafficTypeDiagnostic: CO2PR03MB2358: X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2358; 31:WhOiKsM99gIj/7WJl59LV20oHKiuC2bbCw5tmYmIfNnLwzQBmpcKZhKSLa84FkjwKBH5MCgLeTeYY9n+jTJY79i54qOMuxj9cCIOEMz8QKK3Up1375ly99dtNiHTL+NN3B5SPVr2LPX9hWsArZ53a4t75a9NASteWleNl9W2zso7CoppvVeshPRd6K91Zj92uJDO/vRLyX423eo0+Vz20kE39W7aMtLPQv+LFZB2Ntk=; 4:PZqm2ndVQg8GphunXT1adwe3+wIR4SIEH6FbJqEj/5OSJ3FDC2HHRq57JWD9f3Y/Pp4aGnQPcQeOO12PfLvHAA6c/4o51kHO/XdxH3LYjqkEPqwkam72GsiMFeRt15BuuB2+TOFAZMSAztcP+GDI4xNc6Do+hK2wgJMvuv0KLFD81TVL0qNbPNRUj0SoqpmTGubj1Hns+sUUgSOOiYkI8pjioH4Bd/0opAhkF+nPWcveSg5bAvsiT17ZCiaoBp1Xdk0P+5U+xV7gj32VZ+12e9RzrBsrbU0mZ+KJW661SEM= X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(3002001)(10201501046)(6055026)(6096035)(20161123561025)(20161123565025)(201703131430075)(201703131448075)(201703131433075)(201703161259150)(201703151042153)(20161123559100)(20161123563025)(20161123556025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CO2PR03MB2358; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CO2PR03MB2358; X-Forefront-PRVS: 0442E569BC X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDTzJQUjAzTUIyMzU4OzIzOk5MV05PRU1GbWU1RWVEdUdSdDRReFFKMm5F?= =?utf-8?B?cHNMdGk1czNvcVIzNWs3YmtieWwyWlM5ZUhnQzdUOGJMeGFzNlBJOHRaTTE1?= =?utf-8?B?dlVwZk5OYjUwK1QwczBLNUJ0eFFGQzFKOHNlRDJ2MkFEc0RFWG1WVHBUcGhD?= =?utf-8?B?L3VPZDByaGpyQTU2R3FNR1UyVERPblFPZmJzd3MzZXBYdmp6eDFSWWN6ck92?= =?utf-8?B?c0MyTXB5NkxTZlhJdk5vZlhpUXhueHJIZmtOWENYalo5TEpqRlVnOXN1clVi?= =?utf-8?B?Y1FEVlgxQXdLVTAyS0NQUE1RL3ViNnFoT0tocmQyMm9rdXJpU1hXYTh4NFJW?= =?utf-8?B?S2Jnc0srVi9FN0oxMSsxeUJlU3RUd3E2UW9lS3ptODFtZ0gxWTNKNHNRWUZn?= =?utf-8?B?c3gwcFZTSkoycnhORElMczRsalRoNGYvc3Mwc3BnZHI4RmloanQ3dFBZVUg4?= =?utf-8?B?elJnaFFySkJ2L0hFNnZYYlBHYzY0YzU2QXI5THBOTHVNVlBIR2NwdFBUNDZX?= =?utf-8?B?Ky9Gc0Vra2UwRXQ4QmhYd0NONlJubU1NRWx6MTdXWERaZEViUloxb1Y0OGVy?= =?utf-8?B?U3JqRXcvNUpnckhmK2tyTVJBcS9pa0pxbVV1bEoyakZnN1FIVzJkYTk2Vk5J?= =?utf-8?B?S3U0S0RKYW9EeU53RERKV1o1SnhXT21oRVJSc3N0Ry94NGE0S0tCbmtvejdL?= =?utf-8?B?WHZHeGdneGJRaEowcmhZaHM2ZHdNVG5hRVR2c3EzNzVhSGpaRTJaOXdIbGIw?= =?utf-8?B?S2JmUDBJcTk0OUp0bnAwMFpMN2d3ZXpWL2RydDRxR01SVVlXOFk1eE94bjI4?= =?utf-8?B?QS95S3NVSFR4bkRWcGdVNmdOWDhRMU9scFIrMy95UExnOS96cytLSHlCZnhZ?= =?utf-8?B?b2J0NHZCRmcvckE3eDVtNGJFcmlYWWJjWDBUZnNaKzNIdjNxUStwWGpSK0tK?= =?utf-8?B?MGpMRWlQeWtuK3htYXpzMi91NEsyWW5YWEtLREtYWHZmNzRiVzIrR1cyNW5h?= =?utf-8?B?dUFZY1lKdEFhV1FnUlFBS01mbDhjQ0hkak54anV1THoySmd6WWJpamlnR1ZY?= =?utf-8?B?MUVJVE5QV1BNMFdJbzJ6d3BXUUtuVnhPZFhxN3NyREhhUjdaek9LOFhqZ1pN?= =?utf-8?B?aW1jVnZkd2VTNlo1WkdkbzluRU9vNmM2clNaRzJRVlNxVUZaSTVWZk13YWtW?= =?utf-8?B?M1lXTGFFSzlVcmExd0NyT0cxM1NOQWpxMlFZeFQ4TkZLMnRCMEVyS1dTVWti?= =?utf-8?B?S2Y5TDdTSnhhTzQyVVBhWDRsYmVwWUNzM0JmcUlhWld4YU5BbnFoODNSeW9T?= =?utf-8?B?Rmd1WjJWVWpMYmV6ZU5TSERqZkRtUjhMUm1nTCs2NnNMR2gyeXhlNTRDdGdv?= =?utf-8?B?dEFrMGcwdENMbkZzdGJEQ2VBREV0N2JWb1NGeEVkUGhkanp2NzRYa2c2RWF3?= =?utf-8?B?TDdweTJ5YkJ4Vi8zajhPYWdwamk5VC8rdTFzZWJsVzVCdlgzWEhNOGd2TjVD?= =?utf-8?B?TTJ1VWVYZkthWEdSM2lZWEdBMUtPNTJWNXdBUWhjU3NNNWIzNU1TZG5IZXAz?= =?utf-8?B?QThpYmgrQ0xUUFF3SHJyV3paVHRKMGhSV1ZxWG1rNTI0RnZyaVBDQ2tYbTdJ?= =?utf-8?B?c2NJaWVHenAxelBMS2s3NHhkMTg3djZ2RlBySXhqZzg5N1FRelY4V2JTbW1l?= =?utf-8?B?TEkvTGdQMGVYWktIT1FuWFpBUDJabzgyUWZaMFEyWXpmUWJONXpBdVdaU2U5?= =?utf-8?B?RGx5ZC80TTZuL0FyNXdEVURITDV4Q0VybFYvN1BMbFFmb1RLOTA1bkU1STc0?= =?utf-8?B?dmFmTndKa2xLUzJWOHdsam5yY3dLYkdzZnJKWVN6a1JnendNSGlmRUdseFZE?= =?utf-8?Q?8ngOZEGUIe8=3D?= X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2358; 6:jIbZjlCinkvuqqHlL1Q0TzhX937GUuF8qV211L4d89pr/lqeMkVBsn96ftbETMXu39JaE0fO0NS5F08I7U809RemSyMvQSw5gl0HYpAGGCR1KfqJrlKYauCpVzIzsZmXGH95zaFu6sc63MBgN1pcGGAUs7gEYpgDn68oyEG/IhuBpD6kvc/rEKEJ9jRyh8zfjAVCZSwGiA1Wo1BGYeTDFOP/J5flo4ypFiYQaoZc4GRSY9Ng9WccssoazWpWKchjFF6zmbuSezAExSufSjn+JuASfoFJ1CVknmU9jTFuu7UoWd22f3HQWYbWXkJTmUfmsw1TEAP1QkTrE4VFGb1nGw==; 5:wEfKQRcleOAj6UoTwaB1rC2hFuNbpjprW9Ii75LwwdToXJQ+OdsntBKvbj+lAAd+gTHk45eeSanXqZ+azjjqeDGzGs/vGcJg7/tLRmW5qqonFtyWZEJzQwczt0do3cVIw8nck9dHNf5bE4tI+REGJA==; 24:LqVaHR9Y9HeXDW5O6A8shmx/1XzUk0Mj5LtUm+APldimzIpxFhT6p1EZp0If0mvLBwnyFic4veSinA6sLlK2Px8wZyOejGgpfMJgKHv1HMU=; 7:u4nMp+5/W+dwSBgdhRIceK8UngtmodI0XgS0kJesLEtcB87/x9k3hE45eJrHPuvz2pOczJZ9tbAnxHV8Ea5KCHZrmOa2163RSk9xpFTZteAmYAMa8VeG3VQtrKukLZr/FniZPl4Wn8n2NnJf6HOX0gcSqtBx/C51yjEM3YTwDwXGuRcxH4TcICzs9JlJRJkxsIaGYQ1+r+rFslqfzcrksoZty4zcyMR2ts8yggApft4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2017 08:42:16.2195 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR03MB2358 Subject: Re: [dpdk-dev] [PATCH v3 6/7] app/crypto-perf: support multiple queue pairs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Sep 2017 08:42:19 -0000 Hi Pablo, On 9/22/2017 1:25 PM, Pablo de Lara wrote: > Add parameter "qps" in crypto performance app, > to create multiple queue pairs per device. > > This new parameter is useful to have multiple logical > cores using a single crypto device, without needing > to initialize a crypto device per core. > > Signed-off-by: Pablo de Lara > --- > app/test-crypto-perf/cperf_options.h | 2 + > app/test-crypto-perf/cperf_options_parsing.c | 22 ++++++++++ > app/test-crypto-perf/cperf_test_latency.c | 14 +++--- > app/test-crypto-perf/cperf_test_pmd_cyclecount.c | 7 +-- > app/test-crypto-perf/cperf_test_throughput.c | 14 +++--- > app/test-crypto-perf/cperf_test_verify.c | 14 +++--- > app/test-crypto-perf/main.c | 56 ++++++++++++++---------- > doc/guides/tools/cryptoperf.rst | 4 ++ > 8 files changed, 84 insertions(+), 49 deletions(-) > > diff --git a/app/test-crypto-perf/cperf_options.h b/app/test-crypto-perf/cperf_options.h > index 6d339f4..468d5e2 100644 > --- a/app/test-crypto-perf/cperf_options.h > +++ b/app/test-crypto-perf/cperf_options.h > @@ -15,6 +15,7 @@ > #define CPERF_DESC_NB ("desc-nb") > > #define CPERF_DEVTYPE ("devtype") > +#define CPERF_QP_NB ("qp-nb") > #define CPERF_OPTYPE ("optype") > #define CPERF_SESSIONLESS ("sessionless") > #define CPERF_OUT_OF_PLACE ("out-of-place") > @@ -74,6 +75,7 @@ struct cperf_options { > uint32_t segment_sz; > uint32_t test_buffer_size; > uint32_t nb_descriptors; > + uint32_t nb_qps; > > uint32_t sessionless:1; > uint32_t out_of_place:1; > diff --git a/app/test-crypto-perf/cperf_options_parsing.c b/app/test-crypto-perf/cperf_options_parsing.c > index 89f86a2..441cd61 100644 > --- a/app/test-crypto-perf/cperf_options_parsing.c > +++ b/app/test-crypto-perf/cperf_options_parsing.c > @@ -364,6 +364,24 @@ parse_desc_nb(struct cperf_options *opts, const char *arg) > } > > static int > +parse_qp_nb(struct cperf_options *opts, const char *arg) > +{ > + int ret = parse_uint32_t(&opts->nb_qps, arg); > + > + if (ret) { > + RTE_LOG(ERR, USER1, "failed to parse number of queue pairs\n"); > + return -1; > + } > + > + if ((opts->nb_qps == 0) || (opts->nb_qps > 256)) { Shouldn't this be a macro for max nb_qps. Also a generic comment on this patch.. Why do we need an explicit parameter for nb-qps. Can't we do it similar to ipsec-secgw. It takes the devices and maps the queues with core as per the devices' capabilities. -Akhil