From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4288E4582E; Wed, 21 Aug 2024 10:49:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F186540395; Wed, 21 Aug 2024 10:49:21 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by mails.dpdk.org (Postfix) with ESMTP id DEAC64003C for <dev@dpdk.org>; Wed, 21 Aug 2024 10:49:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1724230160; x=1755766160; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=zr/ArUHWU4UODqVCieED/raEPOQtOj7L+EnEDthK2fw=; b=BvOLR0rs0kwl2Y4k05wP84hV7kjxnvGjtXIitUaNh8RMtjAkktcHzjq5 4MRB3a4ULa9+7zXWKrt5X3qVgGHn1HpFyl57Qc5FF01AYp8git2GBmCW4 ZZCTCMx/qc4VCxxxXrOAYOoll/7dfmRrjhinIy3T9dJCzoH1tWjHoZNBG 9mkhIruqlBGo0YM0bxhDFLEkcdUHPY+TK3mDEaG1N4mv1EWKAZesS2wHD E7gCXUIWPRMpujlagM3POYLa5nNkWW+N7PKgdQWULeFmjVRojuj4xJMLj xAfLCgg6b7oxqu5h67hSNPWIgQSG6o2+/Yze1k1mygaqPkK7g70gHABf6 A==; X-CSE-ConnectionGUID: AZQ488xJT86u37+HESwm1Q== X-CSE-MsgGUID: ZKafSKy3Se+4rg0O+3/YCw== X-IronPort-AV: E=McAfee;i="6700,10204,11170"; a="40088489" X-IronPort-AV: E=Sophos;i="6.10,164,1719903600"; d="scan'208";a="40088489" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2024 01:49:18 -0700 X-CSE-ConnectionGUID: S1tvsaB1R4G8BizMBS2Yiw== X-CSE-MsgGUID: Qt1w8a4DQa6982JMgKLiGw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,164,1719903600"; d="scan'208";a="65861503" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa003.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 21 Aug 2024 01:49:18 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 21 Aug 2024 01:49:17 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 21 Aug 2024 01:49:16 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 21 Aug 2024 01:49:16 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.47) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 21 Aug 2024 01:49:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=w5d+8bGlCHaLhGPkY73/oKMgbLw94LtunBkIv9rulWNNCPZClK+xCVf61Gpxie7pUkC8Fj8Y/LhfbAQaG6paR9HMYlZK8TsV1OfM9ojkaYCV/2mogsT9O1N92jJ92vsM6Tm+Qs2LKrYBPtxolHSiY8fHd/8fkEzIswupLzmQPQMQNUGAP4zye6JWYL2+nNIW+AbISIDdvDQVpitoopyFH/mlwDz9VdE4S2svvB2aSq4zMsvDW5+HiIZXQGxqFKKoU1BXqxFmJVBLkJfCv9HVcQ1I8y8c/i6iet+8RUDJpnr1Ln+VmQaG6xgJY2YvFRA1pDQWiXb/jJ/o+qnZVBshYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pg0s7S10s0Fodkq2hpWE0H8/1s7oUwl29zBEuHXVw5Y=; b=B4ggDDdZyCkDLaJXazRfQzdfcyYJdO7IwdBIiTsNcxhXciqJYrLw6nPZOPuKa1gmakXINpI0IJp9QjcOcSSEwcesz7I0qVVfJm8AR0YNNwPtGC2X9uYZQsrgukF4cq0EH7PCJT/5PvsquDRXeZiPogD3u3hqbmdtMHsA7Rx1nCF6hr7hDzeSYNN9IPA3+4Cyr9Bvm4oLtJRumPqBTd2pTrKqdF0gW4I3qGch3gW1sOQ0K+wY6dCXMT5+1eTEOqPtKyc/hzTTNrlxr3TD2CAZzAuQsIIPWhA9s5aX9q9pbml0Qs5wjdHilYFQ3PGqN7xxx/p/0qovLi7I69KQL4OCuw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) by DM6PR11MB4628.namprd11.prod.outlook.com (2603:10b6:5:28f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7897.16; Wed, 21 Aug 2024 08:49:15 +0000 Received: from DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::21e4:2d98:c498:2d7a]) by DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::21e4:2d98:c498:2d7a%4]) with mapi id 15.20.7897.014; Wed, 21 Aug 2024 08:49:14 +0000 Message-ID: <74e5aaae-78ed-4372-92c9-d64017088516@intel.com> Date: Wed, 21 Aug 2024 10:49:09 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/4] usertools/cpu_layout: update coding style To: Robin Jarry <rjarry@redhat.com>, <dev@dpdk.org> CC: <bruce.richardson@intel.com> References: <e51d00fea7c535404dda4d63e483639b13c48b2d.1723634354.git.anatoly.burakov@intel.com> <e55217b1dccdb22c87dc7dd32c05b527ec527591.1724168117.git.anatoly.burakov@intel.com> <D3KV3WCR3DCY.3L23D318I2NVW@redhat.com> Content-Language: en-US From: "Burakov, Anatoly" <anatoly.burakov@intel.com> In-Reply-To: <D3KV3WCR3DCY.3L23D318I2NVW@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB9PR02CA0005.eurprd02.prod.outlook.com (2603:10a6:10:1d9::10) To DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6502:EE_|DM6PR11MB4628:EE_ X-MS-Office365-Filtering-Correlation-Id: 427f21c5-9570-43d1-ee8d-08dcc1be227e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?SnJMSWtCSVUwVzVEVnRUcE9ZaXJUbGZtQnFYUUNtSWFKRVdyaXRqU1VINUpS?= =?utf-8?B?VE1lOU4zcXh6cHV1aGdBZWpqTnFVT0V5VVprbU1RV3ZEbklDeEd3TVkwOEtD?= =?utf-8?B?VnArdjRTbnJ3bW9HVFlON3hXS1R4VzdrSklHWjZ2QXRHTzFPdG5QVVBrWWJ2?= =?utf-8?B?TWY1MnZTUDVDdHo0dFJKT24zdXZ4UEI5ampRSm9wY3oyMm1SeHhvZzFhRDdh?= =?utf-8?B?WjVxYVErZE1hVlk5djRWVVNUdmZ1blIyM2hzNmFOYThLbC9IY3JqVmNNR3pT?= =?utf-8?B?ZURlTTRnVm5Za2I3bG1IcS9BYmMxVEFwRndkN3V1RmNQdlRkTk9HVEl6d25m?= =?utf-8?B?b0RKQktpNjJhWVF6OWpIZm1RVzQrTlh1ZWNZZTBJSXllRGE5QXkyMVB1YVEv?= =?utf-8?B?aDNKem4yMDBCQjlxRGpMR1NKVkl3YjY2b3RQY0NHL29VYXN3SzZ1UHZtNmpS?= =?utf-8?B?a0ZWdXRFcWMyaWNRYldIWFFsMTE3eW43YUYybW52WDFEUnpCbkVtMEc5YU14?= =?utf-8?B?RXpwVXZSaTYwQkxTZThKdFBjd0c5ZTJzWVJsWjJqbFRFcHNGT3FLYUREMzNl?= =?utf-8?B?QkNiRnVpTDBrZkFkM0RFYjRzWVJsZURVeElLMkpqTEhhQ0piejloM1Zsd1Vn?= =?utf-8?B?ZVFyWWxXZGFnOEZvZ2Njcmt2RnRDUlcydzRPUE95dG1xYitSSTFkTjNpMlhp?= =?utf-8?B?QTFsZllUL3FCbnhzYldWa1dUVEtHNXdiZjRocmNvY0J4ekIwN3FnU1B4Znk2?= =?utf-8?B?NkVoLytpQWd3cWNlYjJvWENQcVNnZDVhOFlOczZGcE93aEJGNm1CUjRjanRn?= =?utf-8?B?eTRXSzdOd1dCUzJXVVVkdmNIVjFFK04xbjZxOEtpZ3hic21aRXFlYWJUR0Za?= =?utf-8?B?bmgxcHpWYjVLT01xeUdRM3Yzc2dKajBndzluUEVsT05QeFFveS90TXRjZUdK?= =?utf-8?B?SjFUbWlXL3dTQjQ5eUxGaEl6dGpKSUFqSkplZGFGRjlCbzR6WWdxb0J1cFlU?= =?utf-8?B?ZjR6ZDdmYXVHdjRueWZkSU9jbHNDMWlxbzU5S2VzUENvdFdsZ3VaelZ2cWtU?= =?utf-8?B?TmtwNzgya0IxVENQWkVsSnEzbWR4YTQ3MGZidjhVeDdraERLMWpmSVg4ejQ0?= =?utf-8?B?UFZGb05veDNmMUlUVkxJSTFOZTFWYmJGVWRtTDVpamtBY25waHAzRU0xQ1pQ?= =?utf-8?B?NlJrRGpOSG1XWDUxcDF2eHRHZEYzcUUzZXZZZ2lpSlIxekFaWEVHTUllRis3?= =?utf-8?B?ZXFNM0NuMVFyeG5UMWFhRkliUW5XejBLRXFldXB1ME9xM3JRNGZnTTIwd3Aw?= =?utf-8?B?NE5VdEQvSmMvV0hMTkRPK3hEZkJtUkRNOEhyZmI5QkV1ZERzV29mR0k2bm1E?= =?utf-8?B?MW5IdVRBWm92OGVMOUp5VTFVK0JpTS9WMkR2VUljWExxTG9na3FCb3NaaHMz?= =?utf-8?B?TG9kWVBieFRNNkNNM2RoeldIcHgzdUlLQmdNcUxRbnJKbHdNOURSeE9UODEw?= =?utf-8?B?bk1nb2Nvdk9kRXFraFRXYzFrbXc2Sk84c0FtQ2tDa0lKcWt5K1ZLRU91V2dV?= =?utf-8?B?VlZ6U0ozY0NyYm13bnRZOEU4ekRXUk90UWFWTW9KZnJLc2UzSlV0ODdKeVdW?= =?utf-8?B?MjFGbXFlSGF5TU5yWVg0UGMrWHBZYnBHSHRJZ3FTS0dpTStzWjFCTUFGUDF0?= =?utf-8?B?OXQ2cTdwcVVoS2VsQkpOVklMRDlJSDhlRWhOcTVWTE11WWZiR1FTdUJmQjh4?= =?utf-8?B?aStSQTM4Y0tGOVVmbGNpbHdscUx3NFRqdkxNRmxrUXZUc1JjYlc3bFQzZ2Ja?= =?utf-8?B?Uko0RVZjWmhSZVF5S3pydz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB6502.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R2IwTlZPSzlkcXE3TWYzWVMzUmdRcWhZRHVsMUFQRmNxYys3aTZNdFRESDh2?= =?utf-8?B?dzhtOGVzR1JUeURMR2t5YVk2OU96WGdjamllY0xWS1U0UVZ0djBDTnlwZEhO?= =?utf-8?B?ZndnOHBkSEVPK1VWOTNQTDdUUXZPR2JCZWJOWXNwd05OZm1icVdUR0ROS05E?= =?utf-8?B?OGk1dUFBTXY3ekx4WEtOdzV6ako1VnJSK3UzdzZGdlJGK0I0TE04dzBGZGg5?= =?utf-8?B?QVBlaU9DKzdUMno0U0xiWmRuTDBOd29GRzZ6RzdJM1Q4MDFnbGVhZHFtNWpB?= =?utf-8?B?cCttckRUaU13NGgvdHNGWEl3RG55SmN5b2kzMlM4cE04OTBvemJzeG5Ccjh4?= =?utf-8?B?aVhWRDQzUFNHVVdVN3hiRHJ3UlA2WFhPQzdZdVVEcGtnQk4vMWJCRHNYVUUv?= =?utf-8?B?L1h5MldmcUhpTURYZUVHOHBSZWkxWitsaGlaRExYaUNjblJUT1d3VmkzazFY?= =?utf-8?B?N1p5ejh6eGx0MGFJTjNpb0dtTFF4L1VidmpKTXhYVDBvaFBGWVZmTEhOay9G?= =?utf-8?B?RjlLeEZCTWpUYVg0aDhRVjh6VWZOSnNxT1dkV3B1S3plTlFEdnhVUzZ6TWZH?= =?utf-8?B?WWVZOEpTREI4MVM2U1JZdjB1UWsxV1Qyd0FrMjlEZlB0WWtPLzFuRXluSmtZ?= =?utf-8?B?UUkzbW1sdVpUMHpqU0ttMFRRUGo0SVMzaXh0S25QSzJkYTBMWU5WWURCK0Rq?= =?utf-8?B?NXVON0Jkc3plUXRhSmxEZFYzWGNUTHUyREtuSDZTYjNPN3hpRXlvdUVpODJH?= =?utf-8?B?SWpmQ3pGVzZwdDROaHV4YUFvcXBxanNjeWt6ME9sNmZpSW1lY2FUUXJIVHVs?= =?utf-8?B?QnlSdkN5a2RmK3plMWt2QzAxOXd1bmYwckhFcmdSc2dtWDVENUplR2dvczZU?= =?utf-8?B?R2FOZjVRUmcySi9mZW4xQnVjM2tEZUE1dC9jOS9hV253bWsrVXlIcUNtaEYr?= =?utf-8?B?blpvWENYekJ0MVVzYkdOWmJMZ0hvOHFIQW1yOWc1cjBGSTlYaUhKWktYT1Zx?= =?utf-8?B?WUh5M1RyZzkwRU1VdGNMamtkS2JCTTY4K3l3U0g1SU5LbnV3UFRtSk1vRmMr?= =?utf-8?B?RjYrSk5hWUE0T2cxUkw3aSt2aUVDd0JrQmdpeVZtN2U4djNzY3Z5emxUNzJv?= =?utf-8?B?dDQyaEVzZ0Fxek1HbjVSVG10VXhndzNHWDZhL1lKSktQUElSRmdkMGl2Yjkr?= =?utf-8?B?WTZOc3ppZzhFcy8vR2pGZExwaVBXaGV4bGNUQ3o5a252N25GZlNPZTJqSnkz?= =?utf-8?B?SGN3eVB1cHJHdXFTZnhrNS9hdFl3djFTUUZadC8wMVlSenlycVBOcElxYWJB?= =?utf-8?B?OGhIVHpuUlZyQWJETEo3S0pYZjVVdFBIcjNFMzN6ZXlMbDczUVdDcXlFanJT?= =?utf-8?B?bk5DcmszK0ZROEVvdmtVck1VTTlqOVpDc0VaUG5kd2l3QWlVNjdMTEVSYjBh?= =?utf-8?B?VFNxNzZZVFF0STBjdjdNRU1pdUVudEdnUWJJTjNHUWZ6RlNmazd6RHBZUUIv?= =?utf-8?B?WHhySU9OZ1QyVC82RVpVdDYxb25hNENRTk1ianJDYmpBaUZBOVpYeUdlQkpr?= =?utf-8?B?cDIzeXFQVDhpYzhOM0ZBd25BU21zN0hxL0tVSjNIZmxaTWZoNnNPbHR4Y1Ry?= =?utf-8?B?a0Y5NS9JUjRrQ3RJb09sRDVOVWVFMTZyUnRESVozN3BYVWtLYnloRnU3YUEw?= =?utf-8?B?QUd6cVFXUlZEaEprckJlMTZXeHNQRFlkNU44SG1aOFp3MWZJdlNxOVQxS2Vx?= =?utf-8?B?dmJ5Uy9jbi9FaFhkZ3g0NkxzQWVoUWg3a3pXVnFjd0p2NVJYLys2Zno5L0dj?= =?utf-8?B?bWFvSGxjeU1KeFFxeEQ1Rk5weTZvQjNwUVJmLzlmYVFqSmRBdktoVC9FZlhP?= =?utf-8?B?QWhDNHZaTE42WVBmY1BWTloxMDFKMmthc201K3kzSGZEbW5sU1E0cHBrSEU2?= =?utf-8?B?eUUxQldvaEswZ3pvRHRFZThKc0pBQlA3QlBMTHdYNEZPRkdGZW8vVEZQZ2po?= =?utf-8?B?QWRkWHpaZWF2anB4SXVZRmwzK2wzZVJiZHBzZUpZRDBtQXRxVTVTQ1lUa0lJ?= =?utf-8?B?M2ZPWCs1MStyakFQTDdHVnB3QzQ2dkp5TnBhQ3BBaUpTMGVtVllBV3ZHWFhj?= =?utf-8?B?UHA1Tm53aUVNYkd6c1VsdVc4TnpUVzZLMDhyYVNoaUV1VkVwY2UrUlIxdVpp?= =?utf-8?B?OHc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 427f21c5-9570-43d1-ee8d-08dcc1be227e X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6502.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Aug 2024 08:49:14.8502 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5USWsfEKdjqhNOjfZHPbJrTvsCKXjZ+9Hf0S+2Mjgp1bMi3QdA0qF4LP3M9f5PiNDWuM0k8rpAF3ovk7Khpr21K6OVxdcPtAOXCKDgzzOcI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4628 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On 8/20/2024 5:59 PM, Robin Jarry wrote: > Anatoly Burakov, Aug 20, 2024 at 17:35: >> Update coding style: >> >> - make it PEP-484 compliant >> - address all flake8, mypy etc. warnings >> - use f-strings in place of old-style string interpolation >> - refactor printing to make the code more readable >> - read valid CPU ID's from "online" sysfs node >> >> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com> >> --- >> >> Notes: >> v1,v2 -> v3: >> - Import typing as T instead of individual types > > Looks good to me. Same remark than dpdk-hugepages.py: could you format > it using black or ruff? > > Thanks! > Hi, My IDE is already set up to auto-format with Ruff since our last conversation, so this is already formatted. I ran ruff format command just in case but it produced no changes. -- Thanks, Anatoly