From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 251CCA0543;
	Thu,  7 Jul 2022 14:52:41 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id AF780406B4;
	Thu,  7 Jul 2022 14:52:40 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 7147A4069D
 for <dev@dpdk.org>; Thu,  7 Jul 2022 14:52:39 +0200 (CEST)
Received: from [192.168.1.38] (unknown [188.170.75.69])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 7AFD6CB;
 Thu,  7 Jul 2022 15:52:38 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 7AFD6CB
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1657198358;
 bh=XwWcRORBB9GJT/Tz3N5X/dI2r0J2U4OGlbnMM+VdPKE=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=dedOz/oGLssd/mO35EJWQPVJ7F/rjFwKC/7tcZNq2MVKCOg2WF2Cb4COpj3swItbK
 UZ+ydA/9uJoBxDUsbWTF5GyX09RpgK8pz9e/gfvMo4GoJVtqmBLwr+lK63s5Ejw9C/
 0DVt73ltof+mQ93xwZk2n4d2lqvLzO56+rr3pknk=
Message-ID: <74f0f801-46a9-c407-e6df-ccd48ac1d817@oktetlabs.ru>
Date: Thu, 7 Jul 2022 15:52:37 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH] doc: announce changes to rte_eth_set_queue_rate_limit api
Content-Language: en-US
To: skoteshwar@marvell.com, Ray Kinsella <mdr@ashroe.eu>
Cc: dev@dpdk.org
References: <1656689558-27482-1-git-send-email-skoteshwar@marvell.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
In-Reply-To: <1656689558-27482-1-git-send-email-skoteshwar@marvell.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 7/1/22 18:32, skoteshwar@marvell.com wrote:
> From: Satha Rao <skoteshwar@marvell.com>
> 
> rte_eth_set_queue_rate_limit argument rate modified to uint64_t
> to support more than 64Gbps.
> 
> Signed-off-by: Satha Rao <skoteshwar@marvell.com>
> ---
>   doc/guides/rel_notes/deprecation.rst | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 4e5b23c..5bf2b72 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -125,3 +125,8 @@ Deprecation Notices
>     applications should be updated to use the ``dmadev`` library instead,
>     with the underlying HW-functionality being provided by the ``ioat`` or
>     ``idxd`` dma drivers
> +
> +* ethdev: The function ``rte_eth_set_queue_rate_limit`` takes ``rate`` in Mbps.
> +  This parameter declared as uint16_t, queue rate limited to 64Gbps. ``rate``
> +  parameter will be modified to uint64_t in DPDK 22.11 so that it can work for
> +  more than 64Gbps.

I fully agree that uint16_t is not enough, but I'd like to understand
the reason behind uint64_t vs uint32_t. It looks like uint32_t is more
than enough.