From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF134A00C3; Fri, 15 May 2020 12:46:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 090ED1DAF6; Fri, 15 May 2020 12:46:36 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id BE65B1DAE9 for ; Fri, 15 May 2020 12:46:33 +0200 (CEST) IronPort-SDR: E6GFE4wvC10R3U4quSDQPCWDnOLf+iSuUZ4xX5JNDHpD3dRCoEE8RW8fm8CgNWodIamZouBCt3 zN8hAi3P0Zag== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2020 03:46:32 -0700 IronPort-SDR: wVEF62qAxnjkja7wlS57hZRI7NTMpPqMEaswFv7eAK18BSnk0qlfakL6dFpTCl/9YxK5MJpruZ q6Ddfq/EefDQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,395,1583222400"; d="scan'208";a="438269338" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.213.193.167]) ([10.213.193.167]) by orsmga005.jf.intel.com with ESMTP; 15 May 2020 03:46:31 -0700 To: "Wei Hu (Xavier)" , Chas Williams <3chas3@gmail.com> Cc: dev@dpdk.org, Thomas Monjalon , David Marchand References: <20200417081918.14029-1-huwei013@chinasoftinc.com> <20200417081918.14029-3-huwei013@chinasoftinc.com> <51349b04-6b23-69d8-69f8-bde7f54c866e@chinasoftinc.com> <24fd0081-edf3-326c-2a14-58c246bd24f7@chinasoftinc.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJsBBMBCgBWAhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEABQkKqZZ8FiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl6ha3sXGHZrczovL2tl eXMub3BlbnBncC5vcmcACgkQ+TPrQ98TYR8uLA//QwltuFliUWe60xwmu9sY38c1DXvX67wk UryQ1WijVdIoj4H8cf/s2KtyIBjc89R254KMEfJDao/LrXqJ69KyGKXFhFPlF3VmFLsN4XiT PSfxkx8s6kHVaB3O183p4xAqnnl/ql8nJ5ph9HuwdL8CyO5/7dC/MjZ/mc4NGq5O9zk3YRGO lvdZAp5HW9VKW4iynvy7rl3tKyEqaAE62MbGyfJDH3C/nV/4+mPc8Av5rRH2hV+DBQourwuC ci6noiDP6GCNQqTh1FHYvXaN4GPMHD9DX6LtT8Fc5mL/V9i9kEVikPohlI0WJqhE+vQHFzR2 1q5nznE+pweYsBi3LXIMYpmha9oJh03dJOdKAEhkfBr6n8BWkWQMMiwfdzg20JX0o7a/iF8H 4dshBs+dXdIKzPfJhMjHxLDFNPNH8zRQkB02JceY9ESEah3wAbzTwz+e/9qQ5OyDTQjKkVOo cxC2U7CqeNt0JZi0tmuzIWrfxjAUulVhBmnceqyMOzGpSCQIkvalb6+eXsC9V1DZ4zsHZ2Mx Hi+7pCksdraXUhKdg5bOVCt8XFmx1MX4AoV3GWy6mZ4eMMvJN2hjXcrreQgG25BdCdcxKgqp e9cMbCtF+RZax8U6LkAWueJJ1QXrav1Jk5SnG8/5xANQoBQKGz+yFiWcgEs9Tpxth15o2v59 gXK5Ag0EV9ZMvgEQAKc0Db17xNqtSwEvmfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ES YpV8QWj0xK4YM0dLxnDU2IYxjEshSB1TqAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4Ai bPtrHuIXWQOBECcVZTTOdZYGAzaYzxiAONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxD UQljeNvKYt1lZE/gAUUxNLWsYyTT+22/vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/ 3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35piVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVj sM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQI3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdc q9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYHfVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH7 1PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZqw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFB VOQOxCvwRG2QCgcJ/UTn5vlivul+cThi6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI 8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJlRr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYC GwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNhHwUCXqFrngUJCKxSYAAKCRD5M+tD3xNhH3YWD/9b cUiWaHJasX+OpiuZ1Li5GG3m9aw4lR/k2lET0UPRer2Jy1JsL+uqzdkxGvPqzFTBXgx/6Byz EMa2mt6R9BCyR286s3lxVS5Bgr5JGB3EkpPcoJT3A7QOYMV95jBiiJTy78Qdzi5LrIu4tW6H o0MWUjpjdbR01cnj6EagKrDx9kAsqQTfvz4ff5JIFyKSKEHQMaz1YGHyCWhsTwqONhs0G7V2 0taQS1bGiaWND0dIBJ/u0pU998XZhmMzn765H+/MqXsyDXwoHv1rcaX/kcZIcN3sLUVcbdxA WHXOktGTQemQfEpCNuf2jeeJlp8sHmAQmV3dLS1R49h0q7hH4qOPEIvXjQebJGs5W7s2vxbA 5u5nLujmMkkfg1XHsds0u7Zdp2n200VC4GQf8vsUp6CSMgjedHeF9zKv1W4lYXpHp576ZV7T GgsEsvveAE1xvHnpV9d7ZehPuZfYlP4qgo2iutA1c0AXZLn5LPcDBgZ+KQZTzm05RU1gkx7n gL9CdTzVrYFy7Y5R+TrE9HFUnsaXaGsJwOB/emByGPQEKrupz8CZFi9pkqPuAPwjN6Wonokv ChAewHXPUadcJmCTj78Oeg9uXR6yjpxyFjx3vdijQIYgi5TEGpeTQBymLANOYxYWYOjXk+ae dYuOYKR9nbPv+2zK9pwwQ2NXbUBystaGyQ== Message-ID: <750fc71a-e4fc-d5a7-9bca-551d7ed4b32c@intel.com> Date: Fri, 15 May 2020 11:46:30 +0100 MIME-Version: 1.0 In-Reply-To: <24fd0081-edf3-326c-2a14-58c246bd24f7@chinasoftinc.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 2/2] net/bonding: fix MAC address when one port resets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/15/2020 4:11 AM, Wei Hu (Xavier) wrote: > Hi, Ferruh Yigit & Chas Williams > Could you please give any suggestion? Hi Xavier, Unfortunately we are missing reviews in bonding patches. There are a few more waiting other than this one. If you are already working on it and have enough information about the code, what do you think adding you as the additional maintainer? Thanks, ferruh > Thanks. > > Best Regards > Xavier > > On 2020/4/17 16:58, Wei Hu (Xavier) wrote: >> Hi, Chas Williams >>    Thanks for your comments on Patch V1. now we have sent Patch V2. >>    Could you please give some suggestion on them? >>    Thanks. >> >>    Best Regards >> Xavier >> >> On 2020/4/17 16:19, Wei Hu (Xavier) wrote: >>> From: "Wei Hu (Xavier)" >>> >>> Currently, based on a active-backup bond device, in the following 2 >>> cases: >>> 1) The primary port resets. The link status of the primary port changes >>>     from up to down. >>> 2) When switching the active port, one slave port resets at the same >>> time. >>> one slave port changes to the primary port, but the new primary port's >>> MAC >>> address probably cannot change to the bond device's MAC address. And we >>> can't continue receive packets whose destination MAC addresses are the >>> same >>> as the bond devices's MAC address. >>> >>> The current bonding PMD driver call mac_address_slaves_update function to >>> modify the MAC address of all slaves devices. In >>> mac_address_slaves_update >>> function, the rte_eth_dev_default_mac_addr_set API function is called to >>> set the MAC address of the slave devices in turn in the for loop >>> statement. >>> >>> When one port reset, calling rte_eth_dev_default_mac_addr_set API fails >>> because the firmware will not respond to the commands from the driver, >>> and exit the loop, so other slave devices cannot continue to update the >>> MAC address. >>> >>> This patch fixes the issue by avoid exiting the loop when calling >>> rte_eth_dev_default_mac_addr_set fails. >>> >>> Fixes: 2efb58cbab6e ("bond: new link bonding library") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Hongbo Zheng >>> Signed-off-by: Wei Hu (Xavier) >>> Signed-off-by: Chunsong Feng >>> Signed-off-by: Xuan Li >>> --- >>> v1 -> v2: >>>     Ignore the failure when updating salves's MAC address in the >>>     mac_address_slaves_update function, because it doesn't affect >>>     the bond's functional characteristics. The related link about >>>     the discussion: >>>     http://patches.dpdk.org/patch/66033/ >>> --- >>>   drivers/net/bonding/rte_eth_bond_pmd.c | 7 +++++-- >>>   1 file changed, 5 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c >>> b/drivers/net/bonding/rte_eth_bond_pmd.c >>> index ddae3518c..01c0f6eb1 100644 >>> --- a/drivers/net/bonding/rte_eth_bond_pmd.c >>> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c >>> @@ -1502,6 +1502,7 @@ int >>>   mac_address_slaves_update(struct rte_eth_dev *bonded_eth_dev) >>>   { >>>       struct bond_dev_private *internals = >>> bonded_eth_dev->data->dev_private; >>> +    bool setted; >>>       int i; >>>       /* Update slave devices MAC addresses */ >>> @@ -1529,6 +1530,7 @@ mac_address_slaves_update(struct rte_eth_dev >>> *bonded_eth_dev) >>>       case BONDING_MODE_TLB: >>>       case BONDING_MODE_ALB: >>>       default: >>> +        setted = true; >>>           for (i = 0; i < internals->slave_count; i++) { >>>               if (internals->slaves[i].port_id == >>>                       internals->current_primary_port) { >>> @@ -1537,7 +1539,7 @@ mac_address_slaves_update(struct rte_eth_dev >>> *bonded_eth_dev) >>>                           bonded_eth_dev->data->mac_addrs)) { >>>                       RTE_BOND_LOG(ERR, "Failed to update port Id %d >>> MAC address", >>>                               internals->current_primary_port); >>> -                    return -1; >>> +                    setted = false; >>>                   } >>>               } else { >>>                   if (rte_eth_dev_default_mac_addr_set( >>> @@ -1545,10 +1547,11 @@ mac_address_slaves_update(struct rte_eth_dev >>> *bonded_eth_dev) >>>                           &internals->slaves[i].persisted_mac_addr)) { >>>                       RTE_BOND_LOG(ERR, "Failed to update port Id %d >>> MAC address", >>>                               internals->slaves[i].port_id); >>> -                    return -1; >>>                   } >>>               } >>>           } >>> +        if (!setted) >>> +            return -1; >>>       } >>>       return 0; >>>