From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 316ADA034F; Mon, 29 Mar 2021 14:10:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AF32B40151; Mon, 29 Mar 2021 14:10:49 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by mails.dpdk.org (Postfix) with ESMTP id 73C5A40042 for ; Mon, 29 Mar 2021 14:10:48 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id EA61D15B3; Mon, 29 Mar 2021 08:10:46 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 29 Mar 2021 08:10:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= FyKDpsDT0FkNmGK0rGypnkAvSsWxlLJ14O5St6Z/+Jw=; b=H0XhDxoFtj3cP2H1 +dGZbxaJuMkFGTcEoT1vVt1xcAFOrAtQGTF4VVZGTTzuQw8K1F6yRcSSE/eT6eCg BGgdcEpj5BeIMkoLKluoMdjA6eC/MOEaXnA+zGWTPrwbOZqOzqzGK41tAn4WqwoR dz9EVAz36WJRAWDmBblgqhpsKVK1iq08IFMpzp9PkghE9yRSSRrdI6uCW1w6blp3 7ZxydVX4g7URqV9qw5y39sgae5R+6h/p8qeUsmagS405Wt/jTpnr2bms/n+Sooun otNaFT3aKF6O9fMlrskYQqmpVVewB/woeHyZeG20u8I5GenZdETQx2YfLpWYbARZ d/1THg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=FyKDpsDT0FkNmGK0rGypnkAvSsWxlLJ14O5St6Z/+ Jw=; b=wx1ttCsFSdLt1WU+fyBmtB8XZmJR0EbsHcnTcn1BHQFQJLex1wtuggyOE bzb6RR9N/qNiMyaZ6YNJ9qZrUqAvnk12xqzArwdw6PtAXCpHL4M3+HVAC0YnKjgv QZkyDh4TpwnNvtmgDo21TM7MEM+Xs6LcJfZUUhX3PR9akhSyPv/f3vfv8crI33cG ZdMS3+LbfTabsDDno3dX6pK33U1eqt5IY/mVtb0ADm3CMwqAFc2Jep9VqAJoMeuY /cibG4NYK/FqV1gQ8/TJsNAjxsiYGb4uFk0nxci/FcTvKrj4MJ+cNdxvIRxMhiUn bQZciY7Xu5TRqJQ/aEJbpQSwztGgw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudehkedghedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4D9101080064; Mon, 29 Mar 2021 08:10:44 -0400 (EDT) From: Thomas Monjalon To: Tyler Retzlaff , Ferruh Yigit Cc: dev@dpdk.org, andrew.rybchenko@oktetlabs.ru, bruce.richardson@intel.com, Shepard Siegel , David Marchand Date: Mon, 29 Mar 2021 14:10:43 +0200 Message-ID: <7513292.jyfq3xXJVz@thomas> In-Reply-To: <0d7346c6-09fb-60ca-e3e5-ac63717fbddb@intel.com> References: <1615490833-23052-1-git-send-email-roretzla@linux.microsoft.com> <20210326205216.GA4066@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <0d7346c6-09fb-60ca-e3e5-ac63717fbddb@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] ethdev: introduce enable_driver_sdk to install driver headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 29/03/2021 11:43, Ferruh Yigit: > On 3/26/2021 8:52 PM, Tyler Retzlaff wrote: > > On Fri, Mar 26, 2021 at 12:02:55PM +0000, Ferruh Yigit wrote: > >> On 3/24/2021 4:24 PM, Tyler Retzlaff wrote: > >>> On Wed, Mar 24, 2021 at 12:30:36PM +0100, Thomas Monjalon wrote: > >>>> 24/03/2021 12:27, Ferruh Yigit: > >>>>> > >>>>> But not sure how to manage the same problem for whole project, if install all > >>>>> headers in one patch, or add them gradually via separate patches by time ... > >>>> > >>>> We did a cleanup in ethdev but not in other driver classes. > >>>> When the cleanup will be done gradually, the headers > >>>> must move in this new category driver_sdk_headers. > >>> > >>> yes, some headers are not installed now. so they need only to have > >>> their api marked __rte_internal and installed (since there should be no > >>> external consumer as a function of not being installed) > >>> > >>> the more difficult case is where headers were installed but the api were > >>> not marked __rte_internal and appear in the stable version.map. for > >>> those i guess deprecation notice has to be issued before marking as > >>> internal. > >>> > >> > >> Are you referring to any specific APIs, can you share list of them? > > > > i can't remember the whole list but Thomas originally indicated the > > following candidate list. > > > > baseband/ -> librte_bbdev/rte_bbdev_pmd.h > > bus/ -> rte_bus.h > > common/ -> no interface > > crypto/ -> librte_cryptodev/rte_cryptodev_pmd.h > > event/ -> librte_eventdev/ > > mempool/ -> librte_mempool/ > > net/ -> librte_ethdev/ > > raw/ -> librte_rawdev/rte_rawdev_pmd.h > > regex/ -> librte_regexdev/rte_regexdev_driver.h > > vdpa/ -> librte_vhost/rte_vdpa_dev.h > > > > some of these headers are not published, some are. > > > > These are public headers, so they should not have '__rte_internal' functions, > are you saying some of public headers has internal functions that are presented > as public APIs? These are the headers for use by the drivers. We should classify them as SDK headers, not API.