From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 8ADE75688 for ; Mon, 17 Dec 2018 12:03:07 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 39BBD4623F; Mon, 17 Dec 2018 11:03:06 +0000 (UTC) Received: from [10.36.112.10] (unknown [10.36.112.10]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5412760920; Mon, 17 Dec 2018 11:03:03 +0000 (UTC) To: "Wang, Xiao W" , "Bie, Tiwei" Cc: "alejandro.lucero@netronome.com" , "dev@dpdk.org" , "Wang, Zhihong" , "Ye, Xiaolong" References: <20181213100910.13087-2-xiao.w.wang@intel.com> <20181214211612.167681-1-xiao.w.wang@intel.com> <20181214211612.167681-4-xiao.w.wang@intel.com> From: Maxime Coquelin Message-ID: <7534f85d-4e4d-5a63-7b7d-9ab450578998@redhat.com> Date: Mon, 17 Dec 2018 12:02:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Mon, 17 Dec 2018 11:03:06 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v4 03/10] vhost: provide helpers for virtio ring relay X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Dec 2018 11:03:07 -0000 Hi Xiao, On 12/17/18 9:51 AM, Wang, Xiao W wrote: > Hi Maxime, > >> -----Original Message----- >> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com] >> Sent: Sunday, December 16, 2018 1:11 AM >> To: Wang, Xiao W ; Bie, Tiwei >> Cc: alejandro.lucero@netronome.com; dev@dpdk.org; Wang, Zhihong >> ; Ye, Xiaolong >> Subject: Re: [PATCH v4 03/10] vhost: provide helpers for virtio ring relay >> >> >> >> On 12/14/18 10:16 PM, Xiao Wang wrote: >>> This patch provides two helpers for vdpa device driver to perform a >>> relay between the guest virtio ring and a mediate virtio ring. >> >> s/mediate/mediated/ ? >> I'm not 100% sure, but if it is mediated, please change everywhere else >> in the patch. > > "mediate" can also be used as an adjective, so "mediate" is OK here. I got the confirmation from a native speaker that mediate sounds wrong in this context, and mediated should be used. >> >>> >>> The available ring relay will synchronize the available entries, and >>> helps to do desc validity checking. >> >> s/helps/help/ > > Yes, will update. > >> >>> >>> The used ring relay will synchronize the used entries from mediate ring >>> to guest ring, and helps to do dirty page logging for live migration. >> >> s/helps/help/ > > Will update. > > Thanks for the comments, > Xiao > >> >>> >>> The next patch will leverage these two helpers. >>> >>> Signed-off-by: Xiao Wang >>> --- >>> lib/librte_vhost/rte_vdpa.h | 39 +++++++ >>> lib/librte_vhost/rte_vhost_version.map | 2 + >>> lib/librte_vhost/vdpa.c | 194 >> +++++++++++++++++++++++++++++++++ >>> lib/librte_vhost/vhost.h | 40 +++++++ >>> lib/librte_vhost/virtio_net.c | 39 ------- >>> 5 files changed, 275 insertions(+), 39 deletions(-) >>> >> >> >> Appart from that: >> Reviewed-by: Maxime Coquelin >> >> Thanks, >> Maxime