DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Kuba Kozak <kubax.kozak@intel.com>,
	deepak.k.jain@intel.com, bruce.richardson@intel.com,
	michalx.k.jastrzebski@intel.com, jacekx.piasecki@intel.com,
	dpdk-dev <dev@dpdk.org>,
	Stephen Hemminger <stephen@networkplumber.org>,
	Kevin Traynor <ktraynor@redhat.com>,
	David Marchand <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v5 0/3] EAL change for using a config file for DPDK
Date: Thu, 24 Jan 2019 18:45:09 +0100	[thread overview]
Message-ID: <7547888.LVYzlvvcug@xps> (raw)
In-Reply-To: <ed3a5f16-7305-b5bc-1df3-4b7e16f05b14@intel.com>

24/01/2019 17:18, Ferruh Yigit:
> On 1/24/2019 4:06 PM, Thomas Monjalon wrote:
> > 24/01/2019 15:46, Ferruh Yigit:
> >> On 1/24/2019 2:32 PM, Thomas Monjalon wrote:
> >>> 24/01/2019 14:54, Ferruh Yigit:
> >>>> On 1/23/2019 8:26 PM, Thomas Monjalon wrote:
> >>>>> 23/01/2019 20:31, Ferruh Yigit:
> >>>>>> On 7/13/2017 11:07 AM, kubax.kozak at intel.com (Kuba Kozak) wrote:
> >>>>>>> This patchset introduce a mechanism for running dpdk application with 
> >>>>>>> parameters provided by configuration file.
> >>>>>>>
> >>>>>>> A new API for EAL takes a config file data type - either loaded from
> >>>>>>> file, or built up programmatically in the application - and extracts
> >>>>>>> DPDK parameters from it to be used when eal init is called. 
> >>>>>>> This allows apps to have an alternative method to configure EAL,
> >>>>>>> other than via command-line parameters.
> >>>>>>>
> >>>>>>> Reworked applications are used to demonstrate the new eal API.
> >>>>>>> If a --cfgfile-path <path> option is passed into command line non
> >>>>>>> EAL section, then the file is loaded and used by app. If a file
> >>>>>>> called config.ini is present in current working directory, and
> >>>>>>> no --cfgfile-path option is passed in, config.ini file will be
> >>>>>>> loaded and used by app.
> >>>>>>>
> >>>>>>> Patch "app/testpmd: add parse options from JSON cfg file" 
> >>>>>>> demonstrates the usage of JSON instead of INI file format. 
> >>>>>>> JSON file can be called the same way as above, 
> >>>>>>> through --cfgfile-path <path> argument.
> >>>>>>> ---
> >>>>>>> this patch depends on:
> >>>>>>> "Rework cfgfile API to enable apps config file support"
> >>>>>>>
> >>>>>>> v5:
> >>>>>>>   changed define "RTE_DEVTYPE_VIRTUAL" to "RTE_DEVTYPE_UNDEFINED"
> >>>>>>>   due to compilation errors (changes on current master).
> >>>>>>>
> >>>>>>> v4:
> >>>>>>>  Code optimalisation in parse_vdev_devices() function.
> >>>>>>>  Moved some functions from librte_eal/bsdapp and librte_eal/linuxapp
> >>>>>>>  to the librte_eal/common.
> >>>>>>>  Bug fixes.
> >>>>>>>
> >>>>>>> v3: 
> >>>>>>>  split one patchset into two distinct patchsets:
> >>>>>>>  1. cfgfile library and TEST app changes
> >>>>>>>  2. EAL changes and examples (this patchset depends on cfgfile)
> >>>>>>>
> >>>>>>> v2:
> >>>>>>>   lib eal:
> >>>>>>> 	Rework of rte_eal_configure(struct rte_cfgfile *cfg, char *prgname).
> >>>>>>> 	Now this function load data from cfg structure and did initial
> >>>>>>> 	initialization of EAL arguments. Vdev argument are stored in different
> >>>>>>> 	subsections eg. DPDK.vdev0, DPDK.vdev1 etc. After execution of this
> >>>>>>> 	function it is necessary to call rte_eal_init to complete EAL
> >>>>>>> 	initialization. There is no more merging arguments from different
> >>>>>>> 	sources (cfg file and command line).
> >>>>>>>   	Added non_eal_configure to testpmd application.
> >>>>>>> 	Function maintain the same functionality as rte_eal_configure but
> >>>>>>> 	for non-eal arguments. 
> >>>>>>>   	Added config JSON feature to testpmd last patch from patchset contain
> >>>>>>> 	example showing use of .json configuration files.
> >>>>>>>
> >>>>>>>   lib cfgfile:
> >>>>>>>   	Rework of add_section(), add_entry() new implementation
> >>>>>>>   	New members allocated_entries/sections, free_entries/sections
> >>>>>>> 	in rte_cfgfile structure, change in array of pointers
> >>>>>>> 	**sections, **entries instead of *sections[], *entries[]
> >>>>>>>   	Add  set_entry() to update/overwrite already existing entry in cfgfile
> >>>>>>> 	struct
> >>>>>>>   	Add save() function to save on disc cfgfile structure in INI format
> >>>>>>>   	Rework of existing load() function  simplifying the code
> >>>>>>>   	Add unit test realloc_sections() in TEST app for testing realloc/malloc
> >>>>>>> 	of new API functions, add test for save() function
> >>>>>>>
> >>>>>>> Kuba Kozak (3):
> >>>>>>>   eal: add functions parsing EAL arguments
> >>>>>>>   app/testpmd: add parse options from cfg file
> >>>>>>>   app/testpmd: add parse options from JSON cfg file
> >>>>>>
> >>>>>> This patchset is idle more than a year now.
> >>>>>> It solves problem of eal parameters, it doesn't remove them but at least moves
> >>>>>> from command line to config file.
> >>>>>>
> >>>>>> The patch seems mostly done, but what is the status of it, do we want to
> >>>>>> continue it?
> >>>>>> And if we want to continue it can this be a good candidate for GCOS?
> >>>>>
> >>>>> I think we must focus on reorganization of EAL first.
> >>>>> When the options parsing will be better isolated,
> >>>>> and accessible from API independant of rte_eal_init,
> >>>>> then we could provide some helpers to use those APIs
> >>>>> for a config file, a custom command line or anything else.
> >>>>
> >>>> Is there any actions do we need to take when patches are rejected?
> >>>
> >>> Not sure I understand your question.
> >>> Any opinion about such plan?
> >>
> >> When patch status updated, they will disappear from our radar, should we do
> >> something to remind us this kind of work needs to be done and already some
> >> patches are available to benefit.
> >>
> >> Keeping them in the patchwork is one option, but it is getting hard to manage as
> >> the list grows there, and not all work stays relevant/active in the backlog.
> >> Also their status is not clear in the patchwork backlog.
> > 
> > I think we should add an item in the roadmap with a link to this patch.
> 
> OK. Do you want me do it?

Yes please expose your view in a roadmap patch.
If needed, we can discuss the plan in techboard meeting.

  reply	other threads:[~2019-01-24 17:45 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-30  8:30 [dpdk-dev] [PATCH 0/3] Add support " Jacek Piasecki
2017-05-30  8:30 ` [dpdk-dev] [PATCH 1/3] cfgfile: add new API functions Jacek Piasecki
2017-05-31 14:20   ` Bruce Richardson
2017-05-31 14:22     ` Bruce Richardson
2017-06-26 10:59   ` [dpdk-dev] [PATCH v2 0/7] Add support for using a config file for DPDK Jacek Piasecki
2017-06-26 10:59     ` [dpdk-dev] [PATCH v2 1/7] cfgfile: remove EAL dependency Jacek Piasecki
2017-06-26 13:12       ` Dumitrescu, Cristian
2017-06-27 10:26       ` [dpdk-dev] [PATCH v3 0/4] Rework cfgfile API to enable apps config file support Jacek Piasecki
2017-06-27 10:26         ` [dpdk-dev] [PATCH v3 1/4] cfgfile: remove EAL dependency Jacek Piasecki
2017-06-30  9:44           ` Bruce Richardson
2017-06-30 11:16             ` Bruce Richardson
2017-06-27 10:26         ` [dpdk-dev] [PATCH v3 2/4] cfgfile: add new functions to API Jacek Piasecki
2017-06-30  9:55           ` Bruce Richardson
2017-06-30 10:28           ` Bruce Richardson
2017-06-27 10:26         ` [dpdk-dev] [PATCH v3 3/4] cfgfile: rework of load function Jacek Piasecki
2017-06-30 11:18           ` Bruce Richardson
2017-06-27 10:26         ` [dpdk-dev] [PATCH v3 4/4] test/cfgfile: add new unit test Jacek Piasecki
2017-06-30 11:20         ` [dpdk-dev] [PATCH v3 0/4] Rework cfgfile API to enable apps config file support Bruce Richardson
2017-06-26 10:59     ` [dpdk-dev] [PATCH v2 2/7] cfgfile: add new functions to API Jacek Piasecki
2017-06-26 10:59     ` [dpdk-dev] [PATCH v2 3/7] cfgfile: rework of load function Jacek Piasecki
2017-06-26 10:59     ` [dpdk-dev] [PATCH v2 4/7] test/cfgfile: add new unit test Jacek Piasecki
2017-06-26 10:59     ` [dpdk-dev] [PATCH v2 5/7] eal: add functions parsing EAL arguments Jacek Piasecki
2017-06-27 10:52       ` [dpdk-dev] [PATCH v3 0/3] EAL change for using a config file for DPDK Jacek Piasecki
2017-06-27 10:52         ` [dpdk-dev] [PATCH v3 1/3] eal: add functions parsing EAL arguments Jacek Piasecki
2017-06-30 16:04           ` Bruce Richardson
2017-07-10 12:44           ` [dpdk-dev] [PATCH v4 0/5] Rework cfgfile API to enable apps config file support Jacek Piasecki
2017-07-10 12:44             ` [dpdk-dev] [PATCH v4 1/5] cfgfile: remove EAL dependency Jacek Piasecki
2017-08-30 17:58               ` Bruce Richardson
2017-07-10 12:44             ` [dpdk-dev] [PATCH v4 2/5] cfgfile: change existing API functions Jacek Piasecki
2017-08-30 20:07               ` Bruce Richardson
2017-07-10 12:44             ` [dpdk-dev] [PATCH v4 3/5] cfgfile: add new functions to API Jacek Piasecki
2017-08-30 20:18               ` Bruce Richardson
2017-07-10 12:44             ` [dpdk-dev] [PATCH v4 4/5] cfgfile: rework of load function Jacek Piasecki
2017-08-30 20:24               ` Bruce Richardson
2017-07-10 12:44             ` [dpdk-dev] [PATCH v4 5/5] test/cfgfile: add new unit test Jacek Piasecki
2017-08-30 20:25               ` Bruce Richardson
2017-09-04  9:21                 ` Bruce Richardson
2017-09-04  9:30               ` Bruce Richardson
2017-09-15 13:56                 ` Thomas Monjalon
2017-09-18 13:49                   ` Jastrzebski, MichalX K
2017-07-10 15:13             ` [dpdk-dev] [PATCH v4 0/5] Rework cfgfile API to enable apps config file support Thomas Monjalon
2017-07-20 21:48               ` Thomas Monjalon
2017-07-10 12:51           ` [dpdk-dev] [PATCH v4 0/3] EAL change for using a config file for DPDK Kuba Kozak
2017-07-10 12:51             ` [dpdk-dev] [PATCH v4 1/3] eal: add functions parsing EAL arguments Kuba Kozak
2017-07-13  9:26               ` [dpdk-dev] [PATCH v5 0/3] EAL change for using a config file for DPDK Kuba Kozak
2017-07-13 10:07               ` Kuba Kozak
2017-07-13 10:07                 ` [dpdk-dev] [PATCH v5 1/3] eal: add functions parsing EAL arguments Kuba Kozak
2017-07-13 10:07                 ` [dpdk-dev] [PATCH v5 2/3] app/testpmd: add parse options from cfg file Kuba Kozak
2017-07-13 10:07                 ` [dpdk-dev] [PATCH v5 3/3] app/testpmd: add parse options from JSON " Kuba Kozak
2019-01-23 19:31                 ` [dpdk-dev] [PATCH v5 0/3] EAL change for using a config file for DPDK Ferruh Yigit
2019-01-23 20:26                   ` Thomas Monjalon
2019-01-24 13:54                     ` Ferruh Yigit
2019-01-24 14:32                       ` Thomas Monjalon
2019-01-24 14:46                         ` Ferruh Yigit
2019-01-24 16:06                           ` Thomas Monjalon
2019-01-24 16:18                             ` Ferruh Yigit
2019-01-24 17:45                               ` Thomas Monjalon [this message]
2019-01-28 14:43                                 ` Ferruh Yigit
2017-07-10 12:51             ` [dpdk-dev] [PATCH v4 2/3] app/testpmd: add parse options from cfg file Kuba Kozak
2017-07-10 12:51             ` [dpdk-dev] [PATCH v4 3/3] app/testpmd: add parse options from JSON " Kuba Kozak
2017-06-27 10:52         ` [dpdk-dev] [PATCH v3 2/3] app/testpmd: changed example to parse options from " Jacek Piasecki
2017-06-27 10:52         ` [dpdk-dev] [PATCH v3 3/3] app/testpmd: add parse arguments from JSON config file Jacek Piasecki
2017-07-05  0:00         ` [dpdk-dev] [PATCH v3 0/3] EAL change for using a config file for DPDK Thomas Monjalon
2017-06-26 10:59     ` [dpdk-dev] [PATCH v2 6/7] app/testpmd: changed example to parse options from cfg file Jacek Piasecki
2017-06-26 10:59     ` [dpdk-dev] [PATCH v2 7/7] app/testpmd: add parse arguments from JSON config file Jacek Piasecki
2017-05-30  8:30 ` [dpdk-dev] [PATCH 2/3] eal: add functions parsing EAL arguments Jacek Piasecki
2017-05-31 15:46   ` Bruce Richardson
2017-05-30  8:30 ` [dpdk-dev] [PATCH 3/3] app/testpmd: changed example to parse options from cfg file Jacek Piasecki
2017-06-20  2:13   ` Wu, Jingjing
2017-06-20 10:10     ` Kozak, KubaX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7547888.LVYzlvvcug@xps \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=deepak.k.jain@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jacekx.piasecki@intel.com \
    --cc=ktraynor@redhat.com \
    --cc=kubax.kozak@intel.com \
    --cc=michalx.k.jastrzebski@intel.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).