From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 2B1B7A48D for ; Fri, 12 Jan 2018 12:50:58 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9EBF8210D0; Fri, 12 Jan 2018 06:50:58 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Fri, 12 Jan 2018 06:50:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=rjGe4m4IaqEHbJDODCKM2wOPag Swiw/BYkQ5pU29SxU=; b=KcHPyW7krk9RgmG/ivMKilFkbWYz+O+23kmcr55s/z qkdNVrRo15JFOTY4JNfGaq0XDoGmk7YeRFK0YP5t4DDpN27X/1is3U/IrM06znYh 6JgMOA73nqxDUVju557DUiAT7TUwZ0FLioD/nYMoSyUUw4dFWzJqld5BhcND0qmg I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=rjGe4m 4IaqEHbJDODCKM2wOPagSwiw/BYkQ5pU29SxU=; b=GM5wyL8hlwe1HuST09upAb a4+7/tXbfaSnNst8F5DliMh4WYDRUh7suMdaLY3gCTSNqpo8ribffvjBvEedAaGc w/m8lCkH/4cdLaPdOCPKbvsmU8vLamgHO69n/pqPc2atyczhg2Oa7GPcLZYmjnlN 7r672a15RaaSIf2pNHxBsJHCPk+Dl4Kewq+uBrO9NE3a5JtpON6tqiU0g1WgOOVh gBKAr5xA/9DUdvYNQC2rIOqaglz0Z7sc0M5cCzTe4+HHqOI/QlCbXIoPtiXftaCy BhBm5vW3JuqZBRJxyyxMwGe7jOtTz7PWU2eUKTlJJ9l7Fn5aM7lkdQNNpP2pZIbg == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5751224741; Fri, 12 Jan 2018 06:50:58 -0500 (EST) From: Thomas Monjalon To: "Burakov, Anatoly" Cc: dev@dpdk.org Date: Fri, 12 Jan 2018 12:50:29 +0100 Message-ID: <7548056.EcYGU9teXu@xps> In-Reply-To: <98cb9bdb-d6a0-87f0-548e-ac4e56a4af6a@intel.com> References: <3f9df1ca17e97b2df560d5af5fa31a778af3263f.1513942728.git.anatoly.burakov@intel.com> <1755195.Wuypxit9xt@xps> <98cb9bdb-d6a0-87f0-548e-ac4e56a4af6a@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] eal: add function to return number of detected sockets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jan 2018 11:50:59 -0000 12/01/2018 12:44, Burakov, Anatoly: > On 11-Jan-18 10:20 PM, Thomas Monjalon wrote: > > 22/12/2017 13:41, Anatoly Burakov: > >> During lcore scan, find maximum socket ID and store it. > >> > >> Signed-off-by: Anatoly Burakov > >> --- > >> --- a/lib/librte_eal/common/include/rte_eal.h > >> +++ b/lib/librte_eal/common/include/rte_eal.h > >> @@ -83,6 +83,7 @@ enum rte_proc_type_t { > >> struct rte_config { > >> uint32_t master_lcore; /**< Id of the master lcore */ > >> uint32_t lcore_count; /**< Number of available logical cores. */ > >> + uint32_t numa_node_count; /**< Number of detected NUMA nodes. */ > >> uint32_t service_lcore_count;/**< Number of available service cores. */ > >> enum rte_lcore_role_t lcore_role[RTE_MAX_LCORE]; /**< State of cores. */ > > > > isn't it breaking the ABI? > > > > > > Yep, you're right, forgot to add that. I didn't expect this to get > merged in 18.02 anyway, so v2 will follow. Please write 18.05 in the subject to show your expectation. Thanks