Re: [dpdk-dev] [dpdklab] Re: [PATCH] vhost: rename driver callbacks struct

[Maxime Coquelin <maxime.coquelin@redhat.com>]

On 11/3/21 14:11, Lincoln Lavoie wrote:
> 
> 
> 
> On Wed, Nov 3, 2021 at 5:53 AM Maxime Coquelin 
> <maxime.coquelin@redhat.com <mailto:maxime.coquelin@redhat.com>> wrote:
> 
> 
> 
>     On 11/3/21 09:38, Maxime Coquelin wrote:
>      > Hi David,
>      >
>      > On 11/3/21 09:36, David Marchand wrote:
>      >> On Wed, Nov 3, 2021 at 9:16 AM Xia, Chenbo <chenbo.xia@intel.com
>     <mailto:chenbo.xia@intel.com>> wrote:
>      >>> Testing issues reported in patchwork is expected as SPDK uses
>      >>> this struct, so we can ignore it as SPDK will rename it when it
>      >>> adapts to DPDK 21.11
>      >>
>      >> Please, no.
>      >> We can't simply say "ignore failure in CI".
>      >>
>      >> The SPDK build test must be disabled in CI first.
>      >> You can create a bugzilla and assign it to UNH lab.
>      >> Example: https://bugs.dpdk.org/show_bug.cgi?id=579
>     <https://bugs.dpdk.org/show_bug.cgi?id=579>
>      >>
>      >> Once done, we can merge this patch in DPDK.
>      >>
>      >>
>      >> In parallel, either prepare the patch or talk to SPDK guys to handle
>      >> this change.
>      >> Once this is done, update the bugzilla so that we can get SPDK build
>      >> tested again in CI.
>      >
>      > Thanks for the insights, I'll file a Bz and work with the SPDK team.
> 
>     The Bz has been filed:
>     https://bugs.dpdk.org/show_bug.cgi?id=876
>     <https://bugs.dpdk.org/show_bug.cgi?id=876>
> 
>      > Maxime
>      >> Thanks.
>      >>
>      >>
> 
> SDPK tests have been disabled in the CI testing and shouldn't run for 
> any new patches.  Anything that was already in the queue will finish 
> out.  Bug ticket has been updated.

Thanks Lincoln, as the patch wasn't merged yet, this API change will not
impact other jobs already queued.

> Who from the SPDK team "has the ball" on this item, so we know it's 
> being tracked and worked on?

I think Changpeng Liu in Cc: is the right contact from the SPDK team for
this. For my information, are the SPDK tests based on their main branch
or on the last release?

Thanks,
Maxime

> Cheers,
> Lincoln
> 
> 
> -- 
> *Lincoln Lavoie*
> Principal Engineer, Broadband Technologies
> 21 Madbury Rd., Ste. 100, Durham, NH 03824
> lylavoie@iol.unh.edu <mailto:lylavoie@iol.unh.edu>
> https://www.iol.unh.edu <https://www.iol.unh.edu>
> +1-603-674-2755 (m)
> <https://www.iol.unh.edu>