From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C073E45843; Fri, 23 Aug 2024 09:35:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BB3CD432A2; Fri, 23 Aug 2024 09:34:13 +0200 (CEST) Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11013010.outbound.protection.outlook.com [52.101.67.10]) by mails.dpdk.org (Postfix) with ESMTP id E508442FF9 for ; Fri, 23 Aug 2024 09:33:55 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mXiswp99/1LDSCpxhHA1ib9bDUyxiV8tLpYX0x/amdq0klFZwl2EHnkQtljIeGlrObTQo9qtLQ3fYueg3goTGb+jaERNISEn4R6ThZN8nUfveHQ31OQek8tbO5VpFhEUZwbAdfBnTn2putOSr3O3l2neNDmmImlclBaPSWksZ1RReRJZHn1qX9ghyS3Q0//62OeEL6/9UAcMrKxbYKWfTHuXc3wh1s6NXoZtbF+IHAOnwOT9p8OvSb9Zk6gXEy9vQXIE8caFLlAKhlFIJ2o6lFsqGZqr06StRSB7oYpO1NyUPktu35ImwNVma/NgbDO6UQL+gOf3RBmDkcsgOw+H4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DN6xXc/cg3hN2r9EVKt1Hesv7uCjZWZLFXglsy6/080=; b=Y5DwM1j1P7N12fe8NInCL1PVYP08pF5AX7vIVKOPfcCad2yVYznSPy7TRkrv6qmqkYxsp0u0pN4XzamzmklHHCkcTwizW7whXlba78LCmSueDshrkPckvbwHAzUnG8DxDcJ1QsmVyHbGqq3XXD27sGCxS4G+YmZAKyjorv7SP/k+lL4dCfOCT4HRCzanJKxFnz/ZTlD8SydZuHpT/rxxaem0kVKQ3cqHA7oJW5ich6RO3V13g9zOKL4h3MkJW28ot6iWeOwRtxO75wdWfAAjqPjbsy8oJ7YgK7Nxg/W9uS4EmEDWFs3mm2NLtHEVpqSIWxDctP7BYW1X3cF4La6O4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DN6xXc/cg3hN2r9EVKt1Hesv7uCjZWZLFXglsy6/080=; b=T9OA3HxXItGsnKRs3uOb7g72WTJLuY0p05Ic4X54CU1rwaE8n6CRD/J5REJgGBeEkWIaZ/SibRzBe4Hl9BewQzXowXIsqW9rxUsWleil2Cz6AF6W6uBRG6svD2liGfwEDXXQjywxS4GwzSgtPjpGwWQ6F7pZu+hru6aT3mDPZ79LLhxIQlDcwoKkCqQTLe+B7Jg3IvTCVUlzwBAMEE1yjcMq2fhMGrsf1KbNd4pXg3Tg8J0d4N7aWqlcEYek67rOiynVV1mJfFrMsqB5AGLMwQuFM20KbhSQhIDnOQZKSfiHi3az9jU7Q7pyV9t9soF5+ic4ac3yu+C0/+MvT2GkuA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB9328.eurprd04.prod.outlook.com (2603:10a6:102:2b6::15) by DU2PR04MB8789.eurprd04.prod.outlook.com (2603:10a6:10:2e0::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7897.18; Fri, 23 Aug 2024 07:33:54 +0000 Received: from PAXPR04MB9328.eurprd04.prod.outlook.com ([fe80::367:d59:375:fb87]) by PAXPR04MB9328.eurprd04.prod.outlook.com ([fe80::367:d59:375:fb87%3]) with mapi id 15.20.7875.019; Fri, 23 Aug 2024 07:33:54 +0000 Message-ID: <7576df66-ae89-5332-ce0a-2737f8d6a691@oss.nxp.com> Date: Fri, 23 Aug 2024 13:03:47 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 04/17] bus/dpaa: add port buffer manager stats Content-Language: en-US To: Ferruh Yigit , Hemant Agrawal , dev@dpdk.org Cc: Gagandeep Singh References: <20240801105313.630280-1-hemant.agrawal@nxp.com> <20240801105313.630280-5-hemant.agrawal@nxp.com> <1791f469-ab2c-466a-aa87-a195b7a187de@amd.com> From: Hemant Agrawal In-Reply-To: <1791f469-ab2c-466a-aa87-a195b7a187de@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SG2PR02CA0103.apcprd02.prod.outlook.com (2603:1096:4:92::19) To PAXPR04MB9328.eurprd04.prod.outlook.com (2603:10a6:102:2b6::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9328:EE_|DU2PR04MB8789:EE_ X-MS-Office365-Filtering-Correlation-Id: 8416c40b-df99-4b06-4e74-08dcc345f0fb X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?OXRXU2pYWVNQTFF6OG4wNW9LWUtUK3l0R0k0TVo0bUE2OWwzVXc5ci9oYzl1?= =?utf-8?B?OGJVMUJxNjMwQ3kzMG9nbm5iZUVpZUtkNmcyeTZSL2dtbjhSNDZETG52ZXVK?= =?utf-8?B?ZTgzOFpWNldLeCtnWTc3dW1qQlYrRmhJYWQ4KzNtMmRRN0JwYmxPZHJKa1RZ?= =?utf-8?B?dDFlWlBVcWU0TXBxQUtSOFBqV2tiMFZ6Y1VOMnhvWXVnR0JMWXI0Qko0ZEN5?= =?utf-8?B?TGJ3UmJyclYweHI2cUoyZi81NE9HaVJXcWFoMWR1RkZna21rSjBCUkUvUXRT?= =?utf-8?B?U2NLQ1E3N21hNVE3M0ZYbVhPdDA5VkczcXA2TEo4N1RiMjIwR3hrSWY2N0Qx?= =?utf-8?B?eklzeVYwVTJLUDZlWnBkTW1CNXNXejN5RktkaXMyZnBIREpLQXV3VDdvSmZq?= =?utf-8?B?NnF2R29xOEI2R1R6K2JIOE1henpUbGtGdDBmRUowMEZpUUd4SFJaQ21mVTVx?= =?utf-8?B?RE9HUExuVFdMOEsvTE1pRDBGMHBicnRNNHZGZWhGenZQQXBMMDYxOW9UY1cz?= =?utf-8?B?MHdEYlNSZVU0TEtaTENXVzBZczBjWTdCSXBrOXA3OXVTNnhFTmpGSXV4WE9m?= =?utf-8?B?MUxIamhpU3dMYyt2b21USzJUcGZEbXROUUVHRVFTQjdpNy9jUFVlMlRPdTBw?= =?utf-8?B?VjF5dTI3a3c2aWExdVhiSjI4cExIQ25QdVE0TnE5b0VLK0YxR2t2MU41Zm44?= =?utf-8?B?VnRMaDJyYVIwaVNTaFd1b2MwYU9CaWFPdS9EYld1eUVSUmxKbVErQzUrRVdk?= =?utf-8?B?Rjk1V0FGR1ZoY2ZnMmJWTDkrTUpGci81azArSWd5anNuY1QydlZqZ1owSlNC?= =?utf-8?B?SVVSMGtwZEpqNWZUYlUrd1RRSkw0MVNGYmthK2EwcG5wMjdnUkREdDFaaml5?= =?utf-8?B?UW4yblg2THl5Znd2WHFyNmNzOHN4VmZPUVJzYUprK0dXT1Q2cFcrc2FaVjRa?= =?utf-8?B?ZzFNV2lBRkp0VGlxYVlsZjBRMkZZY09LbEhGWVY2Q0diUVQwdnpjTTB3czNF?= =?utf-8?B?WjJ1M0cvV095eURGRUxpSHVHZkp1VlNkVU1UUlJWYmZuTVNrT0kvOVBMWXRU?= =?utf-8?B?WmlOenMvazdtNkI5WjRob1ZoYUg4M3VUQjJzQVRBVUlSWU1Sb0V5VDJNMGhm?= =?utf-8?B?Q1k4ZXNiOUJWUi9oVFZhdnlxYlp0RWhIOTFIcjlIdi94UDdVTnRxaUdOM3RD?= =?utf-8?B?a29aeHkzanZVd2lmbmZWeno2MU9lWWR6b0RmZlNQTVRtYktyYTViTzZCSWxs?= =?utf-8?B?UTAvTWFHNXVTTE94T25VbERzeVZGWi9HeTFmeU82YTVvN0VNM0RwL0trOGw5?= =?utf-8?B?bkJYY0R2NzV0ODJ0WEljRlNKRncxdU81anZWQU1mNTRlL3Irc3ZON04xOTRG?= =?utf-8?B?L1FJeTl6NCtUT2hFVnB2VU0veGtrRGZmTXJxOFZuZktqODIwQkFuUmNpbXl5?= =?utf-8?B?T0lSUGd0VlVHSVZpYStUamRyWExiQ0w5VDBIV1h0Tmt5Z2hEY3VCWENSODFX?= =?utf-8?B?SisrN2xVVXZMcXJpRHpPZDJiT09XWUs3RnZXbHU5MlQwb2dKeHNxcmZrejR4?= =?utf-8?B?eWVoVVd6S2p4bHpPQUZOWlhwV1RtczRxSjVYNktXLzN3QnhaenJPU0pzVUJa?= =?utf-8?B?bG5BZGNvbzd1R3JKMVlKRWNYSlp4MXNzdTFDWFovdkwvUU9LWit5ZWxGRk96?= =?utf-8?B?QzdYc1h4cmZISTBicDdOeG84ZEhlSGVGVldlbW5UMUhhU205UmZlbFd0cmdq?= =?utf-8?B?SFJlTCtMd2dGUHY4T1I3VSthczRsZVFnSG1WTVVCcExPY2ZybUlyZ3pOcUhF?= =?utf-8?B?bmNMK0M4QjZ0ZTlEemEydz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR04MB9328.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UXVoc0RENGVhRVNFK3VyeE9VTnFYL1dNSUNzK1ppSGtUYmJ4NFZoMFphL0c4?= =?utf-8?B?ZGNzbElndGFLaDA5WFJoM0FSck1KWjFpRWdsZ1ZKOEkxdjdaNUh0Q3BiWXpi?= =?utf-8?B?T1BTTUlRMWVTSE5mNWZmQmVuMGpJZmxwMEE0NzhTaEVWNXNBZUJEbzFNckxN?= =?utf-8?B?bkhwRmszZjNoTVN0NGhNSlo4QUdQekxyK0NpTXBqY1pya2hIWTI4cyt4YlBT?= =?utf-8?B?eEFnaVhsMkx1Q2g1eDZiUWxCa2l4ZDZzYnJRYWR1cXRZTVFkb3k2YndKK1d4?= =?utf-8?B?MWtWcDBwdFNCd2piUDNURzRac2NzMjUrNzFxcEQ1MGMvUUV6NmJQTERkQ3hj?= =?utf-8?B?bUM5bGhYdWxzOUJvOWRWVEIzNXhJSEJYeEFFZENwKzY4UnZSRUp0YUprV1Nt?= =?utf-8?B?dUFaQjFveGZJYjZwSVdaRjhWK3dhWWVyN2pxRXozc1lWNWNiUTJwSFV4Qmxw?= =?utf-8?B?b0haTUtmbjZCTmlzL1c3eEtFTW14bmFKTjdXU0FXbGE0L3JranNmM1JScy9u?= =?utf-8?B?UGh2aG4zRnNud3BRRUcvVVo1Wit1aW4vcnJpcnBQMGxlL2EwMXFTd2lTUnls?= =?utf-8?B?cHpxamhYUG43ZFp5bG5Hd0lwTWswVmdSOWlSeUtPaHlIUis5V0I5cVB0dDdy?= =?utf-8?B?Y1lMNG04WE5DNXhsa0tHeVJSbFZmcFkvUyt5bXg3RG5DcnpqOGpXT1VKc0tz?= =?utf-8?B?YVJYcXVnejJJYkRPakd5VHJiUTNGT3hPbGlZaXNValF0NVlsU05kcmMwYUtx?= =?utf-8?B?bnIzTS92MFhlWHI0NmkvS0FSekNMSVZqZVFqSS92eTVveGtsYzBkeHNzWGxl?= =?utf-8?B?SWFsSzNEL2FSeUlaajNlaEJFc0R2dHlqVlk4bjBOcVlxK09oNDVqaEVCM3BK?= =?utf-8?B?aTlBNUY1Mml4N3Q5TTJ0TGc0bkpYMElNNnYwK0JnS2xWYjMxSkg2WTVXUm91?= =?utf-8?B?YWZIb3liVGJGd2haR0tHN0pUK3RvbGtMRjUyWERiK0kwRmxMQU13eEtGWnh4?= =?utf-8?B?Y3RFWkwrUXpmT1ZDMlNRS2JKTXVka0lCRkkzTUh1bFVoemMxUk9oSU1IbEs5?= =?utf-8?B?cTZuZkVJU09rSk0vU2h5eUZMYitINjRqN2F0STlqZVVGTlpuaFhoRHpMSnpn?= =?utf-8?B?ZnE4VUo5eWxQWkI5eUZJY2NwR0lSNWJvYnp1c1RMaEM3SDc3UFZWOGdsL1Fl?= =?utf-8?B?UGtFYks4QkFJcVdCdVVOR2hHeHJoazNISkEwYTFHeUNOTUd5SHEzY0hrem9o?= =?utf-8?B?T1EyZnluOGwydkpyai9yVEsyRmhmNTBvblZ6OWkzenFYV1d5Zkw2STNUMGFT?= =?utf-8?B?UFNEd0krYVd6SUVCWnZLSVhIZHlhVmFqY2o4WlZQK1lVdkx5TzBpcWFIVmRm?= =?utf-8?B?ZXFHbVBYOExVVlM2MmdEN3E4OWR2bWYwWEkvVENlWEdBeDIyd2JaTVVkWTlk?= =?utf-8?B?dGltOW5Zc3Roak1GVW0yRGh4bzBsVmZJRUlybUNZRVk0UDBRbjFCV3Zldnhi?= =?utf-8?B?d2NLTzFnRWZPNldaTUNpNTdSY2hzaGFmZ2J1T2d4Y2J4azVDN3d1REk5N3Nw?= =?utf-8?B?Sm1HOWRDLzhoOVBTYmozSjhMZjRWVXhreGNjRXUxTkgvc1VlYUwwamIxeUpn?= =?utf-8?B?RER4a3dYelh3UTFzanNZV2lneStmSnA4Q1ZZcHZkRkE5UkNMZmlQem5ZR0Ex?= =?utf-8?B?WEI1Zzl4eWlJQkhWenFORjZYYWplaWpiT0tzaERGRVdUSDJLYjlMNnphVEsy?= =?utf-8?B?KzBhcm9OYldXMGlnZ2VRMkpNMGxhbjVxczh5eUpIN0FJSzVwQkxwaWVCb3Zi?= =?utf-8?B?ZWpKa3lUcW1rUmd6cnlFNkpSQThIazNEZFZIWmo1SEp5bUtiVWJJWW05MHVm?= =?utf-8?B?L3gybnJ6OGZVYzRPdDhjak1KZXBjTGtDT1VQL3pmRGZORDhwYmpuY2pXZEpX?= =?utf-8?B?Tm9iNENxRGVtWWZXSWdxYUpSdWpwTDI3R2ZyTFd0QVVsRFNWQ0hvNnZlYUFF?= =?utf-8?B?Yks4bFBaaDRsamxhdHVtVzhOWHhsbEF2RHlveWhBeEJEQ2phM0dDT1UvbVpV?= =?utf-8?B?cjB3bWhDMVBpZE00Q2JqOTVzN3pSVDRCMnQvakVTZkZrYzhSbUxmalM0c0ov?= =?utf-8?B?cW9LL1N2V2JsYmFrNnZxalJKSEV2T1phN0RRcVpZZlBBcitPVXRKT3ZwNUha?= =?utf-8?B?TFE9PQ==?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8416c40b-df99-4b06-4e74-08dcc345f0fb X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9328.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2024 07:33:54.5122 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jZqbuyY2oiUZuvJlr+2lvGJdnfbnYWEmCGyTNZgG1HT/0W+ZA/+gBtrf1OwaXyq1n1YgmBULkowSzyLMbw7ccQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8789 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 07-08-2024 21:08, Ferruh Yigit wrote: > On 8/1/2024 11:53 AM, Hemant Agrawal wrote: >> Add BMI statistics and improving the existing extended >> statistics >> >> Signed-off-by: Hemant Agrawal >> Signed-off-by: Gagandeep Singh >> --- >> drivers/bus/dpaa/base/fman/fman_hw.c | 65 +++++++++++++++++++++++++++- >> drivers/bus/dpaa/include/fman.h | 4 +- >> drivers/bus/dpaa/include/fsl_fman.h | 12 +++++ >> drivers/bus/dpaa/version.map | 4 ++ >> drivers/net/dpaa/dpaa_ethdev.c | 46 +++++++++++++++++--- >> drivers/net/dpaa/dpaa_ethdev.h | 12 +++++ >> 6 files changed, 134 insertions(+), 9 deletions(-) >> >> diff --git a/drivers/bus/dpaa/base/fman/fman_hw.c b/drivers/bus/dpaa/base/fman/fman_hw.c >> index 24a99f7235..27b39a4975 100644 >> --- a/drivers/bus/dpaa/base/fman/fman_hw.c >> +++ b/drivers/bus/dpaa/base/fman/fman_hw.c >> @@ -244,8 +244,8 @@ fman_if_stats_get_all(struct fman_if *p, uint64_t *value, int n) >> uint64_t base_offset = offsetof(struct memac_regs, reoct_l); >> >> for (i = 0; i < n; i++) >> - value[i] = (((u64)in_be32((char *)regs + base_offset + 8 * i) | >> - (u64)in_be32((char *)regs + base_offset + >> + value[i] = ((u64)in_be32((char *)regs + base_offset + 8 * i) | >> + ((u64)in_be32((char *)regs + base_offset + >> 8 * i + 4)) << 32); >> > Above change looks like a bug fix, it is converting from > "(a | b) << 32" to "a | (b << 32)" > > Syntax wise a small change that is easy to miss, but impacts the result. > > Why not simplify it something like: > uint64_t a = in_be32((char *)regs + base_offset + 8 * i) > uint64_t b = in_be32((char *)regs + base_offset + 8 * i + 4) > value[i] = a | b << 32 > > Anyway, my point is, should it go to its own patch, with fixes tag and > stable tag, so it can be backported to stable releases. > > <...> Thanks for the suggestion.  we made it a separate patch for it.