From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Yang, Qiming" <qiming.yang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 00/40] ice base code update
Date: Fri, 11 Sep 2020 12:07:52 +0100 [thread overview]
Message-ID: <757aaeb7-caa4-2ef4-998b-6f3b4039ec36@intel.com> (raw)
In-Reply-To: <fef06f5f343f408d9bb0ad9849aab781@intel.com>
On 9/10/2020 4:26 AM, Zhang, Qi Z wrote:
>
>
>> -----Original Message-----
>> From: Yang, Qiming <qiming.yang@intel.com>
>> Sent: Wednesday, September 9, 2020 3:17 PM
>> To: Zhang, Qi Z <qi.z.zhang@intel.com>
>> Cc: dev@dpdk.org
>> Subject: RE: [PATCH 00/40] ice base code update
>>
>>
>>
>>> -----Original Message-----
>>> From: Zhang, Qi Z <qi.z.zhang@intel.com>
>>> Sent: Monday, September 7, 2020 19:28
>>> To: Yang, Qiming <qiming.yang@intel.com>
>>> Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>
>>> Subject: [PATCH 00/40] ice base code update
>>>
>>> main changes:
>>> 1. Added support for outer IP filter for GTPC.
>>> 2. Added support for outer IP filter for GPTU control packet (no inner IP) 3.
>>> Added support for QinQ switch filter 4. code refactor and bug fixes
>>>
>>> Qi Zhang (40):
>>> net/ice/base: handle error gracefully in HW table calloc
>>> net/ice/base: split caps discover into two functions
>>> net/ice/base: avoid unnecessary single-member variable-length structs
>>> net/ice/base: fix issues around move nodes
>>> net/ice/base: cleanup stack hog
>>> net/ice/base: clean the code wrapping
>>> net/ice/base: cleanup misleading comment
>>> net/ice/base: silence static analysis warning
>>> net/ice/base: replace single-element array used for C struct hack
>>> net/ice/base: introduce and use bitmap set API
>>> net/ice/base: introduce and use bitmap hamming weight API
>>> net/ice/base: add function header
>>> net/ice/base: introduce and use for each bit iterator
>>> net/ice/base: correct abbreviations
>>> net/ice/base: add AQ cmd 0X0A0A LLDP fltr control
>>> net/ice/base: add support for GTP-U type switch rule
>>> net/ice/base: join format strings to same line
>>> net/ice/base: introduce Tx rate limiting on port level
>>> net/ice/base: reduce profile to recip info get from firmware
>>> net/ice/base: refactor DCB related variables
>>> net/ice/base: support outer IP filter for GTPC
>>> net/ice/base: support outer IP filter for GTPU without inner IP
>>> net/ice/base: move a function
>>> net/ice/base: clear advanced rules in reset preparation
>>> net/ice/base: move a function
>>> net/ice/base: add check for failed acts allocation
>>> net/ice/base: remove repeated words
>>> net/ice/base: remove function ACL count query
>>> net/ice/base: preserve NVM capabilities in safe mode
>>> net/ice/base: misc minor ACL changes
>>> net/ice/base: adjust rate limit profile ids runtime database
>>> net/ice/base: enable QinQ filter for switch advanced rule
>>> net/ice/base: create flash info structure and separate NVM version
>>> net/ice/base: remove unused parameter
>>> net/ice/base: minor code clean
>>> net/ice/base: cache NVM module bank information
>>> net/ice/base: rename function
>>> net/ice/base: remove unnecessary conditional
>>> net/ice/base: rename ACL priority values
>>> net/ice/base: preserve default aggr vsi information
>>>
Hi Qi,
I am getting build error [1], can you please check.
[1]
../drivers/net/ice/ice_rxtx.c: In function ‘ice_tx_queue_start’:
../drivers/net/ice/ice_rxtx.c:486:15: error: array subscript 0 is outside array
bounds of ‘struct ice_aqc_add_txqs_perq[]’ [-Werror=array-bounds]
486 | txq_elem.txqs[0].txq_id = rte_cpu_to_le_16(txq->reg_idx);
| ~~~~~~~~~~~~~^~~
In file included from ../drivers/net/ice/base/ice_controlq.h:8,
from ../drivers/net/ice/base/ice_type.h:52,
from ../drivers/net/ice/base/ice_common.h:8,
from ../drivers/net/ice/ice_ethdev.h:12,
from ../drivers/net/ice/ice_rxtx.h:8,
from ../drivers/net/ice/ice_rxtx.c:9:
../drivers/net/ice/base/ice_adminq_cmd.h:2429:31: note: while referencing ‘txqs’
2429 | struct ice_aqc_add_txqs_perq txqs[STRUCT_HACK_VAR_LEN];
| ^~~~
../drivers/net/ice/ice_rxtx.c:462:29: note: defined here ‘txq_elem’
462 | struct ice_aqc_add_tx_qgrp txq_elem;
| ^~~~~~~~
../drivers/net/ice/ice_rxtx.c:498:54: error: array subscript 0 is outside array
bounds of ‘struct ice_aqc_add_txqs_perq[]’ [-Werror=array-bounds]
498 | ice_set_ctx(hw, (uint8_t *)&tx_ctx, txq_elem.txqs[0].txq_ctx,
| ~~~~~~~~~~~~~~~~^~~~~~~~
In file included from ../drivers/net/ice/base/ice_controlq.h:8,
from ../drivers/net/ice/base/ice_type.h:52,
from ../drivers/net/ice/base/ice_common.h:8,
from ../drivers/net/ice/ice_ethdev.h:12,
from ../drivers/net/ice/ice_rxtx.h:8,
from ../drivers/net/ice/ice_rxtx.c:9:
../drivers/net/ice/base/ice_adminq_cmd.h:2429:31: note: while referencing ‘txqs’
2429 | struct ice_aqc_add_txqs_perq txqs[STRUCT_HACK_VAR_LEN];
| ^~~~
../drivers/net/ice/ice_rxtx.c:462:29: note: defined here ‘txq_elem’
462 | struct ice_aqc_add_tx_qgrp txq_elem;
| ^~~~~~~~
../drivers/net/ice/ice_rxtx.c:514:29: error: array subscript 0 is outside array
bounds of ‘struct ice_aqc_add_txqs_perq[]’ [-Werror=array-bounds]
514 | txq->q_teid = txq_elem.txqs[0].q_teid;
| ~~~~~~~~~~~~~^~~
In file included from ../drivers/net/ice/base/ice_controlq.h:8,
from ../drivers/net/ice/base/ice_type.h:52,
from ../drivers/net/ice/base/ice_common.h:8,
from ../drivers/net/ice/ice_ethdev.h:12,
from ../drivers/net/ice/ice_rxtx.h:8,
from ../drivers/net/ice/ice_rxtx.c:9:
../drivers/net/ice/base/ice_adminq_cmd.h:2429:31: note: while referencing ‘txqs’
2429 | struct ice_aqc_add_txqs_perq txqs[STRUCT_HACK_VAR_LEN];
| ^~~~
../drivers/net/ice/ice_rxtx.c:462:29: note: defined here ‘txq_elem’
462 | struct ice_aqc_add_tx_qgrp txq_elem;
| ^~~~~~~~
../drivers/net/ice/ice_rxtx.c: In function ‘ice_fdir_tx_queue_start’:
../drivers/net/ice/ice_rxtx.c:658:15: error: array subscript 0 is outside array
bounds of ‘struct ice_aqc_add_txqs_perq[]’ [-Werror=array-bounds]
658 | txq_elem.txqs[0].txq_id = rte_cpu_to_le_16(txq->reg_idx);
| ~~~~~~~~~~~~~^~~
In file included from ../drivers/net/ice/base/ice_controlq.h:8,
from ../drivers/net/ice/base/ice_type.h:52,
from ../drivers/net/ice/base/ice_common.h:8,
from ../drivers/net/ice/ice_ethdev.h:12,
from ../drivers/net/ice/ice_rxtx.h:8,
from ../drivers/net/ice/ice_rxtx.c:9:
../drivers/net/ice/base/ice_adminq_cmd.h:2429:31: note: while referencing ‘txqs’
2429 | struct ice_aqc_add_txqs_perq txqs[STRUCT_HACK_VAR_LEN];
| ^~~~
../drivers/net/ice/ice_rxtx.c:640:29: note: defined here ‘txq_elem’
640 | struct ice_aqc_add_tx_qgrp txq_elem;
| ^~~~~~~~
../drivers/net/ice/ice_rxtx.c:670:54: error: array subscript 0 is outside array
bounds of ‘struct ice_aqc_add_txqs_perq[]’ [-Werror=array-bounds]
670 | ice_set_ctx(hw, (uint8_t *)&tx_ctx, txq_elem.txqs[0].txq_ctx,
| ~~~~~~~~~~~~~~~~^~~~~~~~
In file included from ../drivers/net/ice/base/ice_controlq.h:8,
from ../drivers/net/ice/base/ice_type.h:52,
from ../drivers/net/ice/base/ice_common.h:8,
from ../drivers/net/ice/ice_ethdev.h:12,
from ../drivers/net/ice/ice_rxtx.h:8,
from ../drivers/net/ice/ice_rxtx.c:9:
../drivers/net/ice/base/ice_adminq_cmd.h:2429:31: note: while referencing ‘txqs’
2429 | struct ice_aqc_add_txqs_perq txqs[STRUCT_HACK_VAR_LEN];
| ^~~~
../drivers/net/ice/ice_rxtx.c:640:29: note: defined here ‘txq_elem’
640 | struct ice_aqc_add_tx_qgrp txq_elem;
| ^~~~~~~~
../drivers/net/ice/ice_rxtx.c:686:29: error: array subscript 0 is outside array
bounds of ‘struct ice_aqc_add_txqs_perq[]’ [-Werror=array-bounds]
686 | txq->q_teid = txq_elem.txqs[0].q_teid;
| ~~~~~~~~~~~~~^~~
In file included from ../drivers/net/ice/base/ice_controlq.h:8,
from ../drivers/net/ice/base/ice_type.h:52,
from ../drivers/net/ice/base/ice_common.h:8,
from ../drivers/net/ice/ice_ethdev.h:12,
from ../drivers/net/ice/ice_rxtx.h:8,
from ../drivers/net/ice/ice_rxtx.c:9:
../drivers/net/ice/base/ice_adminq_cmd.h:2429:31: note: while referencing ‘txqs’
2429 | struct ice_aqc_add_txqs_perq txqs[STRUCT_HACK_VAR_LEN];
| ^~~~
../drivers/net/ice/ice_rxtx.c:640:29: note: defined here ‘txq_elem’
640 | struct ice_aqc_add_tx_qgrp txq_elem;
| ^~~~~~~~
cc1: all warnings being treated as errors
next prev parent reply other threads:[~2020-09-11 11:08 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 11:27 Qi Zhang
2020-09-07 11:27 ` [dpdk-dev] [PATCH 01/40] net/ice/base: handle error gracefully in HW table calloc Qi Zhang
2020-09-07 11:27 ` [dpdk-dev] [PATCH 02/40] net/ice/base: split caps discover into two functions Qi Zhang
2020-09-07 11:27 ` [dpdk-dev] [PATCH 03/40] net/ice/base: avoid unnecessary single-member variable-length structs Qi Zhang
2020-09-07 11:27 ` [dpdk-dev] [PATCH 04/40] net/ice/base: fix issues around move nodes Qi Zhang
2020-09-07 11:27 ` [dpdk-dev] [PATCH 05/40] net/ice/base: cleanup stack hog Qi Zhang
2020-09-07 11:27 ` [dpdk-dev] [PATCH 06/40] net/ice/base: clean the code wrapping Qi Zhang
2020-09-07 11:27 ` [dpdk-dev] [PATCH 07/40] net/ice/base: cleanup misleading comment Qi Zhang
2020-09-07 11:27 ` [dpdk-dev] [PATCH 08/40] net/ice/base: silence static analysis warning Qi Zhang
2020-09-07 11:27 ` [dpdk-dev] [PATCH 09/40] net/ice/base: replace single-element array used for C struct hack Qi Zhang
2020-09-07 11:27 ` [dpdk-dev] [PATCH 10/40] net/ice/base: introduce and use bitmap set API Qi Zhang
2020-09-07 11:27 ` [dpdk-dev] [PATCH 11/40] net/ice/base: introduce and use bitmap hamming weight API Qi Zhang
2020-09-07 11:27 ` [dpdk-dev] [PATCH 12/40] net/ice/base: add function header Qi Zhang
2020-09-07 11:27 ` [dpdk-dev] [PATCH 13/40] net/ice/base: introduce and use for each bit iterator Qi Zhang
2020-09-07 11:28 ` [dpdk-dev] [PATCH 14/40] net/ice/base: correct abbreviations Qi Zhang
2020-09-07 11:28 ` [dpdk-dev] [PATCH 15/40] net/ice/base: add AQ cmd 0X0A0A LLDP fltr control Qi Zhang
2020-09-07 11:28 ` [dpdk-dev] [PATCH 16/40] net/ice/base: add support for GTP-U type switch rule Qi Zhang
2020-09-07 11:28 ` [dpdk-dev] [PATCH 17/40] net/ice/base: join format strings to same line Qi Zhang
2020-09-07 11:28 ` [dpdk-dev] [PATCH 18/40] net/ice/base: introduce Tx rate limiting on port level Qi Zhang
2020-09-07 11:28 ` [dpdk-dev] [PATCH 19/40] net/ice/base: reduce profile to recip info get from firmware Qi Zhang
2020-09-07 11:28 ` [dpdk-dev] [PATCH 20/40] net/ice/base: refactor DCB related variables Qi Zhang
2020-09-07 11:28 ` [dpdk-dev] [PATCH 21/40] net/ice/base: support outer IP filter for GTPC Qi Zhang
2020-09-07 11:28 ` [dpdk-dev] [PATCH 22/40] net/ice/base: support outer IP filter for GTPU without inner IP Qi Zhang
2020-09-07 11:28 ` [dpdk-dev] [PATCH 23/40] net/ice/base: move a function Qi Zhang
2020-09-07 11:28 ` [dpdk-dev] [PATCH 24/40] net/ice/base: clear advanced rules in reset preparation Qi Zhang
2020-09-07 11:28 ` [dpdk-dev] [PATCH 25/40] net/ice/base: move a function Qi Zhang
2020-09-07 11:28 ` [dpdk-dev] [PATCH 26/40] net/ice/base: add check for failed acts allocation Qi Zhang
2020-09-07 11:28 ` [dpdk-dev] [PATCH 27/40] net/ice/base: remove repeated words Qi Zhang
2020-09-07 11:28 ` [dpdk-dev] [PATCH 28/40] net/ice/base: remove function ACL count query Qi Zhang
2020-09-07 11:28 ` [dpdk-dev] [PATCH 29/40] net/ice/base: preserve NVM capabilities in safe mode Qi Zhang
2020-09-07 11:28 ` [dpdk-dev] [PATCH 30/40] net/ice/base: misc minor ACL changes Qi Zhang
2020-09-07 11:28 ` [dpdk-dev] [PATCH 31/40] net/ice/base: adjust rate limit profile ids runtime database Qi Zhang
2020-09-07 11:28 ` [dpdk-dev] [PATCH 32/40] net/ice/base: enable QinQ filter for switch advanced rule Qi Zhang
2020-09-07 11:28 ` [dpdk-dev] [PATCH 33/40] net/ice/base: create flash info structure and separate NVM version Qi Zhang
2020-09-07 11:28 ` [dpdk-dev] [PATCH 34/40] net/ice/base: remove unused parameter Qi Zhang
2020-09-07 11:28 ` [dpdk-dev] [PATCH 35/40] net/ice/base: minor code clean Qi Zhang
2020-09-07 11:28 ` [dpdk-dev] [PATCH 36/40] net/ice/base: cache NVM module bank information Qi Zhang
2020-09-07 11:28 ` [dpdk-dev] [PATCH 37/40] net/ice/base: rename function Qi Zhang
2020-09-07 11:28 ` [dpdk-dev] [PATCH 38/40] net/ice/base: remove unnecessary conditional Qi Zhang
2020-09-07 11:28 ` [dpdk-dev] [PATCH 39/40] net/ice/base: rename ACL priority values Qi Zhang
2020-09-07 11:28 ` [dpdk-dev] [PATCH 40/40] net/ice/base: preserve default aggr vsi information Qi Zhang
2020-09-09 7:16 ` [dpdk-dev] [PATCH 00/40] ice base code update Yang, Qiming
2020-09-10 3:26 ` Zhang, Qi Z
2020-09-11 11:07 ` Ferruh Yigit [this message]
2020-09-11 11:52 ` Zhang, Qi Z
2020-09-11 12:23 ` Ferruh Yigit
2020-09-11 13:19 ` [dpdk-dev] [PATCH v2 " Qi Zhang
2020-09-11 13:19 ` [dpdk-dev] [PATCH v2 01/40] net/ice/base: handle error gracefully in HW table calloc Qi Zhang
2020-09-11 13:19 ` [dpdk-dev] [PATCH v2 02/40] net/ice/base: split caps discover into two functions Qi Zhang
2020-09-11 13:19 ` [dpdk-dev] [PATCH v2 03/40] net/ice/base: avoid unnecessary single-member variable-length structs Qi Zhang
2020-09-11 13:19 ` [dpdk-dev] [PATCH v2 04/40] net/ice/base: fix issues around move nodes Qi Zhang
2020-09-11 13:19 ` [dpdk-dev] [PATCH v2 05/40] net/ice/base: cleanup stack hog Qi Zhang
2020-09-11 13:19 ` [dpdk-dev] [PATCH v2 06/40] net/ice/base: clean the code wrapping Qi Zhang
2020-09-11 13:19 ` [dpdk-dev] [PATCH v2 07/40] net/ice/base: cleanup misleading comment Qi Zhang
2020-09-11 13:19 ` [dpdk-dev] [PATCH v2 08/40] net/ice/base: silence static analysis warning Qi Zhang
2020-09-11 13:19 ` [dpdk-dev] [PATCH v2 09/40] net/ice/base: replace single-element array used for C struct hack Qi Zhang
2020-09-11 13:19 ` [dpdk-dev] [PATCH v2 10/40] net/ice/base: introduce and use bitmap set API Qi Zhang
2020-09-11 13:19 ` [dpdk-dev] [PATCH v2 11/40] net/ice/base: introduce and use bitmap hamming weight API Qi Zhang
2020-09-11 13:19 ` [dpdk-dev] [PATCH v2 12/40] net/ice/base: add function header Qi Zhang
2020-09-11 13:19 ` [dpdk-dev] [PATCH v2 13/40] net/ice/base: introduce and use for each bit iterator Qi Zhang
2020-09-11 13:19 ` [dpdk-dev] [PATCH v2 14/40] net/ice/base: correct abbreviations Qi Zhang
2020-09-11 13:19 ` [dpdk-dev] [PATCH v2 15/40] net/ice/base: add AQ cmd 0X0A0A LLDP fltr control Qi Zhang
2020-09-11 13:19 ` [dpdk-dev] [PATCH v2 16/40] net/ice/base: add support for GTP-U type switch rule Qi Zhang
2020-09-11 13:19 ` [dpdk-dev] [PATCH v2 17/40] net/ice/base: join format strings to same line Qi Zhang
2020-09-11 13:19 ` [dpdk-dev] [PATCH v2 18/40] net/ice/base: introduce Tx rate limiting on port level Qi Zhang
2020-09-11 13:19 ` [dpdk-dev] [PATCH v2 19/40] net/ice/base: reduce profile to recip info get from firmware Qi Zhang
2020-09-11 13:19 ` [dpdk-dev] [PATCH v2 20/40] net/ice/base: refactor DCB related variables Qi Zhang
2020-09-11 13:19 ` [dpdk-dev] [PATCH v2 21/40] net/ice/base: support outer IP filter for GTPC Qi Zhang
2020-09-11 13:19 ` [dpdk-dev] [PATCH v2 22/40] net/ice/base: support outer IP filter for GTPU without inner IP Qi Zhang
2020-09-11 13:19 ` [dpdk-dev] [PATCH v2 23/40] net/ice/base: move a function Qi Zhang
2020-09-11 13:19 ` [dpdk-dev] [PATCH v2 24/40] net/ice/base: clear advanced rules in reset preparation Qi Zhang
2020-09-11 13:19 ` [dpdk-dev] [PATCH v2 25/40] net/ice/base: move a function Qi Zhang
2020-09-11 13:19 ` [dpdk-dev] [PATCH v2 26/40] net/ice/base: add check for failed acts allocation Qi Zhang
2020-09-11 13:19 ` [dpdk-dev] [PATCH v2 27/40] net/ice/base: remove repeated words Qi Zhang
2020-09-11 13:19 ` [dpdk-dev] [PATCH v2 28/40] net/ice/base: remove function ACL count query Qi Zhang
2020-09-11 13:19 ` [dpdk-dev] [PATCH v2 29/40] net/ice/base: preserve NVM capabilities in safe mode Qi Zhang
2020-09-11 13:19 ` [dpdk-dev] [PATCH v2 30/40] net/ice/base: misc minor ACL changes Qi Zhang
2020-09-11 13:19 ` [dpdk-dev] [PATCH v2 31/40] net/ice/base: adjust rate limit profile ids runtime database Qi Zhang
2020-09-11 13:19 ` [dpdk-dev] [PATCH v2 32/40] net/ice/base: enable QinQ filter for switch advanced rule Qi Zhang
2020-09-11 13:19 ` [dpdk-dev] [PATCH v2 33/40] net/ice/base: create flash info structure and separate NVM version Qi Zhang
2020-09-11 13:19 ` [dpdk-dev] [PATCH v2 34/40] net/ice/base: remove unused parameter Qi Zhang
2020-09-11 13:19 ` [dpdk-dev] [PATCH v2 35/40] net/ice/base: minor code clean Qi Zhang
2020-09-11 13:19 ` [dpdk-dev] [PATCH v2 36/40] net/ice/base: cache NVM module bank information Qi Zhang
2020-09-11 13:19 ` [dpdk-dev] [PATCH v2 37/40] net/ice/base: rename function Qi Zhang
2020-09-11 13:19 ` [dpdk-dev] [PATCH v2 38/40] net/ice/base: remove unnecessary conditional Qi Zhang
2020-09-11 13:19 ` [dpdk-dev] [PATCH v2 39/40] net/ice/base: rename ACL priority values Qi Zhang
2020-09-11 13:19 ` [dpdk-dev] [PATCH v2 40/40] net/ice/base: preserve default aggr vsi information Qi Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=757aaeb7-caa4-2ef4-998b-6f3b4039ec36@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).