From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <anatoly.burakov@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
by dpdk.org (Postfix) with ESMTP id 09BE9F94
for <dev@dpdk.org>; Mon, 18 Sep 2017 17:19:59 +0200 (CEST)
Received: from fmsmga005.fm.intel.com ([10.253.24.32])
by fmsmga105.fm.intel.com with ESMTP; 18 Sep 2017 08:19:59 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.42,413,1500966000"; d="scan'208";a="152609084"
Received: from aburakov-mobl2.ger.corp.intel.com (HELO [10.237.220.104])
([10.237.220.104])
by fmsmga005.fm.intel.com with ESMTP; 18 Sep 2017 08:19:58 -0700
To: Santosh Shukla <santosh.shukla@caviumnetworks.com>, dev@dpdk.org
References: <20170814151537.29454-1-santosh.shukla@caviumnetworks.com>
<20170905103119.20511-1-santosh.shukla@caviumnetworks.com>
<20170905103119.20511-2-santosh.shukla@caviumnetworks.com>
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Message-ID: <75ac3886-f01c-eda1-17ff-bf6b096ffc35@intel.com>
Date: Mon, 18 Sep 2017 16:19:52 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101
Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <20170905103119.20511-2-santosh.shukla@caviumnetworks.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2 1/5] eal: rename phys_addr_t to iova_addr_t
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Sep 2017 15:20:00 -0000
On 05-Sep-17 11:31 AM, Santosh Shukla wrote:
> Renamed data type from phys_addr_t to iova_addr_t.
>
> Signed-off-by: Santosh Shukla <santosh.shukla at caviumnetworks.com>
> ---
> v1 --> v2:
> - clang build fix for v1 for linuxapp.
>
> v1 note:
> - As changes percolate to all possible dpdk subsystem..
> so its difficult to tag subject with one common title,
> but since, core of changeset is at eal layer so keeping 'eal:'
> as title.
>
> app/test-crypto-perf/cperf_test_vectors.h | 4 +--
> doc/guides/contributing/documentation.rst | 4 +--
> doc/guides/prog_guide/cryptodev_lib.rst | 6 ++--
> drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 14 ++++----
> drivers/crypto/qat/qat_adf/qat_algs.h | 6 ++--
> drivers/crypto/qat/qat_crypto.h | 2 +-
> drivers/mempool/dpaa2/dpaa2_hw_mempool.h | 2 +-
> drivers/net/ark/ark_ddm.c | 2 +-
> drivers/net/ark/ark_ddm.h | 4 +--
> drivers/net/ark/ark_ethdev_rx.c | 12 +++----
> drivers/net/ark/ark_ethdev_tx.c | 2 +-
> drivers/net/ark/ark_mpu.c | 2 +-
> drivers/net/ark/ark_mpu.h | 4 +--
> drivers/net/ark/ark_udm.c | 2 +-
> drivers/net/ark/ark_udm.h | 4 +--
> drivers/net/avp/avp_ethdev.c | 2 +-
> drivers/net/avp/rte_avp_common.h | 20 +++++------
> drivers/net/bnx2x/bnx2x.c | 40 +++++++++++-----------
> drivers/net/bnx2x/bnx2x.h | 22 ++++++------
> drivers/net/bnx2x/bnx2x_rxtx.c | 4 +--
> drivers/net/bnx2x/bnx2x_stats.c | 2 +-
> drivers/net/bnx2x/bnx2x_vfpf.c | 2 +-
> drivers/net/bnx2x/ecore_sp.h | 2 +-
> drivers/net/bnxt/bnxt.h | 10 +++---
> drivers/net/bnxt/bnxt_cpr.h | 4 +--
> drivers/net/bnxt/bnxt_ethdev.c | 2 +-
> drivers/net/bnxt/bnxt_ring.c | 2 +-
> drivers/net/bnxt/bnxt_ring.h | 2 +-
> drivers/net/bnxt/bnxt_rxr.h | 4 +--
> drivers/net/bnxt/bnxt_txr.h | 2 +-
> drivers/net/bnxt/bnxt_vnic.c | 2 +-
> drivers/net/bnxt/bnxt_vnic.h | 6 ++--
> drivers/net/liquidio/lio_rxtx.c | 2 +-
> drivers/net/liquidio/lio_rxtx.h | 4 +--
> drivers/net/qede/base/bcm_osal.h | 2 +-
> drivers/net/sfc/efsys.h | 2 +-
> drivers/net/sfc/sfc_ef10_rx.c | 2 +-
> drivers/net/sfc/sfc_ef10_tx.c | 4 +--
> drivers/net/thunderx/base/nicvf_hw.c | 2 +-
> drivers/net/thunderx/base/nicvf_hw.h | 2 +-
> drivers/net/thunderx/base/nicvf_hw_defs.h | 6 ++--
> drivers/net/thunderx/nicvf_ethdev.c | 4 +--
> drivers/net/thunderx/nicvf_ethdev.h | 4 +--
> drivers/net/thunderx/nicvf_struct.h | 6 ++--
> drivers/net/virtio/virtio_rxtx.h | 4 +--
> drivers/net/virtio/virtqueue.h | 2 +-
> drivers/net/xenvirt/rte_eth_xenvirt.c | 2 +-
> drivers/net/xenvirt/rte_mempool_gntalloc.c | 6 ++--
> drivers/net/xenvirt/rte_xen_lib.c | 6 ++--
> drivers/net/xenvirt/rte_xen_lib.h | 8 ++---
> examples/l2fwd-crypto/main.c | 2 +-
> lib/librte_cryptodev/rte_crypto.h | 2 +-
> lib/librte_cryptodev/rte_crypto_sym.h | 6 ++--
> lib/librte_cryptodev/rte_cryptodev.h | 2 +-
> lib/librte_eal/bsdapp/eal/eal_memory.c | 4 +--
> lib/librte_eal/common/include/rte_malloc.h | 2 +-
> lib/librte_eal/common/include/rte_memory.h | 18 +++++-----
> lib/librte_eal/common/include/rte_memzone.h | 2 +-
> lib/librte_eal/common/rte_malloc.c | 2 +-
> lib/librte_eal/linuxapp/eal/eal_memory.c | 8 ++---
> lib/librte_eal/linuxapp/eal/eal_xen_memory.c | 4 +--
> .../linuxapp/eal/include/exec-env/rte_kni_common.h | 20 ++++++-----
> lib/librte_mbuf/rte_mbuf.h | 8 ++---
> lib/librte_mempool/rte_mempool.c | 18 +++++-----
> lib/librte_mempool/rte_mempool.h | 14 ++++----
> lib/librte_vhost/vhost.h | 2 +-
> test/test/test_cryptodev.h | 2 +-
> test/test/test_memzone.c | 8 ++---
> 68 files changed, 197 insertions(+), 193 deletions(-)
>
> diff --git a/app/test-crypto-perf/cperf_test_vectors.h b/app/test-crypto-perf/cperf_test_vectors.h
> index 85955703c..a203272cf 100644
> --- a/app/test-crypto-perf/cperf_test_vectors.h
> +++ b/app/test-crypto-perf/cperf_test_vectors.h
> @@ -78,13 +78,13 @@ struct cperf_test_vector {
>
> struct {
> uint8_t *data;
> - phys_addr_t phys_addr;
> + iova_addr_t phys_addr;
> uint16_t length;
> } aad;
>
> struct {
> uint8_t *data;
> - phys_addr_t phys_addr;
> + iova_addr_t phys_addr;
> uint16_t length;
> } digest;
>
...
> diff --git a/lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h b/lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h
> index 2ac879fdd..efd9ac9a5 100644
> --- a/lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h
> +++ b/lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h
> @@ -73,6 +73,10 @@
>
> #define RTE_CACHE_LINE_MIN_SIZE 64
>
> +#ifdef __KERNEL__
> +typedef uint64_t iova_addr_t;
> +#endif
As discussed earlier, please use a more informative macro (e.g. __GNUC__
or its clang equivalent).
Assuming this is fixed,
Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>