From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 7BB74A05D3 for ; Thu, 23 May 2019 19:40:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 66C601B946; Thu, 23 May 2019 19:40:38 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 47EAC5689 for ; Thu, 23 May 2019 19:40:37 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4ECD47EBBD; Thu, 23 May 2019 17:40:16 +0000 (UTC) Received: from [10.36.112.60] (ovpn-112-60.ams2.redhat.com [10.36.112.60]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 61F0F60BF3; Thu, 23 May 2019 17:40:09 +0000 (UTC) To: =?UTF-8?Q?Mattias_R=c3=b6nnblom?= , dev@dpdk.org, tiwei.bie@intel.com, jfreimann@redhat.com, zhihong.wang@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com References: <20190517122220.31283-1-maxime.coquelin@redhat.com> <20190517122220.31283-4-maxime.coquelin@redhat.com> <2cfed6b0-8a7d-ec05-4b67-f40bd9409a8b@ericsson.com> <25057af9-8d1c-5e97-b648-6d344724291e@redhat.com> <4a91dd95-16bf-7b73-6cce-2ea8490e64d9@ericsson.com> From: Maxime Coquelin Message-ID: <75af286d-629d-bdb4-de35-6095f5a0c5d3@redhat.com> Date: Thu, 23 May 2019 19:40:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <4a91dd95-16bf-7b73-6cce-2ea8490e64d9@ericsson.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Thu, 23 May 2019 17:40:26 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 3/5] vhost: do not inline unlikely fragmented buffers code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/23/19 5:17 PM, Mattias Rönnblom wrote: > On 2019-05-23 16:30, Maxime Coquelin wrote: >> Hi Mattias, >> >> On 5/21/19 9:43 PM, Mattias Rönnblom wrote: >>> On 2019-05-17 14:22, Maxime Coquelin wrote: >>>> Handling of fragmented virtio-net header and indirect descriptors >>>> tables was implemented to fix CVE-2018-1059. It should not never >>>> happen with healthy guests and so are already considered as >>>> unlikely code path. >>>> >>>> This patch moves these bits into non-inline dedicated functions >>>> to reduce the I-cache pressure. >>>> >>>> Signed-off-by: Maxime Coquelin >>>> --- >>>>   lib/librte_vhost/vhost.c      |  33 +++++++++++ >>>>   lib/librte_vhost/vhost.h      |  35 +----------- >>>>   lib/librte_vhost/virtio_net.c | 102 >>>> +++++++++++++++++++--------------- >>>>   3 files changed, 91 insertions(+), 79 deletions(-) >>>> >>>> diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c >>>> index 4a54ad6bd1..8a4379bc13 100644 >>>> --- a/lib/librte_vhost/vhost.c >>>> +++ b/lib/librte_vhost/vhost.c >>>> @@ -201,6 +201,39 @@ __vhost_log_cache_write(struct virtio_net *dev, >>>> struct vhost_virtqueue *vq, >>>>   } >>>> +void * >>>> +alloc_copy_ind_table(struct virtio_net *dev, struct vhost_virtqueue >>>> *vq, >>> >>> This function should have a prefix. >> >> This function is just moved from vhost.h to vhost.c, so not the purpose >> of the patch. >> > > It was declared "static inline" in the header file, and thus only > affected those who included the file, as opposed to polluting the whole > DPDK library name space. Right, I'll fix the name in next revision. Thanks, Maxime