DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] eal: fix duplicate function declaration
@ 2018-11-14 11:14 Kevin Laatz
  2018-11-14 11:23 ` Burakov, Anatoly
  0 siblings, 1 reply; 2+ messages in thread
From: Kevin Laatz @ 2018-11-14 11:14 UTC (permalink / raw)
  To: dev; +Cc: thomas, anatoly.burakov, Kevin Laatz

The rte_eal_get_runtime_dir() function is currently being declared in two
header files.

This API was made public in commit 6911c9fd8fbe, adding it to rte_eal.h. To
make it public, the 'rte' prefix was added to the function so it needed to
be modified in the original location of the declaration, eal_filesystem.h.
By only modifying, and not removing the decalration, it is now a duplicate.

This patch removes the declaration from eal_filesystem.h.

Fixes: 6911c9fd8fbe ("eal: export function to get runtime directory")

Reported-by: Anatoly Burakov <anatoly.burakov@intel.com>
Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
---
 lib/librte_eal/common/eal_filesystem.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/lib/librte_eal/common/eal_filesystem.h b/lib/librte_eal/common/eal_filesystem.h
index b3e8ae5ea..6e0331fdb 100644
--- a/lib/librte_eal/common/eal_filesystem.h
+++ b/lib/librte_eal/common/eal_filesystem.h
@@ -25,10 +25,6 @@
 int
 eal_create_runtime_dir(void);
 
-/* returns runtime dir */
-const char *
-rte_eal_get_runtime_dir(void);
-
 #define RUNTIME_CONFIG_FNAME "config"
 static inline const char *
 eal_runtime_config_path(void)
-- 
2.17.2

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] eal: fix duplicate function declaration
  2018-11-14 11:14 [dpdk-dev] [PATCH] eal: fix duplicate function declaration Kevin Laatz
@ 2018-11-14 11:23 ` Burakov, Anatoly
  0 siblings, 0 replies; 2+ messages in thread
From: Burakov, Anatoly @ 2018-11-14 11:23 UTC (permalink / raw)
  To: Kevin Laatz, dev; +Cc: thomas

On 14-Nov-18 11:14 AM, Kevin Laatz wrote:
> The rte_eal_get_runtime_dir() function is currently being declared in two
> header files.
> 
> This API was made public in commit 6911c9fd8fbe, adding it to rte_eal.h. To
> make it public, the 'rte' prefix was added to the function so it needed to
> be modified in the original location of the declaration, eal_filesystem.h.
> By only modifying, and not removing the decalration, it is now a duplicate.
> 
> This patch removes the declaration from eal_filesystem.h.
> 
> Fixes: 6911c9fd8fbe ("eal: export function to get runtime directory")
> 
> Reported-by: Anatoly Burakov <anatoly.burakov@intel.com>
> Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
> ---

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

-- 
Thanks,
Anatoly

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-11-14 11:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-14 11:14 [dpdk-dev] [PATCH] eal: fix duplicate function declaration Kevin Laatz
2018-11-14 11:23 ` Burakov, Anatoly

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git