From: Qingqing Li <liqingqing3@huawei.com>
To: <dev@dpdk.org>, Hushiyuan <hushiyuan@huawei.com>
Subject: [dpdk-dev] [v4]net/hinic: fix coredump when the scondary process using the hinic port.
Date: Sat, 31 Oct 2020 18:23:42 +0800 [thread overview]
Message-ID: <75f84103-ca98-e6b1-1013-c2720189c848@huawei.com> (raw)
In-Reply-To: <836f40cb-57a9-7b02-adcc-dd302a93a722@huawei.com>
fix coredump when secondary process using the hinic port. the
reason is that during the stage of secondary process port
initialization, it
lack the initialization of "eth_dev->dev_ops".
---
v4: adapt to the latest version.
---
v3: update the signed-off information.
---
v2: solve the coding style issue.
---
Signed-off-by: Qingqing Li <liqingqing3@huawei.com>
---
drivers/net/hinic/hinic_pmd_ethdev.c | 20 ++++++++++++--------
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/drivers/net/hinic/hinic_pmd_ethdev.c
b/drivers/net/hinic/hinic_pmd_ethdev.c
index b694fd83c..526dafdad 100644
--- a/drivers/net/hinic/hinic_pmd_ethdev.c
+++ b/drivers/net/hinic/hinic_pmd_ethdev.c
@@ -3100,14 +3100,6 @@ static int hinic_func_init(struct rte_eth_dev
*eth_dev)
pci_dev = RTE_ETH_DEV_TO_PCI(eth_dev);
- /* EAL is SECONDARY and eth_dev is already created */
- if (rte_eal_process_type() != RTE_PROC_PRIMARY) {
- PMD_DRV_LOG(INFO, "Initialize %s in secondary process",
- eth_dev->data->name);
-
- return 0;
- }
-
eth_dev->data->dev_flags |= RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS;
nic_dev = HINIC_ETH_DEV_TO_PRIVATE_NIC_DEV(eth_dev);
@@ -3241,6 +3233,18 @@ static int hinic_dev_init(struct rte_eth_dev
*eth_dev)
eth_dev->rx_pkt_burst = hinic_recv_pkts;
eth_dev->tx_pkt_burst = hinic_xmit_pkts;
+ /* EAL is SECONDARY and eth_dev is already created */
+ if (rte_eal_process_type() != RTE_PROC_PRIMARY) {
+ PMD_DRV_LOG(INFO, "Initialize %s in secondary process",
eth_dev->data->name);
+
+ struct hinic_nic_dev *nic_dev =
HINIC_ETH_DEV_TO_PRIVATE_NIC_DEV(eth_dev);
+ if (HINIC_IS_VF(nic_dev->hwdev))
+ eth_dev->dev_ops = &hinic_pmd_vf_ops;
+ else
+ eth_dev->dev_ops = &hinic_pmd_ops;
+ return 0;
+ }
+
return hinic_func_init(eth_dev);
}
--
2.19.1
prev parent reply other threads:[~2020-10-31 10:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-31 9:38 [dpdk-dev] [v3]net/hinic: " Qingqing Li
2020-10-31 10:01 ` [dpdk-dev] [v4]net/hinic: " Qingqing Li
2020-10-31 10:10 ` Qingqing Li
2020-11-12 2:11 ` Wangxiaoyun (Cloud)
2020-11-12 9:26 ` Ferruh Yigit
2020-11-12 12:30 ` Wangxiaoyun (Cloud)
2020-11-12 12:39 ` Ferruh Yigit
2021-03-18 6:12 ` Wangxiaoyun (Cloud)
2021-03-22 9:04 ` Ferruh Yigit
2020-10-31 10:23 ` Qingqing Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75f84103-ca98-e6b1-1013-c2720189c848@huawei.com \
--to=liqingqing3@huawei.com \
--cc=dev@dpdk.org \
--cc=hushiyuan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).