From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 7CD65FBCF for ; Tue, 20 Dec 2016 18:25:15 +0100 (CET) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP; 20 Dec 2016 09:25:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,379,1477983600"; d="scan'208";a="44694125" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.29]) ([10.237.220.29]) by orsmga005.jf.intel.com with ESMTP; 20 Dec 2016 09:25:13 -0800 To: Wei Zhao , dev@dpdk.org References: <1480675394-59179-1-git-send-email-wei.zhao1@intel.com> <1480675394-59179-17-git-send-email-wei.zhao1@intel.com> Cc: wenzhuo.lu@intel.com From: Ferruh Yigit Message-ID: <75f8b5f7-d640-6fca-8a94-613f92c527c1@intel.com> Date: Tue, 20 Dec 2016 17:25:13 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1480675394-59179-17-git-send-email-wei.zhao1@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 16/18] net/ixgbe: create consistent filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Dec 2016 17:25:15 -0000 On 12/2/2016 10:43 AM, Wei Zhao wrote: > From: wei zhao1 > > This patch adds a function to create the flow directory filter. > > Signed-off-by: wei zhao1 > Signed-off-by: Wenzhuo Lu <...> > +/** > + * Create or destroy a flow rule. > + * Theorically one rule can match more than one filters. > + * We will let it use the filter which it hitt first. > + * So, the sequence matters. > + */ > +struct ixgbe_flow * > +ixgbe_flow_create(struct rte_eth_dev *dev, > + const struct rte_flow_attr *attr, > + const struct rte_flow_item pattern[], > + const struct rte_flow_action actions[], > + struct rte_flow_error *error) > +{ > + int ret; > + struct rte_eth_ntuple_filter ntuple_filter; <...> > + error->type = ret; This also returns same ICC error, there are a few more same usage: .../drivers/net/ixgbe/ixgbe_ethdev.c(9764): error #188: enumerated type mixed with another type error->type = ret; ^