From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 38A8DA04BC;
	Fri,  9 Oct 2020 13:36:50 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 0E8DE1D523;
	Fri,  9 Oct 2020 13:36:49 +0200 (CEST)
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 9CC881D522;
 Fri,  9 Oct 2020 13:36:46 +0200 (CEST)
IronPort-SDR: 7YpMzBiETdA/9X9ts6wX7lD5IDU59uEEx+znytgJsBdLfP1RfC1LMC/N1Bt3LaUXEivNQl1Gnp
 NcmKKCCIfTOw==
X-IronPort-AV: E=McAfee;i="6000,8403,9768"; a="227121359"
X-IronPort-AV: E=Sophos;i="5.77,355,1596524400"; d="scan'208";a="227121359"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 09 Oct 2020 04:36:44 -0700
IronPort-SDR: lWGnpq9U7oakZjZSroGwyHWwofjcUL2R+Lul5eapb+XIJnHchQwWoeZRHQ3dZIav7A+Tem8m9j
 o6TqMFMV9KLQ==
X-IronPort-AV: E=Sophos;i="5.77,355,1596524400"; d="scan'208";a="462157988"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.18.7])
 ([10.252.18.7])
 by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 09 Oct 2020 04:36:42 -0700
To: Long Li <longli@microsoft.com>, wangyunjian <wangyunjian@huawei.com>,
 "dev@dpdk.org" <dev@dpdk.org>
Cc: Stephen Hemminger <sthemmin@microsoft.com>,
 KY Srinivasan <kys@microsoft.com>, Haiyang Zhang <haiyangz@microsoft.com>,
 "jerry.lilijun@huawei.com" <jerry.lilijun@huawei.com>,
 "xudingke@huawei.com" <xudingke@huawei.com>,
 "stable@dpdk.org" <stable@dpdk.org>
References: <bbe208ba281538f00662908f8e48cfb12c9fd850.1601369660.git.wangyunjian@huawei.com>
 <1602036385-10760-1-git-send-email-wangyunjian@huawei.com>
 <BYAPR21MB11596B362F3172D09C34BBD9CE080@BYAPR21MB1159.namprd21.prod.outlook.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <76016872-6d1d-ea2f-b281-dec89af764d4@intel.com>
Date: Fri, 9 Oct 2020 12:36:38 +0100
MIME-Version: 1.0
In-Reply-To: <BYAPR21MB11596B362F3172D09C34BBD9CE080@BYAPR21MB1159.namprd21.prod.outlook.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/netvsc: fix txq leak in
 error path
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/9/2020 4:53 AM, Long Li wrote:
>> Subject: [dpdk-dev] [PATCH v2] net/netvsc: fix txq leak in error path
>>
>> From: Yunjian Wang <wangyunjian@huawei.com>
>>
>> In hn_dev_tx_queue_setup() allocated memory for txq, we don't free it
>> when error happens and it will lead to memory leak.
>>
>> We can check for tx_free_thresh at the beginning of the function to fix it,
>> before calling txq = rte_zmalloc_socket().
>>
>> Fixes: cc0251813277 ("net/netvsc: split send buffers from Tx descriptors")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> 
> Acked-by: Long Li <longli@microsoft.com>
 >

Applied to dpdk-next-net/main, thanks.