From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F33EA00C3; Sun, 3 Jul 2022 23:40:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3D0BD40A80; Sun, 3 Jul 2022 23:40:12 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id B2E8D4021F for ; Sun, 3 Jul 2022 23:40:11 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 0D4B25C00B7; Sun, 3 Jul 2022 17:40:10 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sun, 03 Jul 2022 17:40:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1656884410; x= 1656970810; bh=Dn6FX6EPyR+tDfJS6ICJ3iaH/cjGd07JOIM8kITaCV4=; b=Z 7mgZzrwQJcUqIAA+8nOJ/Mn2P3Y9Y5cVsJNWvaMeKnzYbneDwJrCaOFiYKKE6XGl rXsgBsQgVN6OMF+PWvyoFAdyL4ESqwNTI1U0gTNWKhZ6epszdOKkFGgbs2Ad6LyA SMq0B2c3+5hI8Ie0/SoSNHaSXJdzVquuCeEfUXco38nh0IH1DNz6L/KZgFSUtEDx 4jdy7I/+WM6jnXlRZu23IuaN0MqKm0W7OPMzc8Q7+fyVP24deeBBy6dXvlvK+bRp djyOiqCejBvU4fDBqSViapcUG/X/See/aHPvblys5lNa4CW3yg9zq25Mnp76PWcG MCZAPiX3LzL4dhfe5mfOA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1656884410; x= 1656970810; bh=Dn6FX6EPyR+tDfJS6ICJ3iaH/cjGd07JOIM8kITaCV4=; b=J VyIHzicVXThrS2Jhwm7OBsJlsDo4sYE7LfXCKBXBP6mDjUcUqKudGgY5haZqZNGn pu5i2NT1f6brhpSaI8t7jtP5tHEiKBUEN75bWl67Bp6F0rfnkAnH8UKHU+Yvm5Rd iqwAGpWHsYDJBuFTG6QDq/eStG5iJsqbK8NKeuJ4cC5ecCE67CTZwP+0Pgv6SJFZ 7+G2N7vUmQS2zuyOlfs95d2o/BRpKWTv9Brjgd6Eo/3aeay6ddDPQQWi9cvlp+Qs UJ77xebTEXMzorrFzn6jSSZZwLZHwdox/KAM8ioFRNkpHnq3TwM5CgqRf/oBWuGs E8EcsaQZNQGTSu4uHuNAg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudehkecutefuodetggdotefrodftvfcurf hrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgrshcu ofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuggftrf grthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieekgfek udehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 3 Jul 2022 17:40:08 -0400 (EDT) From: Thomas Monjalon To: Rahul Bhansali Cc: dev@dpdk.org, David Christensen , Ruifeng Wang , Bruce Richardson , Konstantin Ananyev , jerinj@marvell.com, gakhil@marvell.com, david.marchand@redhat.com Subject: Re: [PATCH v3 1/2] examples/l3fwd: common packet group functionality Date: Sun, 03 Jul 2022 23:40:06 +0200 Message-ID: <7631125.c0te8JeNC1@thomas> In-Reply-To: <20220623093816.254830-1-rbhansali@marvell.com> References: <20220524095717.3875284-1-rbhansali@marvell.com> <20220623093816.254830-1-rbhansali@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 23/06/2022 11:38, Rahul Bhansali: > This will make the packet grouping function common, so > that other examples can utilize as per need. > > For each architecture sse/neon/altivec, port group > headers will be created under examples/common/. > > Signed-off-by: Rahul Bhansali > --- > Changes in v3: Created common port-group headers for > architectures sse/neon/altivec as suggested by Konstantin. > > Changes in v2: New patch to address review comment. > > examples/common/altivec/port_group.h | 48 +++++++++ > examples/common/neon/port_group.h | 50 ++++++++++ > examples/common/pkt_group.h | 139 +++++++++++++++++++++++++++ > examples/common/sse/port_group.h | 47 +++++++++ > examples/l3fwd/Makefile | 5 +- > examples/l3fwd/l3fwd.h | 2 - > examples/l3fwd/l3fwd_altivec.h | 37 +------ > examples/l3fwd/l3fwd_common.h | 129 +------------------------ > examples/l3fwd/l3fwd_neon.h | 39 +------- > examples/l3fwd/l3fwd_sse.h | 36 +------ > examples/meson.build | 2 +- OK you move code from l3fwd to another place. That's probably a step in the right direction. What about taking the extra step of making it an EAL API?