From: Thomas Monjalon <thomas@monjalon.net>
To: Andrew Rybchenko <arybchenko@solarflare.com>,
Ivan Malov <ivan.malov@oktetlabs.ru>
Cc: dev@dpdk.org, santosh <santosh.shukla@caviumnetworks.com>,
stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal: copy optarg when parsing mempool ops name
Date: Mon, 14 May 2018 01:07:48 +0200 [thread overview]
Message-ID: <7636615.bGWiXIQp7Z@xps> (raw)
In-Reply-To: <146d5ea9-793b-9bbc-0d20-9375cf2d3907@caviumnetworks.com>
07/05/2018 07:42, santosh:
>
> On Friday 04 May 2018 04:01 PM, Andrew Rybchenko wrote:
> > From: Ivan Malov <ivan.malov@oktetlabs.ru>
> >
> > The code aimed to pick and remember the value of
> > mempool ops name from EAL command line arguments does not
> > copy the string and remembers the pointer provided
> > by getopt_long() directly. The latter could be clobbered
> > later and result in reading wrong mbuf pool ops name
> > by rte_mempool library.
> >
> > Typically, this flaw could be avoided by using strdup()
> > to remember the string value of the option.
> >
> > Fixes: a103a97e7191 ("eal: allow user to override default mempool driver")
> > Cc: Santosh Shukla <santosh.shukla@caviumnetworks.com>
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
> > Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> > ---
>
> Acked-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
Applied, thanks
prev parent reply other threads:[~2018-05-13 23:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 10:31 Andrew Rybchenko
2018-05-07 5:42 ` santosh
2018-05-13 23:07 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7636615.bGWiXIQp7Z@xps \
--to=thomas@monjalon.net \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ivan.malov@oktetlabs.ru \
--cc=santosh.shukla@caviumnetworks.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).