From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1CEAFA09E4; Fri, 29 Jan 2021 02:49:31 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D744A4067B; Fri, 29 Jan 2021 02:49:30 +0100 (CET) Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by mails.dpdk.org (Postfix) with ESMTP id 8CF8D40395 for ; Fri, 29 Jan 2021 02:49:29 +0100 (CET) Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4DRgGP4qtlz160Np; Fri, 29 Jan 2021 09:48:13 +0800 (CST) Received: from [10.67.103.119] (10.67.103.119) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.498.0; Fri, 29 Jan 2021 09:49:26 +0800 To: Ferruh Yigit , CC: , References: <1611310732-51975-1-git-send-email-oulijun@huawei.com> <1611310732-51975-15-git-send-email-oulijun@huawei.com> <7d7acb57-d699-eba1-5e06-ac4c1c1deb1a@intel.com> From: oulijun Message-ID: <7638a4d0-fb62-131f-1e8c-f5945706b924@huawei.com> Date: Fri, 29 Jan 2021 09:49:26 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <7d7acb57-d699-eba1-5e06-ac4c1c1deb1a@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.119] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH 14/14] net/hns3: support LSC event report X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 在 2021/1/29 7:41, Ferruh Yigit 写道: > On 1/22/2021 10:18 AM, Lijun Ou wrote: >> From: Chengwen Feng >> >> This patch support LSC(Link Status Change) event report. > > There is a user config for lsc, 'dev->data->dev_conf.intr_conf.lsc', > which seems not taken into account. > Frist of all, thank you for your review. Currently, the old firmware doest not support interrupt reporting. Therefore, the PF does not suport interrupt reporting through the mailbox. Therefore, the PF obtains interrupts in polling mode and then reports interrupts. > Also 'RTE_PCI_DRV_INTR_LSC' should be set in 'rte_pci_driver.drv_flags' > to report this feature to higher levels. > In the future, the new firmware + PF will support interrupt reporting. In that case, the LSC capability of dev_flag will be set. In the future, we will enable the VF to support LSC. That is, we are developing the PF to report LSC interrupts through the mailbox. > And when the feature is fully implemented, can you please add "Link > status event" feature to 'hns3.ini'? > By then, we'll add it in hns3.ini. >> >> Signed-off-by: Chengwen Feng >> Signed-off-by: Lijun Ou > > <...> > . >