From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <radu.nicolau@intel.com> Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id F26DE1B283 for <dev@dpdk.org>; Fri, 20 Oct 2017 18:34:43 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP; 20 Oct 2017 09:34:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,405,1503385200"; d="scan'208";a="165060674" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by fmsmga005.fm.intel.com with ESMTP; 20 Oct 2017 09:34:41 -0700 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.248]) by IRSMSX109.ger.corp.intel.com ([169.254.13.28]) with mapi id 14.03.0319.002; Fri, 20 Oct 2017 17:34:40 +0100 From: "Nicolau, Radu" <radu.nicolau@intel.com> To: "aviadye@dev.mellanox.co.il" <aviadye@dev.mellanox.co.il>, "dev@dpdk.org" <dev@dpdk.org>, "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>, "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>, "aviadye@mellanox.com" <aviadye@mellanox.com> CC: "borisp@mellanox.com" <borisp@mellanox.com>, "akhil.goyal@nxp.com" <akhil.goyal@nxp.com>, "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>, "Doherty, Declan" <declan.doherty@intel.com>, "liranl@mellanox.com" <liranl@mellanox.com>, "nelio.laranjeiro@6wind.com" <nelio.laranjeiro@6wind.com>, "thomas@monjalon.net" <thomas@monjalon.net> Thread-Topic: [dpdk-dev][PATCH v2 6/6] examples/ipsec-secgw: config ethernet MACs dynamically Thread-Index: AQHTSQuQbz8rqaJ/70q+c+4HBzcMgqLs7nvw Date: Fri, 20 Oct 2017 16:34:39 +0000 Message-ID: <763A2F19A5EFF34F8B7F1657C992EE297B2F0C70@IRSMSX104.ger.corp.intel.com> References: <1507987683-12315-1-git-send-email-aviadye@dev.mellanox.co.il> <1508439184-17893-1-git-send-email-aviadye@dev.mellanox.co.il> <1508439184-17893-6-git-send-email-aviadye@dev.mellanox.co.il> In-Reply-To: <1508439184-17893-6-git-send-email-aviadye@dev.mellanox.co.il> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTBlOGM1OTctYzJhYS00NjliLWE4ZjktN2YzMDZmODRhMDkzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkNnXC9lVThzanliUjRlY2wrNk5Jcnc2VXE1VDd1ck43eEtPVmExZzM0bE5ZPSJ9 dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 6/6] examples/ipsec-secgw: config ethernet MACs dynamically X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 20 Oct 2017 16:34:44 -0000 Hi, I think this should be a separate patch, not bundled with a series of fixes= . The guide has to be updated as well. And probably it's best to make the MAC configuration optional, keep a defau= lt hardcoded table. Regards, Radu > -----Original Message----- > From: aviadye@dev.mellanox.co.il [mailto:aviadye@dev.mellanox.co.il] > Sent: Thursday, October 19, 2017 7:53 PM > To: dev@dpdk.org; Gonzalez Monroy, Sergio > <sergio.gonzalez.monroy@intel.com>; De Lara Guarch, Pablo > <pablo.de.lara.guarch@intel.com>; aviadye@mellanox.com > Cc: borisp@mellanox.com; akhil.goyal@nxp.com; > hemant.agrawal@nxp.com; Nicolau, Radu <radu.nicolau@intel.com>; > Doherty, Declan <declan.doherty@intel.com>; aviadye@dev.mellanox.co.il; > liranl@mellanox.com; nelio.laranjeiro@6wind.com; thomas@monjalon.net > Subject: [dpdk-dev][PATCH v2 6/6] examples/ipsec-secgw: config ethernet > MACs dynamically >=20 > From: Aviad Yehezkel <aviadye@mellanox.com> >=20 > Issue: None > Signed-off-by: Aviad Yehezkel <aviadye@mellanox.com> > -- > v2: <snip>