From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id A11A71B172 for ; Wed, 17 Jan 2018 12:40:28 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jan 2018 03:40:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,372,1511856000"; d="scan'208";a="196374939" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by fmsmga006.fm.intel.com with ESMTP; 17 Jan 2018 03:40:26 -0800 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX106.ger.corp.intel.com (163.33.3.31) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 17 Jan 2018 11:40:26 +0000 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.248]) by irsmsx155.ger.corp.intel.com ([169.254.14.169]) with mapi id 14.03.0319.002; Wed, 17 Jan 2018 11:40:26 +0000 From: "Nicolau, Radu" To: "Ananyev, Konstantin" , "dev@dpdk.org" CC: "Lu, Wenzhuo" , "Zhao, XinfengX" , "De Lara Guarch, Pablo" Thread-Topic: [PATCH] net/ixgbe: check if security capabilities are enabled by HW Thread-Index: AQHTj4XQWJrMn0cRH0yWCTURrQuzKKN37zWAgAABhtA= Date: Wed, 17 Jan 2018 11:40:25 +0000 Message-ID: <763A2F19A5EFF34F8B7F1657C992EE297B30F266@IRSMSX104.ger.corp.intel.com> References: <1516187946-30607-1-git-send-email-radu.nicolau@intel.com> <2601191342CEEE43887BDE71AB9772588627EE87@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB9772588627EE87@irsmsx105.ger.corp.intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjM1YjUwYTAtNGFmNi00YWJiLWE5MmItNWVkOTJmMmU1OTExIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkdsY2UzY0hRXC9EUWRXSUFJcFhrZzd4ZVRXMXRvRjBpWWIzZTczYVVXQ2NRPSJ9 dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: check if security capabilities are enabled by HW X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jan 2018 11:40:29 -0000 > -----Original Message----- > From: Ananyev, Konstantin > Sent: Wednesday, January 17, 2018 11:34 AM > To: Nicolau, Radu ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Zhao, XinfengX > ; De Lara Guarch, Pablo > > Subject: RE: [PATCH] net/ixgbe: check if security capabilities are enable= d by > HW >=20 > Hi Radu, >=20 > > -----Original Message----- > > From: Nicolau, Radu > > Sent: Wednesday, January 17, 2018 11:19 AM > > To: dev@dpdk.org > > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > > ; Zhao, XinfengX > > ; De Lara Guarch, Pablo > > ; Nicolau, Radu > > > > Subject: [PATCH] net/ixgbe: check if security capabilities are enabled > > by HW > > > > Check if the security enable bits are not fused before setting offload > > capabilities for security >=20 > In theory dev_info_get() - could be called at any stage of device > configuration or even when RX/TX is active. > Do you really want to assert SECRXCTRL at that moment? > Probably better to do this only once at init time and then just use some > stored value? > Konstantin >=20 Yes, that's true. I will send a v2