From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 38DE91B319 for ; Thu, 18 Jan 2018 16:18:39 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jan 2018 07:18:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,378,1511856000"; d="scan'208";a="22755012" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by fmsmga004.fm.intel.com with ESMTP; 18 Jan 2018 07:18:37 -0800 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.248]) by IRSMSX108.ger.corp.intel.com ([169.254.11.167]) with mapi id 14.03.0319.002; Thu, 18 Jan 2018 15:18:36 +0000 From: "Nicolau, Radu" To: "De Lara Guarch, Pablo" , "dev@dpdk.org" CC: "Ananyev, Konstantin" , "Yigit, Ferruh" , "Doherty, Declan" , "akhil.goyal@nxp.com" Thread-Topic: [PATCH v2 3/3] examples/ipsec_secgw: create session mempools for ethdevs Thread-Index: AQHTje3MXj5xOf5VtUaO5VeOH0MeZaN5wU0AgAAAs1A= Date: Thu, 18 Jan 2018 15:18:35 +0000 Message-ID: <763A2F19A5EFF34F8B7F1657C992EE297B310F3A@IRSMSX104.ger.corp.intel.com> References: <1513083027-11741-1-git-send-email-radu.nicolau@intel.com> <1516012789-4223-1-git-send-email-radu.nicolau@intel.com> <1516012789-4223-3-git-send-email-radu.nicolau@intel.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDkwZDk5ZmMtMDEwYy00NTMzLTkxY2QtZmZkNDg5NTA3OTJhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Im1Kb3IrOUwrXC9tNkpmd1BEcnF6MnBpVzNhOHh6cExsREhGMWo0YWp6cGFRPSJ9 dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 3/3] examples/ipsec_secgw: create session mempools for ethdevs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jan 2018 15:18:39 -0000 > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Thursday, January 18, 2018 3:11 PM > To: Nicolau, Radu ; dev@dpdk.org > Cc: Ananyev, Konstantin ; Yigit, Ferruh > ; Doherty, Declan ; > akhil.goyal@nxp.com > Subject: RE: [PATCH v2 3/3] examples/ipsec_secgw: create session > mempools for ethdevs >=20 > Hi Radu, >=20 > > -----Original Message----- > > From: Nicolau, Radu > > Sent: Monday, January 15, 2018 10:40 AM > > To: dev@dpdk.org > > Cc: Ananyev, Konstantin ; Yigit, Ferruh > > ; De Lara Guarch, Pablo > > ; Doherty, Declan > > ; akhil.goyal@nxp.com; Nicolau, Radu > > > > Subject: [PATCH v2 3/3] examples/ipsec_secgw: create session mempools > > for ethdevs > > > > Also moved offloaded packets from cryptodev queues > > >=20 > Could you rebase this patchset? After applying other changes, I had confl= icts > and when I resolve them, I am getting a compilation error. > I would appreciate if you could send another revision. Sure >=20 > Also, I have a small comment below. Already replied to that comment - if those variables are unsigned then the = code will need extra changes, which I would rather not do today, but if you= insist... :) >=20 > Thanks, > Pablo >=20 > > Signed-off-by: Radu Nicolau > > --- > > examples/ipsec-secgw/ipsec-secgw.c | 42 > > +++++++++++++++++++++++++++++++++++++- > > examples/ipsec-secgw/ipsec.c | 31 ++++++++++++++-------------- > > examples/ipsec-secgw/ipsec.h | 4 ++-- > > 3 files changed, 58 insertions(+), 19 deletions(-) > > > > diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec- > > secgw/ipsec-secgw.c index 83d7e32..7a1fd6b 100644 > > --- a/examples/ipsec-secgw/ipsec-secgw.c > > +++ b/examples/ipsec-secgw/ipsec-secgw.c > > @@ -1215,7 +1215,7 @@ cryptodevs_init(void) > > struct rte_cryptodev_config dev_conf; > > struct rte_cryptodev_qp_conf qp_conf; > > uint16_t idx, max_nb_qps, qp, i; > > - int16_t cdev_id; > > + int16_t cdev_id, port_id; >=20 > This should be uint8_t.