From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 0/7] build fixes
Date: Thu, 03 Jul 2014 00:13:59 +0200 [thread overview]
Message-ID: <7641305.RuYz2FeinY@xps13> (raw)
In-Reply-To: <59AF69C657FD0841A61C55336867B5B02CF134F1@IRSMSX103.ger.corp.intel.com>
2014-07-02 17:57, Richardson, Bruce:
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> > Sent: Wednesday, July 02, 2014 8:03 AM
> > To: dev@dpdk.org
> > Subject: [dpdk-dev] [PATCH 0/7] build fixes
> >
> > When enabling pcap PMD or debug options, there are many compiler errors.
> > There is also another error on BSD.
> >
> > These errors are due to many recent developments (link bonding,
> > rate limitation, ixgbe upgrade, vmxnet3, FILE argument for debug).
> >
> > So my comments are:
> > - I don't test every build configuration when accepting patches
> > - Many developers don't test debug configurations
> >
> > We should try to improve this process in the future.
> >
> > Please give quick feedbacks on this serie.
> > It requires a new release candidate.
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Tested compilation on Fedora Linux and FreeBSD 10 both in default
> configuration and with all debug options set for PMDs. No compile errors
> encountered with main compilation.
Applied for version 1.7.0.
Thanks
> However, two further minor issues spotted:
> * Running "gmake" in the examples directory gives errors for applications
> that only work in Linux.
> * The common_bsdapp file has all debug options
> turned on for the i40e driver by default.
I've fixed these BSD issues:
http://dpdk.org/browse/dpdk/commit/?id=304caba12
http://dpdk.org/browse/dpdk/commit/?id=3417cd687
Thanks for reporting
--
Thomas
prev parent reply other threads:[~2014-07-02 22:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-02 15:02 Thomas Monjalon
2014-07-02 15:02 ` [dpdk-dev] [PATCH 1/7] eal: fix build for bsd Thomas Monjalon
2014-07-02 15:02 ` [dpdk-dev] [PATCH 2/7] ethdev: fix build of Tx rate limitation debug Thomas Monjalon
2014-07-03 6:36 ` Zhang, Helin
2014-07-02 15:02 ` [dpdk-dev] [PATCH 3/7] ethdev: fix build of named allocation debug Thomas Monjalon
2014-07-02 15:02 ` [dpdk-dev] [PATCH 4/7] pcap: fix build Thomas Monjalon
2014-07-02 15:02 ` [dpdk-dev] [PATCH 5/7] virtio: fix build of debug dump Thomas Monjalon
2014-07-03 7:17 ` Xie, Huawei
2014-07-02 15:02 ` [dpdk-dev] [PATCH 6/7] vmxnet3: fix build with debug Thomas Monjalon
2014-07-02 15:02 ` [dpdk-dev] [PATCH 7/7] ixgbe/base: " Thomas Monjalon
2014-07-03 6:33 ` Zhang, Helin
2014-07-02 17:57 ` [dpdk-dev] [PATCH 0/7] build fixes Richardson, Bruce
2014-07-02 22:13 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7641305.RuYz2FeinY@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).