From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by dpdk.org (Postfix) with ESMTP id 54E9630E for ; Thu, 3 Jul 2014 00:13:48 +0200 (CEST) Received: by mail-wi0-f171.google.com with SMTP id n15so10437192wiw.16 for ; Wed, 02 Jul 2014 15:14:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=XGnM0v4ICfCGps7NAAZvUp/xnonEpzEgGvGKjwT/EBg=; b=iIokoF51camayzqTG2Pl3UBSV7d/p63fnExal5ekI6eXQVytYkWLyaoXdX0gRF2mcR oKKp7mDOleUT9CVxe6RY1bHH1DF1kVJJ/vyQ6NkoRtA3UQDYy7tki8WmmjLcMd/Z9Ov4 p6tsv9uie+S7cBk/uBT7vh+57bz/EHFssOV67dqzQq+UuyzQxlHWFXZzAYLHOvfTfzsz UEPkR1bfIklxWWCUGJ3B2Xp1EpFk5q+qoKxPjJ+rSM5ljCkDFjeEcB9gAZlU4WFbT4j1 8d3sLDM1zRz5Vuh3tkDEQzl3/3JmrCf2lRX1yhCpIE+3MR6VvayxEHwfgYrnvrclq61E 8eXQ== X-Gm-Message-State: ALoCoQlwQPfi2syBPOjpR6odHXpvHP1XKbwOz0FqbZ3CUrinMmX5ZGkTHZfQV5LwsEUUZ1wV8Mim X-Received: by 10.194.234.42 with SMTP id ub10mr687863wjc.42.1404339248755; Wed, 02 Jul 2014 15:14:08 -0700 (PDT) Received: from xps13.localnet (guy78-1-82-235-116-147.fbx.proxad.net. [82.235.116.147]) by mx.google.com with ESMTPSA id ed15sm54954063wic.9.2014.07.02.15.14.06 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Jul 2014 15:14:07 -0700 (PDT) From: Thomas Monjalon To: "Richardson, Bruce" Date: Thu, 03 Jul 2014 00:13:59 +0200 Message-ID: <7641305.RuYz2FeinY@xps13> Organization: 6WIND User-Agent: KMail/4.13.1 (Linux/3.14.6-1-ARCH; KDE/4.13.1; x86_64; ; ) In-Reply-To: <59AF69C657FD0841A61C55336867B5B02CF134F1@IRSMSX103.ger.corp.intel.com> References: <1404313375-2205-1-git-send-email-thomas.monjalon@6wind.com> <59AF69C657FD0841A61C55336867B5B02CF134F1@IRSMSX103.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 0/7] build fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jul 2014 22:13:48 -0000 2014-07-02 17:57, Richardson, Bruce: > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > > Sent: Wednesday, July 02, 2014 8:03 AM > > To: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH 0/7] build fixes > > > > When enabling pcap PMD or debug options, there are many compiler errors. > > There is also another error on BSD. > > > > These errors are due to many recent developments (link bonding, > > rate limitation, ixgbe upgrade, vmxnet3, FILE argument for debug). > > > > So my comments are: > > - I don't test every build configuration when accepting patches > > - Many developers don't test debug configurations > > > > We should try to improve this process in the future. > > > > Please give quick feedbacks on this serie. > > It requires a new release candidate. > > Acked-by: Bruce Richardson > > Tested compilation on Fedora Linux and FreeBSD 10 both in default > configuration and with all debug options set for PMDs. No compile errors > encountered with main compilation. Applied for version 1.7.0. Thanks > However, two further minor issues spotted: > * Running "gmake" in the examples directory gives errors for applications > that only work in Linux. > * The common_bsdapp file has all debug options > turned on for the i40e driver by default. I've fixed these BSD issues: http://dpdk.org/browse/dpdk/commit/?id=304caba12 http://dpdk.org/browse/dpdk/commit/?id=3417cd687 Thanks for reporting -- Thomas