From: Thomas Monjalon <thomas.monjalon@6wind.com> To: Helin Zhang <helin.zhang@intel.com> Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 2/3] i40e: extern two functions and relevant macros Date: Fri, 17 Oct 2014 22:59:09 +0200 Message-ID: <7641617.oBnDKljgVa@xps13> (raw) In-Reply-To: <1411089280-23595-3-git-send-email-helin.zhang@intel.com> 2014-09-19 09:14, Helin Zhang: > To reuse code, 'i40e_config_hena()' and 'i40e_parse_hena()' and > their relevant macros need to be extern, and then can be used for > both PF and VF parts. > > Signed-off-by: Helin Zhang <helin.zhang@intel.com> > Reviewed-by: Cunming Liang <cunming.liang@intel.com> > Reviewed-by: Jijiang Liu <jijiang.liu@intel.com> [...] > +#define I40E_RSS_OFFLOAD_ALL ( \ > + ETH_RSS_NONF_IPV4_UDP | \ > + ETH_RSS_NONF_IPV4_TCP | \ > + ETH_RSS_NONF_IPV4_SCTP | \ > + ETH_RSS_NONF_IPV4_OTHER | \ > + ETH_RSS_FRAG_IPV4 | \ > + ETH_RSS_NONF_IPV6_UDP | \ > + ETH_RSS_NONF_IPV6_TCP | \ > + ETH_RSS_NONF_IPV6_SCTP | \ > + ETH_RSS_NONF_IPV6_OTHER | \ > + ETH_RSS_FRAG_IPV6 | \ > + ETH_RSS_L2_PAYLOAD) > + > +/* All bits of RSS hash enable */ > +#define I40E_RSS_HENA_ALL ( \ > + (1ULL << I40E_FILTER_PCTYPE_NONF_IPV4_UDP) | \ > + (1ULL << I40E_FILTER_PCTYPE_NONF_IPV4_TCP) | \ > + (1ULL << I40E_FILTER_PCTYPE_NONF_IPV4_SCTP) | \ > + (1ULL << I40E_FILTER_PCTYPE_NONF_IPV4_OTHER) | \ > + (1ULL << I40E_FILTER_PCTYPE_FRAG_IPV4) | \ > + (1ULL << I40E_FILTER_PCTYPE_NONF_IPV6_UDP) | \ > + (1ULL << I40E_FILTER_PCTYPE_NONF_IPV6_TCP) | \ > + (1ULL << I40E_FILTER_PCTYPE_NONF_IPV6_SCTP) | \ > + (1ULL << I40E_FILTER_PCTYPE_NONF_IPV6_OTHER) | \ > + (1ULL << I40E_FILTER_PCTYPE_FRAG_IPV6) | \ > + (1ULL << I40E_FILTER_PCTYPE_FCOE_OX) | \ > + (1ULL << I40E_FILTER_PCTYPE_FCOE_RX) | \ > + (1ULL << I40E_FILTER_PCTYPE_FCOE_OTHER) | \ > + (1ULL << I40E_FILTER_PCTYPE_L2_PAYLOAD)) You've added the constants in the .h file but you forgot to remove them from the .c file. -- Thomas
next prev parent reply other threads:[~2014-10-17 20:51 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-09-19 1:14 [dpdk-dev] [PATCH v2 0/3] add i40e RSS support in VF Helin Zhang 2014-09-19 1:14 ` [dpdk-dev] [PATCH v2 1/3] ethdev: improvement for constant usage Helin Zhang 2014-09-19 1:14 ` [dpdk-dev] [PATCH v2 2/3] i40e: extern two functions and relevant macros Helin Zhang 2014-10-17 20:59 ` Thomas Monjalon [this message] 2014-10-20 1:11 ` Zhang, Helin 2014-09-19 1:14 ` [dpdk-dev] [PATCH v2 3/3] i40evf: support of RSS in VF Helin Zhang 2014-09-29 1:39 ` [dpdk-dev] [PATCH v2 0/3] add i40e RSS support " Zhan, Zhaochen 2014-10-10 3:10 ` Liang, Cunming 2014-10-11 7:57 ` Zhang, Helin 2014-10-20 2:58 ` [dpdk-dev] [PATCH v3 " Helin Zhang 2014-10-20 2:58 ` [dpdk-dev] [PATCH v3 1/3] ethdev: improvement for constant usage Helin Zhang 2014-10-20 2:58 ` [dpdk-dev] [PATCH v3 2/3] i40e: extern two functions and relevant macros Helin Zhang 2014-10-20 2:58 ` [dpdk-dev] [PATCH v3 3/3] i40evf: support of RSS in VF Helin Zhang 2014-10-20 6:50 ` [dpdk-dev] [PATCH v3 0/3] add i40e RSS support " Liu, Jijiang 2014-10-20 21:57 ` Thomas Monjalon 2014-10-20 8:43 ` Liang, Cunming
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=7641617.oBnDKljgVa@xps13 \ --to=thomas.monjalon@6wind.com \ --cc=dev@dpdk.org \ --cc=helin.zhang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git