From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) by dpdk.org (Postfix) with ESMTP id 1A17D7E74 for ; Fri, 17 Oct 2014 22:51:27 +0200 (CEST) Received: by mail-wi0-f181.google.com with SMTP id hi2so2222983wib.14 for ; Fri, 17 Oct 2014 13:59:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=ibkRChMDst2kPU24QJSwS+tRsr+CmYNLt+MQ+adEI+Q=; b=YrmYadXDJF5f7fJrxQsVeRNs8URlSWbhPE4rZIgef4XIErvmqtEfv0LfAqHfhdFjLQ nf7y+QUA+Siqj5x1sC+UTANAhERMYRhKQMxzXQ4awLlu80mKYVbcLGNFqsl+IvQTPSF1 Gzte6afZ/x0Iyxa74NdSe0EPgKjYKSbmYbr5dFEmh57UDOVsz98t8H8Y5MAm/xZSWhWO S+nQLcNg5YBFlyOM/QQQMHjNWM6nQGq+HLIjsL8pS1eRTQjZR+Q3MnweHvNwa0hj5s9d uUqGI8McX4wsz9Jt8b+MqMtls1nv7NzWBz4KQFrHp2XDTArCX8ugHPYlOOPRAQj60LlX dZ5g== X-Gm-Message-State: ALoCoQmnJJOWIbEfguQYW1Fu5mj4dHGSXFq2V9bv8rAxZ2+EDCyNCdxDc4Jg+CYdQzveUqpETpu0 X-Received: by 10.180.20.43 with SMTP id k11mr1714519wie.28.1413579566492; Fri, 17 Oct 2014 13:59:26 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id au4sm2980211wjc.15.2014.10.17.13.59.25 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Oct 2014 13:59:25 -0700 (PDT) From: Thomas Monjalon To: Helin Zhang Date: Fri, 17 Oct 2014 22:59:09 +0200 Message-ID: <7641617.oBnDKljgVa@xps13> Organization: 6WIND User-Agent: KMail/4.14.1 (Linux/3.16.4-1-ARCH; KDE/4.14.1; x86_64; ; ) In-Reply-To: <1411089280-23595-3-git-send-email-helin.zhang@intel.com> References: <1411089280-23595-1-git-send-email-helin.zhang@intel.com> <1411089280-23595-3-git-send-email-helin.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 2/3] i40e: extern two functions and relevant macros X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Oct 2014 20:51:27 -0000 2014-09-19 09:14, Helin Zhang: > To reuse code, 'i40e_config_hena()' and 'i40e_parse_hena()' and > their relevant macros need to be extern, and then can be used for > both PF and VF parts. > > Signed-off-by: Helin Zhang > Reviewed-by: Cunming Liang > Reviewed-by: Jijiang Liu [...] > +#define I40E_RSS_OFFLOAD_ALL ( \ > + ETH_RSS_NONF_IPV4_UDP | \ > + ETH_RSS_NONF_IPV4_TCP | \ > + ETH_RSS_NONF_IPV4_SCTP | \ > + ETH_RSS_NONF_IPV4_OTHER | \ > + ETH_RSS_FRAG_IPV4 | \ > + ETH_RSS_NONF_IPV6_UDP | \ > + ETH_RSS_NONF_IPV6_TCP | \ > + ETH_RSS_NONF_IPV6_SCTP | \ > + ETH_RSS_NONF_IPV6_OTHER | \ > + ETH_RSS_FRAG_IPV6 | \ > + ETH_RSS_L2_PAYLOAD) > + > +/* All bits of RSS hash enable */ > +#define I40E_RSS_HENA_ALL ( \ > + (1ULL << I40E_FILTER_PCTYPE_NONF_IPV4_UDP) | \ > + (1ULL << I40E_FILTER_PCTYPE_NONF_IPV4_TCP) | \ > + (1ULL << I40E_FILTER_PCTYPE_NONF_IPV4_SCTP) | \ > + (1ULL << I40E_FILTER_PCTYPE_NONF_IPV4_OTHER) | \ > + (1ULL << I40E_FILTER_PCTYPE_FRAG_IPV4) | \ > + (1ULL << I40E_FILTER_PCTYPE_NONF_IPV6_UDP) | \ > + (1ULL << I40E_FILTER_PCTYPE_NONF_IPV6_TCP) | \ > + (1ULL << I40E_FILTER_PCTYPE_NONF_IPV6_SCTP) | \ > + (1ULL << I40E_FILTER_PCTYPE_NONF_IPV6_OTHER) | \ > + (1ULL << I40E_FILTER_PCTYPE_FRAG_IPV6) | \ > + (1ULL << I40E_FILTER_PCTYPE_FCOE_OX) | \ > + (1ULL << I40E_FILTER_PCTYPE_FCOE_RX) | \ > + (1ULL << I40E_FILTER_PCTYPE_FCOE_OTHER) | \ > + (1ULL << I40E_FILTER_PCTYPE_L2_PAYLOAD)) You've added the constants in the .h file but you forgot to remove them from the .c file. -- Thomas