From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0057.outbound.protection.outlook.com [104.47.32.57]) by dpdk.org (Postfix) with ESMTP id 8C66F1B4EB for ; Tue, 9 Oct 2018 13:37:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PMemPg7DGKJ0DaezwcPjFfTETv79iOUzNZ6yfz0+vaE=; b=HxbIlqW51GQ2DgiCrwpEPGlht0bG/C+HsFR9RgNaUiTbcOJeLdbuNdYefnD+1OAZSLtn4j4PditoGwoXsuP+DM42yvBjGraLsyGCl0FW7y0wf3a0Ae26Vw7gy5+9GWPS3E9FereYMFGU9W9Qi/T74dUb0hxYDwG5URl3WLou7fw= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Anoob.Joseph@cavium.com; Received: from [10.88.100.222] (115.113.156.2) by BN7PR07MB4900.namprd07.prod.outlook.com (2603:10b6:408::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1228.21; Tue, 9 Oct 2018 11:37:36 +0000 To: Akhil Goyal Cc: dev@dpdk.org, Declan Doherty , Pablo de Lara , Radu Nicolau , Jerin Jacob , Narayana Prasad , "Verma, Shally" , Vidya Sagar Velumuri References: <20180828130105.30779-1-akhil.goyal@nxp.com> <20180828130105.30779-2-akhil.goyal@nxp.com> <0b682c3f-bb01-8970-f271-7ffa61cbface@nxp.com> <26ac4ab0-bb36-918a-23fe-41833eba9e7e@caviumnetworks.com> <08b3f2b9-260f-bea0-4cc1-61a40982190e@nxp.com> From: "Joseph, Anoob" Message-ID: <764461fa-3083-ff10-ab47-748b27e9d439@caviumnetworks.com> Date: Tue, 9 Oct 2018 17:08:42 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <08b3f2b9-260f-bea0-4cc1-61a40982190e@nxp.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [115.113.156.2] X-ClientProxiedBy: MA1PR0101CA0007.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:21::17) To BN7PR07MB4900.namprd07.prod.outlook.com (2603:10b6:408::10) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 64d94940-cf68-4eb4-941d-08d62ddb9e04 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:BN7PR07MB4900; X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4900; 3:NtKXzFraQe5Wz6n8kcm/06MiracPGCoEvLwnE3AC3xsExoGxg+l8gxzhj3ExpZtJdWECtKnNsXYXwn7GS6lkoMs4r4MBlTGw7haZN/TqUj4G/pk7v4Yzb/PamF+QO7FFv2cpJRET6RcsbvzLamTJ1qk44A0M4J0w0wcPx2KnJJJe1VaWkQDuNdhvlwZxly8z0MjdsXP+1GiWtgCPqI0wuadsFc+AZzeEJ3hsNIaX8SohHV4wNAQFFNFasY/zm1Va; 25:00QzlZX0+IKsCRS3r+NPA5uBm/yzow64zoSuwCPjuceh8jr1Wam/g8I2ukr88jFxPGGjNOrSE/2FRGF61OBhjbNPHJ+h+1oB79cidlGcHy7YLojupP7hl14ilJKmcjeZmPnShgtohxo6KJ/7hOnSU6MCh2/DdT8huZIuCD5dk97YvY1yPylaDD5jCsFXv8Tx5a9all3nr0BiDFbiK2uXSLFGtjEweFt+2YguGvh9wYvaPDIYqYKI5u9ThYjLEjkgfYSmedQQ7/vuHn8eJ0qNrPaxeaZvVWIHxSzIzYorDmVmsEAejN50+Gv45tEdwkN2GhmiW07KHEBpXToyzZM5PQ==; 31:y7oryfPOUvC+GnSJl0FdNs2EpySWOjctIX/MO1vMR/7e+nnK7rrVuJVoUbqlD2b4CoTew/q8L1RI4O/hsPENgaggT7Eynb2iB+6rEqVnVw4Inb0nJ7UlZHhfIIlJ5YPtykidlH4tVPVULtAqLwbcA/5m/D8r2ZlBUzU+wFLcDzlVdwEPPFpbvRS+Hek06Ey65C2zKZxfFg0NH41+6ocz6op+n1rHB8mOLEJTH92W7gc= X-MS-TrafficTypeDiagnostic: BN7PR07MB4900: X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4900; 20:X/1BcP+RpBR+HpPvPqv0BLCMqvD7GdZV7oZ5MgFLlhfKbj7gff/mil9W6jcv5A2AiQFxjh3e36nryFds2dD8aNrZMvmquqJaKbU9Au48SvNHJsGgJmrDjnNOuZ+SA/p0fsORrp9/HJO309MsNgQ0vjR7SfXk9OOg3AuqkaywlhfV5MXE7SZwR47LVcBKX1DUlaK508l0X7Ykh6JVYcuwIXBSvuScv0SRIZ5i2SLSRcAD1VfK9di3fmgwq1ZpEPjfuVuxoqwG/vjsymvGsHwkNxOMY+i0iqYECk6oxWuFxBCY2pzyrcE7Vqj9CemhKUNDen380GYKVOcIVkNlSG7i0t4T+c7sw4wgRIGuIafzgyDCB9SuGHFaRJzRpJTVlkpI2N9jS0kJPy3/44eIDkgWaNLPmQvDXFnWL20AsIrue7w4FFmF+obvfCH++ZNwnwlqBtiYOQkc3H3qLL4+xudlRs+um1rhKO7j0pHpX4c0dV5GpU+W23O7sM1ektb8/pqNESvafjROrV6M/p+Tx/Zxd8W4IDJqxBQEpm9vGDJzLWDpusHjvdPLq5KXcb1nUW1Qe7uS8IOk26pKRhJyYfhhUDxOvtwaj+fPyFNyjBZH9jk= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192374486261705)(269456686620040); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231355)(944501410)(52105095)(3002001)(93006095)(10201501046)(149066)(150057)(6041310)(20161123560045)(20161123558120)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051); SRVR:BN7PR07MB4900; BCL:0; PCL:0; RULEID:; SRVR:BN7PR07MB4900; X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4900; 4:FUKsiaD4JSvp0bDKWkhdoXqqBFV0VnjH0gIm2E5l4RfQbDdMmIo0fVb5AVW+PJlGtBtePkU0We14Jj1op6Cn6KwnrhwStUqwaf3B1y1Heq5wb94YvmaqCkhn0iV6o60D9TAFML0zsmTU32S+QnMXq7+9CcSd3ElYDY3Zl2e68U9heYNJTUIybBNa+fE/598Ig96LemMNZeS2mOYl/xXO1GyO8NjbLHT0HHsi/UIjAVun65OWd6Ap5nwDqPVHDf4Rs28YwVRRgA43WXdqNpv1CZhTwGA04C5envidMoGlJtGTolLWPr/tVBGwp9cM9JCM6GQeXcAGj2iv0/SxroA3jwxzJ/yTaHuTX6yS3vQDWXw= X-Forefront-PRVS: 08200063E9 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(366004)(376002)(396003)(39860400002)(346002)(136003)(189003)(199004)(26005)(31686004)(305945005)(6916009)(316002)(7736002)(47776003)(36756003)(77096007)(16526019)(186003)(93886005)(81166006)(16576012)(81156014)(8936002)(8676002)(15650500001)(2906002)(229853002)(31696002)(2870700001)(6666003)(3260700006)(25786009)(6486002)(14444005)(6246003)(64126003)(76176011)(4326008)(476003)(58126008)(2616005)(956004)(67846002)(486006)(66066001)(97736004)(65826007)(105586002)(54906003)(478600001)(23676004)(52146003)(2486003)(68736007)(65956001)(65806001)(6116002)(55236004)(42882007)(106356001)(3846002)(52116002)(72206003)(50466002)(107886003)(53546011)(11346002)(446003)(5660300001)(53936002)(386003); DIR:OUT; SFP:1101; SCL:1; SRVR:BN7PR07MB4900; H:[10.88.100.222]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjdQUjA3TUI0OTAwOzIzOiswc1U1VlQ1UVJXcWZvcFFrUCt4WllXNUZM?= =?utf-8?B?bjEwZHpJL25pK1djVXozV2Q1U3NUTURwOWdzc2ZucEIwNGJTb3BvWEthS082?= =?utf-8?B?UjVXaVgxZ2RvTVJyOWp2R1dTV2txWkRpODBGK1A4L3pDaG16b1pDcWVlK2Vk?= =?utf-8?B?Y0ZPbzl3NE55K085eWZNSDErWDdNZW4yS0ovNldIcmVFcm9SVTJvWW5VajNr?= =?utf-8?B?NWRvSmhJN2NKbENXRlB2WFFyY1BuVVpPMmhjVHlmUytqT0tnd2VlSHhZSzFo?= =?utf-8?B?a3VhVk44cXhMVld0cEd5SHdBTzhBWCtULy9kRzQ1Mm0xZThJTzdnUTNBNXQv?= =?utf-8?B?U3hpQzZIWTc4dWFrQW1aQlk4NG9SNW1Jb0M2UFhZOHVzT0FqMkRBcGE1VFoy?= =?utf-8?B?eWk0VVI5ZzNRenY1SktuZ2NLajJZNGJKSHhVR0dyVnhUcWNSZWJIczVUazZs?= =?utf-8?B?OGJOWHJZeGtaOTY2OEp5OHF2VjdKZVlNWkxGcHdZamJpZ1JRU2N2d2E3dWQw?= =?utf-8?B?TjUvUDF1T3Ezd29hSUFZU3p3QXZZck9ucVNSOUdpMGhYM0hmNjRMZGdUS0ti?= =?utf-8?B?MGdtV2pCb1lKWXhLTkxWZWxiQjd0bTBEUmNBaWdlU2RBNFZQSjBHb25hSXd3?= =?utf-8?B?ODJkNnNISHhVYWc2VGo4VE5NdXRzWmNOMXhVNVdvdWpuUU5QaU5MaElUZVFH?= =?utf-8?B?dEJwc2FaTm5tcnkzYVE4eGhmNVNTY0VySjlPdTM3U2NjKzJ0Sng0cDFpM2Vq?= =?utf-8?B?WVduT2hMclR3NnFyOUpaWnl2WWZzaWh5dlZKZUl1S2t3RHFvRVZ2RUs3YnE3?= =?utf-8?B?ZzZGT2FVQy8zNlczRDhkdG1ySFVsc0lrWWdTbHZUUGhDZ0tQSGZ5L0dUQkd5?= =?utf-8?B?M2x5REZXZ0lqdFhZbUFnQitua3pPTFpkcFZzZkZDRzhKOWQzV1A1bHVtbThw?= =?utf-8?B?YWNTNy9KSW1IekZybkFDZHBLd0ptRjNocC9INFdJNFNxNklGSEpTUmVHOFZp?= =?utf-8?B?cHk1VGE1a3hLOThNNzlyalBuK25xQWVTcUZRSHpadTBLcmxuRHlmY3huREdS?= =?utf-8?B?dit1OXMxcEdmMEJSZWRqZE9PTmpKRGhSM1NKTkZlV3lCWjZ0b2RPN0hKb3dq?= =?utf-8?B?dGwyNmFjREVPVzZwWll2SVBWSnVHNzQwTitSb09hZkxaOWVlOXhWNHMrMi9J?= =?utf-8?B?aHJGS1BGY2NEL1FBRTRYWjJ3ZXB4d0lWUHhLZ1hWMVhLMHdqSE94ZmhnMUFu?= =?utf-8?B?dUk0TzdoNlM4UDhKV3FzSjVycnlDRWxhKzZsVWdpUUhuV05td21EY3A3UHZn?= =?utf-8?B?Um5xQ3VIdWJUZ0tBRFZXemh6U1lnSkl2b1RTNXFrT01QQUNOZVVLdUM3WWJV?= =?utf-8?B?bFRZMVVxbWVQL25GTGdOWkJTV25hQnd2UDJ0b0VxNXdoK3U5U3dSV2hnbjht?= =?utf-8?B?bXdiQWZWSk82Q05UTFZLdGI2ZFNOT1NyN2ZHd2s1TUJhaC9YWG5wWktiWCtT?= =?utf-8?B?NXVLTTFLYVVORXhaeHhYeE1hVjBMNldWSGJHa2kvMTl4ZkNtYmMweFhsSUFK?= =?utf-8?B?T1RyV1V1OW5VUXF4SldITll1eGpaNVIvNjdhenBUOGFoakNNNWpRUDBzSm84?= =?utf-8?B?V1p5aGlsYThid1FtSVd2VXIrV2p5R2xZd3pOa2NuN2gzT0g5MVB5a245eFIy?= =?utf-8?B?KzhpNGNnQUJIcVhMZmZDMHRWV0dBS3lwODdVM1pLQjdJZTh4MW5mMnRIZ0VC?= =?utf-8?B?THhPSXF5RmVhKzNYQ3dvUWJ5VDNqVWI3d1NZdGJwR0FkbnAxSllKVmsxY1RY?= =?utf-8?B?NGNxdnR0MVh1bCt5b3h3VHVnQ3VKdytKajB2SzdTN3pXMkFjUFo3RURlV0R6?= =?utf-8?B?REw4bWNxUTJpeFMyWi9KVzg2NlZTYTMwOG1NNUdyUml6VmM3ckh0RjVGTXAy?= =?utf-8?B?c0dyQlpyMXIxeFFIcTFwMEVncVU3STFnaEQ4Q3phc0ZmZnlGbE1YOUNocXN3?= =?utf-8?B?bWZBaWVWNUp2MnVldjNPRmZ6K3E2QXF6SzBXTVA0b1VMYTd4NjFVc2kveFFR?= =?utf-8?B?MlNjcWJLekF5TElZWXdXK0VXUnd6dTYxK1FPeVJiT0hHK3BzTDEwTVhmZUtW?= =?utf-8?Q?tjCW0Qgtf0xizKq+jD0QRXQYmHGVifVLh4lqTLxY+x2g?= X-Microsoft-Antispam-Message-Info: e6wh2u73d8vF6lzMsqh17RnfXZDdx/TqXxwS+bOsNmr6g7Wd4YqouWuis0Zx2ug73uGYSbTiAiM/0SQGsH46h57In/k4ViYIJ7oeRzRzOT3whRQGVOoYNhIJMa7hWzxtYYS58qacXxpzgND2QTDIuaYCcG2JB+KxEJOqFgLG2bQqln5L94t7okWwcJEBevVxdl+MhdtJ6yB24wBgrzWlc32RNoby8J7oxqlgESODvKqVbwQF5Wqif7bIlEJJUQn4/Fi9e+uV9AArBMNFMrnpwIzqHSr0ONRQkRuT2uuj4U5djQ1MtX498YNP55CLfnRG/9bAl19+RGifZts5x7wiqmtnwSCc1WIOFawKwe5dBPE= X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4900; 6:Cz3kbDvrLgybsqBRuOJeSpWXM4eAFSyj1Q9ui8+fhda/+xCWZShDfisXEWqIXxEApVyno4VEptFrjz43yQcjXwerh7mb1x8gDa9xOxkHRWq8uTq7zU2H2rqOWiBkXDyvrKz7dBHUFpWsRfL5VMUDRvnePJBzqrSjaWPEzVKCjscXgVXndWllLEW1YE8PUAS0m4J/zgOXhYJ0RV6aDtfvW4iRsCF12B6WM/OdrkQ/qRrNTU+YOOFyw1fX3rrh9EuekjVjTYk/F1pjpex9a9EuN6eH/azSU+L59GzEYimbl9q15KxnT2SzPDaFLYtNrdFTjNhF8ug4Yr2fQS6tVkBiEVJSj73xBchx6kOZWnfpsBwnbrk6vuxVnk0iAr6uX5PvxFX6iwZCfD2hQ6XwZEBdMA1VgG9rhbdUfyJoHrwEHN6Pea4jGuDm0K1Ga4PbiWULDGVjNth5WHmnhtp+uVOhoA==; 5:1ja1UnFiKHfhhP0P/FcvW5XgoLjFkpAQXAN4eHXgRyVt/cy29uh4gdBZMxFe9m3wx5VSOvaTSuJonilTbBGa57PkKIcYcm/dkRAG+edqYLAfVNhXfQL+plUbhQuGNlUl09z/c/ncWcfxBsXZg/aoo0FN/B76zJG67RrzvOwRotw=; 7:S+Zm+sGKGSKQDnxzBSIR+Dha0bIF6m9cG7SjC/4sRTdpWDk+OyYF7OKdcF3Mt8XVrmhWFTNdLcIqz/Ijf8NvHRHzN+bnudTlNkdP4iOasfugxjKadxXfgnthPdGkqlp3g83Ozek3+3t3dPH+WNdxdDIMml3tXrO3abUIXtd3O7N3+PYnaBbTk0HtNhWQCrasxDhDG3uHdj5E1Vbs/2TJsu1zbXfig+DgVVsjgz0ZQ7Qf40nNFHueSc6TGE7zZfov SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2018 11:37:36.0920 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 64d94940-cf68-4eb4-941d-08d62ddb9e04 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR07MB4900 Subject: Re: [dpdk-dev] [PATCH 1/3] security: support pdcp protocol X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Oct 2018 11:37:40 -0000 Hi Akhil, Please see inline. Thanks, Anoob On 08-10-2018 15:19, Akhil Goyal wrote: > External Email > > Hi Anoob, >>>>> @@ -494,6 +553,23 @@ IPsec related configuration parameters are >>>>> defined in ``rte_security_ipsec_xform >>>>>            /**< Tunnel parameters, NULL for transport mode */ >>>>>        }; >>>>> +PDCP related configuration parameters are defined in >>>>> ``rte_security_pdcp_xform`` >>>>> + >>>>> +.. code-block:: c >>>>> + >>>>> +    struct rte_security_pdcp_xform { >>>>> +        int8_t bearer; /**< PDCP bearer ID */ >>>>> +        enum rte_security_pdcp_domain domain; >>>>> +        /** < PDCP mode of operation: Control or data */ >>>>> +        enum rte_security_pdcp_direction pkt_dir; >>>>> +        /**< PDCP Frame Direction 0:UL 1:DL */ >>>>> +        enum rte_security_pdcp_sn_size sn_size; >>>>> +        /**< Sequence number size, 5/7/12/15 */ >>>>> +        int8_t hfn_ovd; /**< Overwrite HFN per operation */ >>>>> +        uint32_t hfn;  /**< Hyper Frame Number */ >>>>> +        uint32_t hfn_threshold;        /**< HFN Threashold for key >>>>> renegotiation */ >>>>> +    }; >>>>> + >>>> [Anoob] PDCP packet ordering should be both a capability and a >>>> setting. >>>> HFN will be incremented overtime and starts at 0. So why is it part of >>>> the xform? >>> >>> The Security accelerators may assume packet in order. Latest PDCP TS >>> suggest to do de-Ciphering before re-Ordering the Rx PDCP PDUs. In this >>> situation, the accelerator may use wrong HFN value. The PDCP >>> application >>> can provide the appropriate HFN value along with PDU to the security >>> accelerator. >>> >> So what is the expectation with regards to ordering? Would PDCP know >> the order or is it unaware of the order? >> If implementation of this Spec knows the order of packets(which is >> implied by the "In order delivery and Duplicate detection >> Sequence Numbering" statement in the PDCP flow diagram), then there >> should be no need to override the >> HFN. If the implementation does not know the order of packets, then >> the flow diagram should be corrected. >> Also, is implementation expected to support ordered delivery and >> duplicate detection. Perhaps it should be >> a capability or 2. > This patchset is basically talking about full protocol offload with look > aside accelerators. > And when we are talking about full protocol offload, all protocol > related stuff like ordering, headers etc. > needs to be handled by the HW/driver. > So the expectation is driver/HW should be able to perform in order > delivery and detect duplicates. How will errors in these situations be reported to the application - if packets are not in order or if a duplicate is detected - how should driver report it? Is the driver/HW expected to correct the order OR is the behaviour limited to detection of out-of-order? In order to correct the order, the driver/HW will need to accumulate packets. Is that really the expectation of this specification > If somebody have support for PDCP in the hardware, we can add > capabilities as per the specific requirements. > In v2/v3 I have removed the hfn_override. Will add it later when it will > be supported. > > > Thanks, > Akhil