From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 617E61B105; Wed, 10 Apr 2019 19:06:33 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A6BC83084212; Wed, 10 Apr 2019 17:06:32 +0000 (UTC) Received: from [10.36.117.94] (ovpn-117-94.ams2.redhat.com [10.36.117.94]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1A24F413C; Wed, 10 Apr 2019 17:06:30 +0000 (UTC) To: Ferruh Yigit , Hyong Youb Kim Cc: dev@dpdk.org, John Daley , "stable@dpdk.org" , Yongseok Koh References: <20190302104251.32565-1-hyonkim@cisco.com> <20190302104251.32565-14-hyonkim@cisco.com> From: Kevin Traynor Message-ID: <76447a14-5774-8c96-e2d7-2b7912b26c26@redhat.com> Date: Wed, 10 Apr 2019 18:06:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Wed, 10 Apr 2019 17:06:32 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v2 13/13] net/enic: fix several issues with inner packet matching X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Apr 2019 17:06:33 -0000 On 04/03/2019 16:58, Ferruh Yigit wrote: > On 3/2/2019 10:42 AM, Hyong Youb Kim wrote: >> Inner packet matching is currently buggy in many cases. >> >> 1. Mishandling null spec ("match any"). >> The copy_item functions do nothing if spec is null. This is incorrect, >> as all patterns should be appended to the L5 pattern buffer even for >> null spec (treated as all zeros). >> >> 2. Accessing null spec causing segfault. >> >> 3. Not setting protocol fields. >> The NIC filter API currently has no flags for "match inner IPv4, IPv6, >> UDP, TCP, and so on". So, the driver needs to explicitly set EtherType >> and IP protocol fields in the L5 pattern buffer to avoid false >> positives (e.g. reporting IPv6 as IPv4). >> >> Instead of keep adding "if inner, do something differently" cases to >> the existing copy_item functions, introduce separate functions for >> inner packet patterns and address the above issues in those >> functions. The changes to the previous outer-packet copy_item >> functions are mechanical, due to reduced indentation. >> >> Fixes: 6ced137607d0 ("net/enic: flow API for NICs with advanced filters enabled") >> >> Signed-off-by: Hyong Youb Kim > > <...> > > I have added "Cc: stable@dpdk.org" tag while merging. If the tag explicitly left > out to prevent backport please let me know to remove the tag back. > Hi Hyong, I can't apply this patch with confidence on the 18.11 LTS branch due to the amount of changes and conflicts. The other relevant patches in the series for 18.11 were ok. If you want the fixes from this patch on stable branches, can you please send a backport for them (http://doc.dpdk.org/guides/contributing/patches.html?highlight=stable#backporting-patches-for-stable-releases). Otherwise, please let us know that you don't want them on stable branches. thanks, Kevin. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 92123A0096 for ; Wed, 10 Apr 2019 19:06:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5C64E1B163; Wed, 10 Apr 2019 19:06:35 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 617E61B105; Wed, 10 Apr 2019 19:06:33 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A6BC83084212; Wed, 10 Apr 2019 17:06:32 +0000 (UTC) Received: from [10.36.117.94] (ovpn-117-94.ams2.redhat.com [10.36.117.94]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1A24F413C; Wed, 10 Apr 2019 17:06:30 +0000 (UTC) To: Ferruh Yigit , Hyong Youb Kim Cc: dev@dpdk.org, John Daley , "stable@dpdk.org" , Yongseok Koh References: <20190302104251.32565-1-hyonkim@cisco.com> <20190302104251.32565-14-hyonkim@cisco.com> From: Kevin Traynor Message-ID: <76447a14-5774-8c96-e2d7-2b7912b26c26@redhat.com> Date: Wed, 10 Apr 2019 18:06:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Wed, 10 Apr 2019 17:06:32 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v2 13/13] net/enic: fix several issues with inner packet matching X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190410170629.PGZBMLQiwd47Vlp0VF_rBhZNrvPKQsSlIHIYcXMfGRk@z> On 04/03/2019 16:58, Ferruh Yigit wrote: > On 3/2/2019 10:42 AM, Hyong Youb Kim wrote: >> Inner packet matching is currently buggy in many cases. >> >> 1. Mishandling null spec ("match any"). >> The copy_item functions do nothing if spec is null. This is incorrect, >> as all patterns should be appended to the L5 pattern buffer even for >> null spec (treated as all zeros). >> >> 2. Accessing null spec causing segfault. >> >> 3. Not setting protocol fields. >> The NIC filter API currently has no flags for "match inner IPv4, IPv6, >> UDP, TCP, and so on". So, the driver needs to explicitly set EtherType >> and IP protocol fields in the L5 pattern buffer to avoid false >> positives (e.g. reporting IPv6 as IPv4). >> >> Instead of keep adding "if inner, do something differently" cases to >> the existing copy_item functions, introduce separate functions for >> inner packet patterns and address the above issues in those >> functions. The changes to the previous outer-packet copy_item >> functions are mechanical, due to reduced indentation. >> >> Fixes: 6ced137607d0 ("net/enic: flow API for NICs with advanced filters enabled") >> >> Signed-off-by: Hyong Youb Kim > > <...> > > I have added "Cc: stable@dpdk.org" tag while merging. If the tag explicitly left > out to prevent backport please let me know to remove the tag back. > Hi Hyong, I can't apply this patch with confidence on the 18.11 LTS branch due to the amount of changes and conflicts. The other relevant patches in the series for 18.11 were ok. If you want the fixes from this patch on stable branches, can you please send a backport for them (http://doc.dpdk.org/guides/contributing/patches.html?highlight=stable#backporting-patches-for-stable-releases). Otherwise, please let us know that you don't want them on stable branches. thanks, Kevin.