[dpdk-dev] Fwd: |WARNING| pw23442 [PATCH] net/tap: add support for fixed mac addresses

[dpdk-dev] Fwd: |WARNING| pw23442 [PATCH] net/tap: add support for fixed mac addresses

[Wiles, Keith]

Begin forwarded message:

From: <checkpatch@dpdk.org<mailto:checkpatch@dpdk.org>>
Subject: |WARNING| pw23442 [PATCH] net/tap: add support for fixed mac addresses
Date: April 10, 2017 at 1:20:18 PM CDT
To: <test-report@dpdk.org<mailto:test-report@dpdk.org>>
Cc: Keith Wiles <keith.wiles@intel.com<mailto:keith.wiles@intel.com>>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/23442

_coding style issues_


CHECK:BRACES: braces {} should be used on all arms of this statement
#100: FILE: drivers/net/tap/rte_eth_tap.c:1242:
+ if (fixed_mac_type) {
[...]
+ } else
[...]

CHECK:BRACES: Unbalanced braces around else statement
#109: FILE: drivers/net/tap/rte_eth_tap.c:1251:
+ } else

total: 0 errors, 0 warnings, 2 checks, 123 lines checked

Got the above error running checkpatch locally then got the email above and I assumed this warning can be ignored is this the case?

Code that caused the warning:

} else {
if (fixed_mac_type) {
static int iface_idx;

pmd->eth_addr.addr_bytes[0] = 0x00;
pmd->eth_addr.addr_bytes[1] = 'd';
pmd->eth_addr.addr_bytes[2] = 't';
pmd->eth_addr.addr_bytes[3] = 'a';
pmd->eth_addr.addr_bytes[4] = 'p';
pmd->eth_addr.addr_bytes[5] = 0 + iface_idx++;
} else
eth_random_addr((uint8_t *)&pmd->eth_addr);     <<<<<
}

Regards,
Keith

Re: [dpdk-dev] Fwd: |WARNING| pw23442 [PATCH] net/tap: add support for fixed mac addresses

[Ferruh Yigit]

On 4/10/2017 7:29 PM, Wiles, Keith wrote:
> 
> 
> Begin forwarded message:
> 
> From: <checkpatch@dpdk.org<mailto:checkpatch@dpdk.org>>
> Subject: |WARNING| pw23442 [PATCH] net/tap: add support for fixed mac addresses
> Date: April 10, 2017 at 1:20:18 PM CDT
> To: <test-report@dpdk.org<mailto:test-report@dpdk.org>>
> Cc: Keith Wiles <keith.wiles@intel.com<mailto:keith.wiles@intel.com>>
> 
> Test-Label: checkpatch
> Test-Status: WARNING
> http://dpdk.org/patch/23442
> 
> _coding style issues_
> 
> 
> CHECK:BRACES: braces {} should be used on all arms of this statement
> #100: FILE: drivers/net/tap/rte_eth_tap.c:1242:
> + if (fixed_mac_type) {
> [...]
> + } else
> [...]
> 
> CHECK:BRACES: Unbalanced braces around else statement
> #109: FILE: drivers/net/tap/rte_eth_tap.c:1251:
> + } else
> 
> total: 0 errors, 0 warnings, 2 checks, 123 lines checked
> 
> Got the above error running checkpatch locally then got the email above and I assumed this warning can be ignored is this the case?

Linux requires, if "if" or "else" part is multi-line, both block should
use brackets, that is the reason of the warning.

But DPDK does not requires this:
http://dpdk.org/doc/guides/contributing/coding_style.html#control-statements-and-loops

For DPDK, this is free to ignore.

> 
> Code that caused the warning:
> 
> } else {
> if (fixed_mac_type) {
> static int iface_idx;
> 
> pmd->eth_addr.addr_bytes[0] = 0x00;
> pmd->eth_addr.addr_bytes[1] = 'd';
> pmd->eth_addr.addr_bytes[2] = 't';
> pmd->eth_addr.addr_bytes[3] = 'a';
> pmd->eth_addr.addr_bytes[4] = 'p';
> pmd->eth_addr.addr_bytes[5] = 0 + iface_idx++;
> } else
> eth_random_addr((uint8_t *)&pmd->eth_addr);     <<<<<
> }
> 
> Regards,
> Keith
>