From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7366BA0C47; Wed, 17 Nov 2021 00:14:18 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3FB544068C; Wed, 17 Nov 2021 00:14:18 +0100 (CET) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by mails.dpdk.org (Postfix) with ESMTP id E73ED40040 for ; Wed, 17 Nov 2021 00:14:16 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id 1A0D55809E0; Tue, 16 Nov 2021 18:14:15 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 16 Nov 2021 18:14:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= k7ImQd49nV8IE3bxVag/2kbHXyR4Xed48x9SiVaCWTU=; b=HF8Honl3+CiFsG/z k8NqU/y52zUDSjmU08JUhWsKRWEgYNu0qvTF7dXN9kTcvyGKAZHXnF364y0bq61v eUUADm5ZeZMXg/L43OElvnfGx3Ld5uUTPnbSngT2XTDLGxhNo48kj4p6wehWkWBb bwQiyMfelz/+zAbYUH1kJYqkzoHPteGWMI2BT1cjZEIyWOIZmaVz2RnqqA3sT8AR shpRxr1kTL4vGvDQa7ORe3qFyiD16O94eF0nfEqfdStBKQYAWi9TUAvA9GGxsC8I imarM6Y0GJ3ujWI4U905jH1ZpEOTbChRN+AgO2LXIBz53dtefDpixy8QcgqzpkjV S5hCJw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=k7ImQd49nV8IE3bxVag/2kbHXyR4Xed48x9SiVaCW TU=; b=TgtL1FWGW6VGkZ3IVVcar+rM4OK7njQq7HEnRolHg8EOU90WlTfLzg4JR 8DqzPOzByJwviCH14GjP0lw/97SBLhbRT0rhzsWms3cMPCdQ5IKeuKdSMqV9R4MN ktDiUz6ls4Pe3TwEqdSJNXy7BoNssI8vj4HaGgmVi9QhzM4L1LxCHSVsuajqfJ+t orY/CutyH1Ezy9iwffbWw7cIJMcbw9CAZsPG0tqUTvOLw6rphm72oE1j2/OgQ4Zs +lYyYi1vvyw1J8ZYnGPAuVXK7FTeMlYf996agejVaiJu7mjjvQfbSLVkLO5Xa8KC DPcfrNvzqeoejBg/Ao2/YNwVhpffw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrfeefgddtjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 16 Nov 2021 18:14:11 -0500 (EST) From: Thomas Monjalon To: Ferruh Yigit Cc: Rasesh Mody , Shahed Shaikh , Rahul Lakkireddy , Qi Zhang , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , Beilei Xing , Jingjing Wu , Qiming Yang , Rosen Xu , Haiyue Wang , Jiawen Wu , Jian Wang , Maxime Coquelin , Chenbo Xia , Olivier Matz , dev@dpdk.org Subject: Re: [PATCH] net: add macro for VLAN header length Date: Wed, 17 Nov 2021 00:14:10 +0100 Message-ID: <7652023.1kbqhHN0E7@thomas> In-Reply-To: <20211110174029.614449-1-ferruh.yigit@intel.com> References: <20211110174029.614449-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 10/11/2021 18:40, Ferruh Yigit: > Multiple drivers are defining macros for VLAN header length, to remove > the redundancy defining macro in the ether header. > And updated drivers to use the new macro. > > Signed-off-by: Ferruh Yigit [...] > --- a/lib/net/rte_ether.h > +++ b/lib/net/rte_ether.h > +#define RTE_VLAN_HLEN 4 Please could you add a doxygen comment for this constant? > +/** Maximum VLAN frame length, including CRC. */ > #define RTE_ETHER_MAX_VLAN_FRAME_LEN \ > - (RTE_ETHER_MAX_LEN + 4) > - /**< Maximum VLAN frame length, including CRC. */ > + (RTE_ETHER_MAX_LEN + RTE_VLAN_HLEN) What about QinQ?