From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6726842C50; Mon, 12 Jun 2023 18:36:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 40D76410DD; Mon, 12 Jun 2023 18:36:36 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id E10B540698 for ; Mon, 12 Jun 2023 18:36:34 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 515A15C0097; Mon, 12 Jun 2023 12:36:34 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 12 Jun 2023 12:36:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1686587794; x=1686674194; bh=Hy02Ube291YIDR6Vttm+x5lDKAnobjUP0FV lF3nhOfo=; b=vuAfMN9NV4hZ7/2zr+2tUJbm5D0IOcWGrWbHdNl3FtR4iy5jCzp JfLfO4vXgEkUT0G8Euzd46kCMQpg8rL7H7YlK6BzvLJMrL7ggau+nqISLSBUxTI9 rVcLAFbrqRNkxq9pgT34ZYB5typb2q7mexkBtYLEAcC3QR/3pSla5oE8nmSjaQ5D JxhcV6bbvRgw8GKk16pDIBkcQDig1r0hZ2MRGkQtwEpUCGyvO+/h5UhEPsh0TK6O fCH0tLCEO1c8skQzM5RFPYoLNI5xrjIts56Ixjj5gU666qTvCC8eEjyHhU5ysJqN W9PqEDNSTHgaTq1cosR6aTU5dHFqojsM54g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1686587794; x=1686674194; bh=Hy02Ube291YIDR6Vttm+x5lDKAnobjUP0FV lF3nhOfo=; b=MlWnKDBQzcnpvovAh3wYeXXBFUBi6Ewl7Pgpco+6VTPdPEUGe6S hVujn9fMb1hB59OaDHCl9x673Ng5tviREjy+PfJgR7qn9oFMhBLReu2WhrTF7vew JafTJf0fmYvk4rMcMLmH8PAQ/swDYz4st0+4LJM74aShRczaVusHCPtRtl2xJ1Nd VKccz/pEpeaPA/PA4zp058EvvEKC3r1AwgA0OTd6IzmEzNGdWWJr8S1e2DRznSoM kzjodeCe31UHz4RqyoTbIxMzAE6q1WTiM/IUHRHX5Cvo2PEhZvShNocm4QBcivyG hGEiY/xN7rFvx3LpAEDfRvZESCv6IWhktJg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeduhedguddtvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 12 Jun 2023 12:36:33 -0400 (EDT) From: Thomas Monjalon To: Chenbo Xia Cc: dev@dpdk.org, "Burakov, Anatoly" Subject: Re: [PATCH] bus/pci: fix return value check of device FD Date: Mon, 12 Jun 2023 18:36:32 +0200 Message-ID: <7668137.lvqk35OSZv@thomas> In-Reply-To: References: <20230612051127.44418-1-chenbo.xia@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 12/06/2023 11:47, Burakov, Anatoly: > On 6/12/2023 6:11 AM, Chenbo Xia wrote: > > Fixing return value check of rte_intr_dev_fd_get() to make sure > > negative device FD will not be used later. > > > > Coverity issue: 385380, 385373 > > Fixes: 095cf6e68b28 ("bus/pci: introduce MMIO read/write") > > Fixes: 4b741542ecde ("bus/pci: avoid depending on private kernel value") > > > > Signed-off-by: Chenbo Xia > > --- > > Acked-by: Anatoly Burakov Applied, thanks.