From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4529342D23; Thu, 22 Jun 2023 13:54:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C9ACE406B8; Thu, 22 Jun 2023 13:54:10 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 5E95E406A2 for ; Thu, 22 Jun 2023 13:54:09 +0200 (CEST) Received: from [192.168.1.40] (unknown [188.170.81.161]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id DAD0950; Thu, 22 Jun 2023 14:54:07 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru DAD0950 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1687434848; bh=8s5L6cc0IlGdC9+lo5790Q4NUDmZGM9O608krszROpE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Rl0s95rSXJYAC0BRJOKqHK/Xg1Jpe7xaVq7JscM9eQslTwMlXRB1UW5+T2XPp+GRv VWKF0KM3s+2EBbhLpmdAq0UDRmrvv9165UfZnKfOGV2NNAm+VrcTCFegxLtv3Z23W4 Cqqf/7/Qu5pcn1y/1aglAThsTcx5eds7I/fKYW+I= Message-ID: <7680f172-25f2-f6a1-872e-b7e7c3f645cd@oktetlabs.ru> Date: Thu, 22 Jun 2023 14:54:07 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v6 3/4] common/sfc_efx/base: add support to enable VLAN stripping Content-Language: en-US To: Artemii Morozov , dev@dpdk.org Cc: Ivan Malov , Viacheslav Galaktionov , Andy Moreton References: <20230531134122.119508-1-artemii.morozov@arknetworks.am> <20230622113104.261556-1-artemii.morozov@arknetworks.am> <20230622113104.261556-4-artemii.morozov@arknetworks.am> From: Andrew Rybchenko In-Reply-To: <20230622113104.261556-4-artemii.morozov@arknetworks.am> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/22/23 14:31, Artemii Morozov wrote: > To enable VLAN stripping, two conditions must be met: > the corresponding flag must be set and the appropriate > Rx prefix should be requested. > VLAN stripping is supported on EF100. > > Signed-off-by: Artemii Morozov > Reviewed-by: Ivan Malov > Reviewed-by: Andy Moreton with minor style fix, see below: Acked-by: Andrew Rybchenko > diff --git a/drivers/common/sfc_efx/base/ef10_filter.c b/drivers/common/sfc_efx/base/ef10_filter.c > index 278502fb61..827b3e8f00 100644 > --- a/drivers/common/sfc_efx/base/ef10_filter.c > +++ b/drivers/common/sfc_efx/base/ef10_filter.c > @@ -171,6 +171,7 @@ efx_mcdi_filter_op_add( > EFX_MCDI_DECLARE_BUF(payload, MC_CMD_FILTER_OP_V3_IN_LEN, > MC_CMD_FILTER_OP_EXT_OUT_LEN); > efx_filter_match_flags_t match_flags; > + efx_port_t *epp = &(enp->en_port); > uint32_t port_id; > efx_rc_t rc; > > @@ -338,6 +339,11 @@ efx_mcdi_filter_op_add( > FILTER_OP_V3_IN_MATCH_SET_FLAG, 1); > } > > + if (epp->ep_vlan_strip) { > + MCDI_IN_SET_DWORD_FIELD(req, FILTER_OP_V3_IN_MATCH_ACTION_FLAGS, > + FILTER_OP_V3_IN_MATCH_STRIP_VLAN, 1); 4 spaces alignment, please, on line continuation in libefx > + } > + > efx_mcdi_execute(enp, &req); > > if (req.emr_rc != 0) { > [snip]