From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 297D841BA1; Wed, 1 Feb 2023 18:28:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BC2DA42B8E; Wed, 1 Feb 2023 18:28:49 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id CF2524113F for ; Wed, 1 Feb 2023 18:28:48 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 6993F5C016A; Wed, 1 Feb 2023 12:28:48 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 01 Feb 2023 12:28:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1675272528; x= 1675358928; bh=dl3lc6/U3Bc6N3QfsSbqfdpMHn1+tjbDFdJNkmDMPzA=; b=A KB+/OJx2QYmMNAWyGfw+Jd5dqyVcOisSLCxRQKrV0FwLWmOk9TnsJo3EYJE+EGpR uf80kZCuAQj3ntTgAXOI/xPs992eWS0U/9fJFnRoptZEHN6R0ZxnBWc7E5ybtMu5 NLd1sJzuM3bLftmF6k9FOyHC7+ye/gzWdemtLOHd/Q8Mg0OxwUxZZmaL25qDv6pg wGUJG6yWzzvjJijalls4G9q7++WY9iaqHCDqRi6OwH+YFSbmh9mnl4RYjyg+wuyK HPax3TEibnWEdwP7D+MD5oQXO/HhxvUA4aM3zPWQ3uYYfgOMyNCv1j6VI91sRJuT BQoU5hfuWbkIllSiDG4YQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1675272528; x= 1675358928; bh=dl3lc6/U3Bc6N3QfsSbqfdpMHn1+tjbDFdJNkmDMPzA=; b=E o9WDBKCQek/Hl4hOpX60wXf3SkzjJxuzGdqiKaadVO5chLYniKtN6EjYg2g60Mki CZm0u4cKBB7dpY2A/WjpqIf1nut4XDJ7IQTeibBmucSyUWh7GvmL2BTfCkzkxQGT u9s3a5OLKgpqbMHsXIR4PRWINavYmL7/yigSA29zcYrR1fedQuN6Ej1Xiv9PpLgF Nj2NFWqB+Ugu3eIZ5FMBLuovEZHwtxCXiCfo08/xIuQjLIT3DM1h3d9qAM0ijod/ gY5MHA+01dHr8ht+uH+vRjqB81fCnyWRGWLQKc+RnTYwFnOsjRBnZNCkBMrMw9lA hwuoPMZlcBV4ks+UpdT8A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudefiedguddtvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 1 Feb 2023 12:28:46 -0500 (EST) From: Thomas Monjalon To: Mohammad Iqbal Ahmad Cc: dev@dpdk.org, Vladimir Medvedkin , Konstantin Ananyev , Conor Walsh , jerinj@marvell.com, skori@marvell.com, skoteshwar@marvell.com, pbhagavatula@marvell.com, kirankumark@marvell.com, psatheesh@marvell.com, asekhar@marvell.com, anoobj@marvell.com, gakhil@marvell.com, hkalra@marvell.com, ndabilpuram@marvell.com Subject: Re: [PATCH v1] examples/l3fwd: fix for coverity scan Date: Wed, 01 Feb 2023 18:28:44 +0100 Message-ID: <7686290.gsGJI6kyIV@thomas> In-Reply-To: <20230110163442.1157560-1-mahmad@marvell.com> References: <20221216073958.1645736-1-mahmad@marvell.com> <20230110163442.1157560-1-mahmad@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 10/01/2023 15:56, Mohammad Iqbal Ahmad: > This patch fixes (Logically dead code) coverity issue. > This patch also fixes (Uninitialized scalar variable) coverity issue. > > Coverity issue: 381687 > Coverity issue: 381686 > Fixes: 6a094e328598 ("examples/l3fwd: implement FIB lookup method") > > Signed-off-by: Mohammad Iqbal Ahmad It seems you removed "if (nh != FIB_DEFAULT_HOP)" Please could you explain what was the issue inside the commit message. It could help to find a better title as well.