From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 067D443214; Fri, 27 Oct 2023 10:59:28 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B2744402E4; Fri, 27 Oct 2023 10:59:27 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 6044B40272 for ; Fri, 27 Oct 2023 10:59:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698397165; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nthNLcM54clb758wa+tOFVRUlC4qd7yK/hBYFWoohps=; b=bXao2ijYVW+BXimpgDw1VWHjYThCVZDLxoiGezt9muQTMGh7pje3HFCU6+MNNp3psNLDvq E99p7KtRyMNQs/8gserxhrcSUmr85Je1LoMpTWfjUS98xLReyBRX1Gdh2reFb8J5O8VFYx ik7rc1mmyqU5416P2FWcVkJLMFIRi9Q= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-633-6MfxmpO9ML-V31-6Usq_Nw-1; Fri, 27 Oct 2023 04:59:22 -0400 X-MC-Unique: 6MfxmpO9ML-V31-6Usq_Nw-1 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-9b97f1b493dso118679966b.3 for ; Fri, 27 Oct 2023 01:59:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698397161; x=1699001961; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nthNLcM54clb758wa+tOFVRUlC4qd7yK/hBYFWoohps=; b=NFRq+3pDIojjNbeATT4+M8RNllvhkP+W903kyaRQQ/x+RwXKIyZxkeqRu1KFetFqmq v7FyJ/p9HRH3OlVVqrt8i1Tb5tSRrXgxN55jlTl2AYC1VOp0ndP2JmzsTXRGl7kr4gag yyVxlQKBwckJvVGeGHVCWCYfwOVZ46B4iklOxKAXG8dVuO87Q+QWOXXvkL/tJa8/xxiA fGoq60snvod3a4W+NLZ0Ia1Zx8REhtspvPMYUmaQ+3gFRtTEYi7cePHB3vWcRVQpivOt pyr7hu4OPfdGb4D6pplF3wzambRwyKC/ehgxKl+oohhJFrmr3s430qKAs1oIho772CoI Yd1g== X-Gm-Message-State: AOJu0YwHax22UfNxMicrzn/3pjqagZLjpWL3n/kIZnrocQ13CepAbi1z MWCiNzjDFsg0B6YpZ407BeyYCC4F5Bkh/CmB3QmSls4kdJ4iUao0mbi1+BE3lNXZMXqXBWrGOnq J0Sc= X-Received: by 2002:a17:907:7f8c:b0:9be:466c:1824 with SMTP id qk12-20020a1709077f8c00b009be466c1824mr2063916ejc.11.1698397161757; Fri, 27 Oct 2023 01:59:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFvYKWEz4VpU3bJW7hbsVZBIbkojgoUuvqn8n7/jDAuxvXlRKMximVhh57ERXB1hL3usIdhzw== X-Received: by 2002:a17:907:7f8c:b0:9be:466c:1824 with SMTP id qk12-20020a1709077f8c00b009be466c1824mr2063904ejc.11.1698397161414; Fri, 27 Oct 2023 01:59:21 -0700 (PDT) Received: from [172.16.2.75] (5920ab7b.static.cust.trined.nl. [89.32.171.123]) by smtp.gmail.com with ESMTPSA id dc17-20020a170906c7d100b0098e34446464sm872735ejb.25.2023.10.27.01.59.20 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Oct 2023 01:59:20 -0700 (PDT) From: Eelco Chaudron To: David Marchand Cc: dev@dpdk.org, Maxime Coquelin , Chenbo Xia Subject: Re: [PATCH 1/3] vhost: robustify virtqueue access lock asserts Date: Fri, 27 Oct 2023 10:59:20 +0200 X-Mailer: MailMate (1.14r5964) Message-ID: <768E24A0-2BDD-4130-8A54-5A282AE46DC0@redhat.com> In-Reply-To: <20231023095520.2864868-1-david.marchand@redhat.com> References: <20231023095520.2864868-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 23 Oct 2023, at 11:55, David Marchand wrote: > A simple comment in vhost_user_msg_handler() is not that robust. > > Add a lock_all_qps property to message handlers so that their > implementation can add a build check and assert a vq is locked. > > Signed-off-by: David Marchand This change looks good to me. Acked-by: Eelco Chaudron