DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: paul luse <peluse@cox.net>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] vdev: free reply.msgs memory for secondary process
Date: Fri, 21 Sep 2018 12:07:40 +0100	[thread overview]
Message-ID: <769d244e-5e32-90bd-6ea0-1c99539404ef@intel.com> (raw)
In-Reply-To: <20180920232930.68311-1-peluse@cox.net>

On 21-Sep-18 12:29 AM, paul luse wrote:
> This patch fixes an issue caught with ASAN where a vdev_scan()
> to a secondary bus was failing to free some memory.
> 
> Signed-off-by: paul luse <peluse@cox.net>
> ---
>   drivers/bus/vdev/vdev.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c
> index 69dee89a8..2566d6c0d 100644
> --- a/drivers/bus/vdev/vdev.c
> +++ b/drivers/bus/vdev/vdev.c
> @@ -423,6 +423,7 @@ vdev_scan(void)
>   			mp_rep = &mp_reply.msgs[0];
>   			resp = (struct vdev_param *)mp_rep->param;
>   			VDEV_LOG(INFO, "Received %d vdevs", resp->num);
> +			free(mp_reply.msgs);
>   		} else
>   			VDEV_LOG(ERR, "Failed to request vdev from primary");
>   
> 
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

-- 
Thanks,
Anatoly

  reply	other threads:[~2018-09-21 11:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-20 23:29 paul luse
2018-09-21 11:07 ` Burakov, Anatoly [this message]
2018-09-21 16:25 Paul Luse
2018-09-21 16:53 ` Ferruh Yigit
2018-09-27 13:28 ` Ferruh Yigit
2018-10-25  7:28   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=769d244e-5e32-90bd-6ea0-1c99539404ef@intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=peluse@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).