From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 6E9762BDF for ; Mon, 12 Mar 2018 18:46:17 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Mar 2018 10:46:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,462,1515484800"; d="scan'208";a="207522216" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.62]) ([10.237.221.62]) by orsmga005.jf.intel.com with ESMTP; 12 Mar 2018 10:46:14 -0700 To: Yongseok Koh Cc: Wenzhuo Lu , Jingjing Wu , "dev@dpdk.org" , Shahaf Shuler References: <20180306162822.61791-1-ferruh.yigit@intel.com> <20180312150523.74621-1-ferruh.yigit@intel.com> <5CD4CA47-AC99-42DB-8C09-DD235DF27195@mellanox.com> From: Ferruh Yigit Message-ID: <769d866a-0d16-1495-3f66-d05f52068570@intel.com> Date: Mon, 12 Mar 2018 17:46:14 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <5CD4CA47-AC99-42DB-8C09-DD235DF27195@mellanox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: print Rx/Tx offload values X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Mar 2018 17:46:18 -0000 On 3/12/2018 5:26 PM, Yongseok Koh wrote: > >> On Mar 12, 2018, at 8:05 AM, Ferruh Yigit wrote: >> >> Which per port offloads are enabled is not clear. Printing offloads >> values at forwarding start. >> >> CRC strip offload value was printed in more verbose manner, it is >> removed since Rx/Tx offload values covers it and printing only CRC one >> can cause confusion. >> >> Hexadecimal offloads values are not very user friendly but preferred to >> not create to much noise during forwarding start. >> >> Signed-off-by: Ferruh Yigit >> --- >> Cc: Shahaf Shuler >> Cc: Yongseok Koh >> >> v2: >> * Add Rxq and Txq stats too >> * Split Rx an Tx related logs and place them related group >> --- >> app/test-pmd/config.c | 13 +++++++------ >> 1 file changed, 7 insertions(+), 6 deletions(-) >> >> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c >> index 4bb255c62..6249b19bb 100644 >> --- a/app/test-pmd/config.c >> +++ b/app/test-pmd/config.c >> @@ -1682,10 +1682,6 @@ rxtx_config_display(void) >> struct rte_eth_txconf *tx_conf = &ports[pid].tx_conf; >> >> printf(" port %d:\n", (unsigned int)pid); >> - printf(" CRC stripping %s\n", >> - (ports[pid].dev_conf.rxmode.offloads & >> - DEV_RX_OFFLOAD_CRC_STRIP) ? >> - "enabled" : "disabled"); >> printf(" RX queues=%d - RX desc=%d - RX free threshold=%d\n", >> nb_rxq, nb_rxd, rx_conf->rx_free_thresh); >> printf(" RX threshold registers: pthresh=%d hthresh=%d " >> @@ -1693,6 +1689,9 @@ rxtx_config_display(void) >> rx_conf->rx_thresh.pthresh, >> rx_conf->rx_thresh.hthresh, >> rx_conf->rx_thresh.wthresh); >> + printf(" Rx offloads=0x%"PRIx64" RXQ Offloads=0x%"PRIx64"\n", >> + ports[pid].dev_conf.rxmode.offloads, >> + rx_conf->offloads); >> printf(" TX queues=%d - TX desc=%d - TX free threshold=%d\n", >> nb_txq, nb_txd, tx_conf->tx_free_thresh); >> printf(" TX threshold registers: pthresh=%d hthresh=%d " >> @@ -1700,8 +1699,10 @@ rxtx_config_display(void) >> tx_conf->tx_thresh.pthresh, >> tx_conf->tx_thresh.hthresh, >> tx_conf->tx_thresh.wthresh); >> - printf(" TX RS bit threshold=%d - TXQ offloads=0x%"PRIx64"\n", >> - tx_conf->tx_rs_thresh, tx_conf->offloads); >> + printf(" TX RS bit threshold=%d\n", tx_conf->tx_rs_thresh); >> + printf(" Tx Offloads=0x%"PRIx64" TXQ offloads=0x%"PRIx64"\n", > > Small comment. It would be better to be consistent between "Offloads" and "offloads" > for Rx and Tx. :-) Right :) I will send a new version. > > Other than that, > > Acked-by: Yongseok Koh > Thanks >