From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F2C842B2C; Wed, 17 May 2023 17:31:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AC809406B7; Wed, 17 May 2023 17:31:49 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by mails.dpdk.org (Postfix) with ESMTP id 5547640041; Wed, 17 May 2023 17:31:48 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C5wD5s58yy/G5BUwsc2XZ4dBowEYkt1xtFiORH4DA3LQTQ+0f5/vMrtqJXhWZhJZ1O3vRvhuZayi1c6DB5X5zLEhD02Gvdxmc62pxb1jC7et1BKvYWkGV9Rq6A2b3Npph/ii0G0n0fg9ehRfox1Xi6RAFdWR0BsCFr68l5FkUmGYBwkW++t3Bpf7AV/FHZ0S9ft54ImHAXNd+Edu39dk2/d0Ux63Gv/2KJuVPCYLxFacznDixzycpaQcEmY/ozzxwcpSehFo373GUcSpcK3YR9kmBQ7tiR50dD1OWfyg8BPuOrJx25OiJWNrqz6Wq2hQr7uxrar6fpcc/bcRnjf02A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vcLNHyS5ffAS3eVVxrONnf0Cs/JGDY7xhlUcFIfgwa4=; b=XnytEX85CXaloWLK0CR5VciZPGucef3Gnic/PUwe96ET7ZqonEcpcFqlfp/FjnCDaWz8nrc25wlZSODRs3i2FgW0ApT+DO/97lSknS3pxWdafMf1w35FKDd98BerSodUh7wq51QHI8YnUvnOb1xApnj7kdx1kgigLe9wegC3BJdsDmvuQR8jL97AJ2MHORx434dMsgzzgAXP549Mg3SYNEmRfnfx1InTGtaWHP+E2jczdLVDqNoNRwdBDJXiMLYyAXjkeb5xHrVUGyavuAgmxVx0KjCZeRK0jHUdkBqY6OA+q+BFNzRyny2Ga89w4lukgTqOX1B/CY3A3w89cXwlQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vcLNHyS5ffAS3eVVxrONnf0Cs/JGDY7xhlUcFIfgwa4=; b=Rx3CRaggb44654mxW6L2BQrswB7W3031TdMmIbhevEe5DUDiYWa5R8qlJNXcORxitHoiF7u1Y8GcLu45mTFBQsWebdgk0grpV5d4WtmkJg14wkHZ8n80IBfSg0jcdBtuQoTzxyyDvf1MIqW4F6t+ZsLqM0kuw+N9/DF9dz9Fuhs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM4PR12MB6304.namprd12.prod.outlook.com (2603:10b6:8:a2::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.33; Wed, 17 May 2023 15:31:46 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a%4]) with mapi id 15.20.6387.033; Wed, 17 May 2023 15:31:46 +0000 Message-ID: <76b366d2-06fd-f787-5110-82fcac440663@amd.com> Date: Wed, 17 May 2023 16:31:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] app/testpmd: fix GTP L2 len in checksum engine Content-Language: en-US To: "Singh, Aman Deep" , Raslan Darawsheh , thomas@monjalon.net Cc: dev@dpdk.org, ting.xu@intel.com, stable@dpdk.org, Yuying Zhang References: <20230402122619.10078-1-rasland@nvidia.com> <0bbf69db-a227-8133-93a1-ba184b3ea916@intel.com> From: Ferruh Yigit In-Reply-To: <0bbf69db-a227-8133-93a1-ba184b3ea916@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0234.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:315::11) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM4PR12MB6304:EE_ X-MS-Office365-Filtering-Correlation-Id: 6da94db6-71fb-417d-f8b7-08db56ebd2e3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TyAdDThpv2G1UTq0As85E57Qwcnjfy/fzqho+1KtR0Qb+a2Gue8+xHeQD0XGt9d9ctMSXMR8NKr3/FtRGbCp58592WPUr0vup4aHgGIjf2bytoBUPIBNTOMh2RCNDpIoow5FRwsX71Tp56ZS5sPv9xZi4S4L/3kuCpas2+aHjxNKHvV/yj4Y1szmZuh49TF1W5kqclFogPgJTKOGSpOOB3kZ5gh5LQWgyE+hQhEdVUZiMJBhKNeJbSpSknHLI0DD1TVtjYhtwmgJfU8aqPq5kLC2hHjlzkWg6N6z2TSAmFz+QXpcrsR1k2AO08LbNkOW4q23WwwI9np3D8akynPUg74Ry66EfAXef6aud/WjHIbzIOBMevoGeNXmo3u4hfBxo2/9zlXWnNZo5NCqv82tNgscrljvhLk6ddLw11dLTB5vFy9Q3KHIfNe8iMEaN66tKZTQa+EkRHe+l9FddhHDpSXG9PwIpJsUl2UOrlHgxXNC2RQZBy/dn1lx2XLJ/6I7k+kEgR7PzqqgaNsOknPz27FexLsm7edXLZ/KxC1weAZEoMBvLs1xU6etabuK9k1dZhMVC+aegWRtOPAybB5qseRKxJiGX2Dby12Xqe35ntULinOoBGYtz9hn+I+Omtn05/5LFhuKscU4gbsMU1NcIg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(396003)(366004)(376002)(136003)(346002)(451199021)(36756003)(6486002)(4326008)(86362001)(316002)(110136005)(66476007)(66946007)(66556008)(478600001)(6666004)(8676002)(8936002)(5660300002)(4744005)(2906002)(44832011)(38100700002)(31696002)(41300700001)(6512007)(2616005)(186003)(6506007)(26005)(53546011)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K0tDN3FMUFozUU9KN3R1UmFmcEF3ckxIZ2JBYmUyUXZmb0dpRGZVR1hPVmJo?= =?utf-8?B?UXo2NWp1TWNDRWFIV1lPb2JaSy80M2hWU0lRRmsvcDcvMThFK0p5WTJNQWlX?= =?utf-8?B?alBldlRtQ0NuYWYwSnZ3Uit1VTBYZVZWYmI5aEh2WXlSUnhrV1BWOG84K2FI?= =?utf-8?B?VmxwelVWTmpJMUZSa1J2ay9rTDV0TEQwWDlsWkp5YWRGQlZRT3p6U0VNRWZX?= =?utf-8?B?bi9oeG13bWdjUGppNEdMSXdlNGljTTU0WjNpcDFqQVk1aTFWOXFYZU9HMTNl?= =?utf-8?B?bUZEa2h1Z3B1NjM2SlRsUWFhOC9iRTJiTkxHcU92aGJUSmNIUUNMZ1pXVk1I?= =?utf-8?B?UDNJYkxlMVUzY3JqcjRST21PcldTdnp4eWtXbDVXYVo3UFVMRzBDa3NDUEhw?= =?utf-8?B?cjkzaEppQUdhZ3lHcnNKbFlSWjluR3A0UFl1WVh5Q01NWkZUN2dLYzBkczZU?= =?utf-8?B?ZVdGYU8wQUVBR2tDd0NCbkw3R0dwL2JnK0VUZVhSc3BMWkNleVE5bEYzeGQv?= =?utf-8?B?d1BEblhkUkFOMy9YK0pjM3M3U1FWb1NFa1l3TG85VEJaTHJ2ZG5kYm9IZWFR?= =?utf-8?B?QThPanYvTzdzeWxqVFRGUVdjalZQb2JMeGVXT1dNRU5CK05idVZzam5XaDhs?= =?utf-8?B?czdPRis5REh0dGYzZlltRFYvTEduUFBqZUViejVkbVVNNGpZc0hwRjQySjlZ?= =?utf-8?B?ejBTemFwRUdFcjhJMWpsMEFYZ01ORkxkNjNqVHNVbDhxbnBIeFRYZXY1N1Qr?= =?utf-8?B?ZUZjbzdUYmp0RWU5aGFDU0YwYTBoeUlranExYWlrczZmN3FHWWhDN3U3bDJN?= =?utf-8?B?bWVJT25oMjFVVlZoaktlR3R4eCtCQmJvcG5tdXBrZ3V2YnB0MXpjemlHVnlY?= =?utf-8?B?ME8xNkIzZmp4ZWdmdHRwcUFCRHNObmpTbytqWVByRGZuWmtuWTVUVDZHdDdY?= =?utf-8?B?UFBMalhtckV5R05nRDNLcnE1QkkxSXNTSmV5SW9GWG5KRmxjZWd3OWo4dWow?= =?utf-8?B?Q2ZZY1JiYzY2aGk1UDlhcDJ2VDYvSWkwMmlpeklKTEZ3eTV2NlZwNVljUGdu?= =?utf-8?B?eHBST1RQZ2FtakJzVHRZM0NjZnBMSTFCRThmWS9vWDh5L3ZmK29wQWh6RElK?= =?utf-8?B?Mys2UjBOd3dSRjVINDgzWHZaSGFRb2Z4REVRRjZtc2xkNVRrL3NjOExQRFAz?= =?utf-8?B?OHk3SlNsM2QxZDM5TVExL21oN3dVRVNmNTc2djRiaXo3dStRR3JPTjVoaGRW?= =?utf-8?B?c1dlQ0N6ZGdRcWo4L1FOV2JQVDNxTHRQZUw2YUYvRExUL1d1L3F1OU82V1VJ?= =?utf-8?B?Z0l4QzF2RitYMTNEcUZKRk13TFg4am9pL2RQeEFxNy9hSEFoNDh2MGxPQ0Ew?= =?utf-8?B?UnFnM0VXU2lHMGxINVhoWk5FNEZudkR5ZHhSZ0pNMTRoSno5VE5tSXB1cURO?= =?utf-8?B?RENGd0VIeXh3MzgvUGxjUXAzN1dnT05wdVc0NUlhNWJCYTlvVk92V0pic3BP?= =?utf-8?B?YkJTM2RmT09jdmlyNXFXWFdpSmFwRGdVUnhOWG9NZjZwVUdQSjJuaVU1TStL?= =?utf-8?B?QWI3WDYyTU14Y0tIV2k3bXR3cy9aRUY5cDFpeEZ3dWtVUTBUZEc5ajU0R1E3?= =?utf-8?B?S2VudDFTTnNwTTZXWHJnb2t1RytIZDFIdUdENkJyTjNsTGRMbHN1bW54bWIz?= =?utf-8?B?K0ZWSWRQT0xDZ3FxdXJ0SzNqclAydWtucGE2Z0tkVXFGWktTUzBsY0psODU0?= =?utf-8?B?Ung2UzA5Nks3aU93VU1WVmVLY2xVUGg5RVlhdjF1NlR0cmFNRCtpUDFOblVy?= =?utf-8?B?SS9WWGs5emhEbmsxUU0yb1lDcStmUGY0VnZFN0dYZmorTUJjUnI2cCsvRHFa?= =?utf-8?B?ZFM5c1JhTGdsVzBDS0ppbEtUbHdZRjEzeHZrTm50eHMrTW9EOURUblR1MEJF?= =?utf-8?B?ZmIxWEtxVEdSeWd3akVCSFovYzRvRDY5NlJ3dGlsOWNsSDVicGN1UHowL3Bl?= =?utf-8?B?aHBOMGRQa2l6K29ycHNRWVltaFhkM0V0NUdQcVRPK1luTi9pMFdlRWYrTXdU?= =?utf-8?B?RndSUTRjOVFlSExHcnF3N1B3ZkVuTzJNd2NsQnhHRmtESEhpcEZiSzl3Z0M1?= =?utf-8?Q?+A2vBeg4aFD3txh5oC08fOswj?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6da94db6-71fb-417d-f8b7-08db56ebd2e3 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2023 15:31:46.1051 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EKjwnAPYQNfcemFqBtfFRhOKaKZYmUDksH5e92o388OTwYTal66GBAIOtQTIDg/j X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6304 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 4/25/2023 12:59 PM, Singh, Aman Deep wrote: > > On 4/2/2023 5:56 PM, Raslan Darawsheh wrote: >> GTP header can be followed by an optional 32 bits extension. >> >> But, l2_len value statically set to RTE_ETHER_GTP_HLEN >> which is defined to be >>          (sizeof(struct rte_udp_hdr) + sizeof(struct rte_gtp_hdr)) >> >> This fixes the l2_len to take into consideration the extension size. >> >> Fixes: d8e5e69f3a9b ("app/testpmd: add GTP parsing and Tx checksum >> offload") >> Cc: ting.xu@intel.com >> Cc: stable@dpdk.org >> >> Signed-off-by: Raslan Darawsheh > > Acked-by: Aman Singh > Applied to dpdk-next-net/main, thanks.