From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6287343252; Tue, 31 Oct 2023 13:18:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EFC5E4026C; Tue, 31 Oct 2023 13:18:03 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2046.outbound.protection.outlook.com [40.107.244.46]) by mails.dpdk.org (Postfix) with ESMTP id 69D68400EF; Tue, 31 Oct 2023 13:18:01 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b5LZ/8t7CpdEC4Xq9yH3HbxXAazrV2L7U//3ebGUnmwotqMztnqhvNRMqlGS8RwGCRoKSFBf+iqy/o+bjCUKnhKyCaKGi3r+ksas0u7TA6RpKFPasaZUeFE6xEnb+xdyCatRQMlZLcWL93cRU4vvWK6Pgb9XxhGd6biduBJcbDfwGbTFQsTi5rWgTG2h+GXNMICpnHvwSnbrdBPL/Gvi2jnvKK9XNamXSW9pOKBQWn8BLtH+9uqYwB3bM+KJ+gfJ8F2DL6MvqrKuvd0Beh1VeIEI1QhPNC0vQPdk76UNHdQzPqS1vWqGEnBveVnScmjfw8XLpeZeR/a4nEU/8ytLbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zbjI1rHFCw5Pd9rlaGoeK5b6we2J3bGDjOAaTI1H1xc=; b=SC445UfevazJnNGX11IYdwM9W2IM8zQ6mPz30uOHekfkzjCcCyzpt1K7WDeWd+XS8GQaKC9rmfFjOd+3r9W1ZpfJ/Hdnj1USYiaMC5mlqWI1zPhrWkzWY3NrOTaAvcegriDKdsNV4zgHNCnQz0Cx3d9krL/71jAG0K2dQn6UgdrZ6qa5Vzy0Ez2mMy9XITFXt+tG1FYK316m0+VDff43bTo1aub5CYDVqfOijUYP2W8l+v5I5TMV9PDb+oavtolAxIIDL6NcFxJx0qpkAM+tyLxPzoxjAwN+/De368+I2MQhMFgqTwfGlj+eVvLDcil0b8qlGzIijy9ZvJwcRtjSPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zbjI1rHFCw5Pd9rlaGoeK5b6we2J3bGDjOAaTI1H1xc=; b=tOhGjhWc9TuE2tivN8Xi6X6BYMAvGb6tOZL7j/JjtNpoeydbqYBwxeXTeW1YJUL0cdCdp8oogt0NnMuAKfHvaXZQrv2g7KP8GhHaaOqF5VxBKtqLygVsmC0+1a0uiay90uEvH+Fz+s9201HrYqdzIrBpVYT+5/sz8aNWsyQMlks= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM4PR12MB6616.namprd12.prod.outlook.com (2603:10b6:8:8e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.28; Tue, 31 Oct 2023 12:17:58 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.6933.029; Tue, 31 Oct 2023 12:17:58 +0000 Message-ID: <76b9c80e-3dbc-40a9-8127-50fd5e1f6b36@amd.com> Date: Tue, 31 Oct 2023 12:17:54 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] net/txgbe: add proper memory barriers in Rx Content-Language: en-US To: Jiawen Wu , dev@dpdk.org Cc: stable@dpdk.org References: <20231030105144.595502-1-jiawenwu@trustnetic.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20231030105144.595502-1-jiawenwu@trustnetic.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0159.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b3::15) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM4PR12MB6616:EE_ X-MS-Office365-Filtering-Correlation-Id: 6efc8c64-ae53-4f83-475b-08dbda0b6b60 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yZr/GlwF0UI3pe1k5kit8qy8HoCL+ULLkBiFNHAbJphe1eFaUqDBuJp2OMBlo96NmY1hcpeEfJsm8dtgwqiSd2KQCmDCu5ktyk9GFSIA44jtChu/VsbjmjfQMQ6hcpt3zd05WL+X6fKn3y3SjzJJYzBdn5IXzpKW3mxuJM9C95+Dkxmxb3chkTStHdMZZm4DybRrDDekonklrL8YA8gSb59IPtqDgnmIrhKj7lNgmfXTOa7f1epCrbEhQ/RLqgOlAtRPaG0fpM6GjRPnvpaT0vT1jwQ3rxcl/spW28O9mo9ATD0W3SkOEII8evSXCG4qbODsbicCaFnOc7QrlRelztuiLOG86tVx1J6l4Yt2FAIz7/9yY6FwF7V8PWVz5rAoIGUl1bw3eD+BY1S+U6abCOhD2mcd4YcVkkaXc8jsPd1AWVlVlbZpd5r30hCAXtwv6ApF6IFRyJP0ZKUn2jo5fynFVMdDXcTZeAKhQaapY11rTqVQ1hRQulaRW96U/4ippt+s3GLM2YJPYiAflrgZaQBlXvUwavkU4YnvHuCKD/wPX26yTCt2w3dIqtir79Iv+XKcZPflnvy2IYf9BO999zjIEO6o7jT4ugl+1aaFuXIqsDfW2sG+H76N5nt+jiqdSDnKWHqs+Jv0oIFaypFglxux+CeTjjXFmpgAGS6u26cl0P+gwhZF1iot1mQq3xF6dvZ2wqO2pLH5oKpr4QccKAvpnwmGRR/2mqP2xNAvtTGyMtlDlYxW5TkkSr+Ywrdi X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(39860400002)(396003)(376002)(136003)(346002)(230922051799003)(230273577357003)(230173577357003)(64100799003)(186009)(1800799009)(451199024)(6506007)(6666004)(53546011)(6512007)(6486002)(478600001)(83380400001)(26005)(2616005)(2906002)(5660300002)(66946007)(66556008)(41300700001)(66476007)(8936002)(44832011)(8676002)(4326008)(316002)(86362001)(31696002)(36756003)(38100700002)(31686004)(83323001)(21314003)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZnB0VHhETXUxUFFvYzRVT2tZejJOb2pnZVZrMVA2SUs5NUt1NEg1a29TT3Y1?= =?utf-8?B?aExNSHp4Ui96aFNWZGpVNlErVm5tVUFHWnpZKzE4SWxWblJCMlVnMDVwSndr?= =?utf-8?B?UUlZUzkyTkFWaFVmOU0vVlN2eU9yWHNDcU5WMEY1SlppRXY1TCtlY1ZDRjQr?= =?utf-8?B?M1FSV2YxQ1A0UHBtSmE4cXYyM28vZ0xjSWRWTFdsVzBkR2Ftcm9GeFZlK29l?= =?utf-8?B?NXNnNEpoY1J6T0NrMWhpdjgvbkxtWldWVDlQbTVSQlR3QTQ5ZlRJNTRVWnln?= =?utf-8?B?TGFja2xHb0dMUGtIdVBRQXVNYkhXRldoQzNzRTkvZW5VRkV5cGU4ZGN5a08y?= =?utf-8?B?cTNCYnUzbkZSQlV0NWttQkZNK2IxbWhrYk5YQWhnMzJ1SExJRVk5M2h6bkJ2?= =?utf-8?B?MHRQUVh5TmdteUZSOTZXcG5JR2NGWXE2MFdJcjMyQ2NTSXdQNjVjY2NOUXJP?= =?utf-8?B?V3Qya0I1b3NBajQ0dGcwdHpVY1ZQcmQzN25UTkZ5NFMvUDhqVXR4YzYzdGlp?= =?utf-8?B?aHJFdVp1Z3VFclpDS2pUWlZqODAveXFiOUFvcWJBRCtCSG45QnlRZCsxMm1D?= =?utf-8?B?NFpTdFJ3TkRPYTRPSndIYVZsYTRBSDFibisxcW1ValFDM3B4SUxGNm1tOE95?= =?utf-8?B?aFZTVTZ0ODVqaDNyNjBhdXpXMEgzZ3FlM0F5MTJYd3lHaWxBcWg1SjJOZWJS?= =?utf-8?B?TjNyTVpoRkZjMkRGSkZCZFZWZjB5TlpDUURRS2NUMW5nOWJBWUVjUkVlR0xs?= =?utf-8?B?REtKQnVOWGVlOThQN1g4Ui91UkFYUFNQYUIzb3FIYi9tSHFLVDBBVzBFSm5n?= =?utf-8?B?ejFqME93Sm1HVlVHOWVaQkplWVhBelhTaWFhd0s1Q0ZYRW1VWHd0dHU1YTBZ?= =?utf-8?B?QkhCeklMdnNEOE1DeFVyd2FaV1JmN0R3K0hFb2dXSW9NL21FWkJNb1BJS2V0?= =?utf-8?B?bE12MkpGTmlHTW0xY1dZL1ZtTFZydlNQbm9MU09hcWJrT0treXFvdmpCbjV6?= =?utf-8?B?VVEvZUpHRFZqZjlZZE8rRkt2SStVTy8rU0x5M0MyWUY5T3RYNlprcUU2ODZR?= =?utf-8?B?NWdiR1ZLWDJqb2xxZllzWWtmdDd5emg3MmpkSjBqMk9PaG5JL29HTkJYcjBV?= =?utf-8?B?SGQ0YjhlUmFWM3hDM3htaUsvTmZUNnloa3FDS2dOK1JCQVI0UTZoMkRFc1BD?= =?utf-8?B?UkU2VzE0bjVYc0ZsNFM1a29ZdUZ3c3ZxU3lCUVprVDJ3SkJzSkdjNUthV0N6?= =?utf-8?B?M2VYL1k3K0VwYUhEZVBkd0ZQeHpUeDF2WVRGd0FGRldvOWJaZ29abkZnbzFo?= =?utf-8?B?N21HbTFEMTl1YnJJbVBnVU85TWQzUXZYeHordHExbUliblBJbzUzWTRGb3Rw?= =?utf-8?B?cGp6c3VIZE5uaWhrUnQvNFVlbnVrUXhUQ1JvWDNmUUttZG4rQm9jNHhGV1dY?= =?utf-8?B?UzNCemIrNFpRQWNkdXp0YkJ1bjhGUFZTTjhpMDlFcHlPdyt3NjBIc2s3cmR5?= =?utf-8?B?MWVtWXZpVTRpV1poRWlPT3lSbjRRM3pGbTVPTy9qQTlqeEdKbTQ4aEhVaDV1?= =?utf-8?B?eHliemF4eHB1SFgxME16TExUQkl1ZERYaGlEU05YcmhSaEExSGZlMWhsYS8x?= =?utf-8?B?dDV5dk1URXl2RjlrMHArODR1dnMwRTZETVVwcGVIbWQ0SHhUTUZnUnRlZjNI?= =?utf-8?B?bXBPQkRjTmQ1cmxERGYyeGR1eXVSTEhMRXlFdXEyYjZXS2szQitVM0x2K2ln?= =?utf-8?B?ZHB2Ky84NDdNdXlMbVZtS29iZG9maG1ZWjNwN1BrNkk1WDl0MzRZM0Q1U2hh?= =?utf-8?B?dzhWMzdTdHNDNHBBdHhZR0NvM01rRWRXY3hQeE5BVHFVYmJmYmdzcGRyRS9a?= =?utf-8?B?MjB1WUF1S3IrMVlTNkE2b2c5ZzNCQXEvQUtScEJ6eFRoSUZUMUwwaFJmQ21E?= =?utf-8?B?bkd6VXQ5WDcrS0xBUjdVZ1FzTDQ5YmliVlFjN2U4N3dqOHc0bjhwMHlJWkRk?= =?utf-8?B?Ui82THdoNXg4YjVzYWFrU2FrYzl6U2dmS01JWGJQa0NjUGZmYkZKaHMzTVJF?= =?utf-8?B?Z3lYeUVzbHNxUFdMTDUwR010elNKQ0JCQnJvOVdLcE83SDdVZEFVeHVEWnd2?= =?utf-8?Q?oMD0=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6efc8c64-ae53-4f83-475b-08dbda0b6b60 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2023 12:17:58.6542 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JZ5qVKnkaJRDeK6B47aG/S+KAks5TroeChYzZ4VCXN2Vgr2WZ5P2f9pBGaNAH4Bs X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6616 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/30/2023 10:51 AM, Jiawen Wu wrote: > Refer to commit 85e46c532bc7 ("net/ixgbe: add proper memory barriers in > Rx"). Fix the same issue as ixgbe. > > Segmentation fault has been observed while running the > txgbe_recv_pkts_lro() function to receive packets on the Loongson 3A5000 > processor. It's caused by the out-of-order execution of CPU. So add a > proper memory barrier to ensure the read ordering be correct. > > We also did the same thing in the txgbe_recv_pkts() function to make the > rxd data be valid even though we did not find segmentation fault in this > function. > > Fixes: 0e484278c85f ("net/txgbe: support Rx") > Cc: stable@dpdk.org > > Signed-off-by: Jiawen Wu > --- > drivers/net/txgbe/txgbe_rxtx.c | 47 +++++++++++++++------------------- > 1 file changed, 21 insertions(+), 26 deletions(-) > > diff --git a/drivers/net/txgbe/txgbe_rxtx.c b/drivers/net/txgbe/txgbe_rxtx.c > index 834ada886a..24fc34d3c4 100644 > --- a/drivers/net/txgbe/txgbe_rxtx.c > +++ b/drivers/net/txgbe/txgbe_rxtx.c > @@ -1476,11 +1476,22 @@ txgbe_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, > * of accesses cannot be reordered by the compiler. If they were > * not volatile, they could be reordered which could lead to > * using invalid descriptor fields when read from rxd. > + * > + * Meanwhile, to prevent the CPU from executing out of order, we > + * need to use a proper memory barrier to ensure the memory > + * ordering below. > */ > rxdp = &rx_ring[rx_id]; > staterr = rxdp->qw1.lo.status; > if (!(staterr & rte_cpu_to_le_32(TXGBE_RXD_STAT_DD))) > break; > + > + /* > + * Use acquire fence to ensure that status_error which includes > + * DD bit is loaded before loading of other descriptor words. > + */ > + rte_atomic_thread_fence(__ATOMIC_ACQUIRE); > Hi Jiawen, Can you please check the checkpatch warning: Warning in drivers/net/txgbe/txgbe_rxtx.c: Using __atomic_xxx/__ATOMIC_XXX built-ins, prefer rte_atomic_xxx/rte_memory_order_xxx For your case please use 'rte_memory_order_xxx' instead of '__ATOMIC_XXX'. Same for both patches in the set.