From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 3083B3256 for ; Wed, 16 May 2018 16:36:53 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 962EF7D850; Wed, 16 May 2018 14:36:53 +0000 (UTC) Received: from [10.36.112.25] (ovpn-112-25.ams2.redhat.com [10.36.112.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 061D72166BAD; Wed, 16 May 2018 14:36:52 +0000 (UTC) From: Maxime Coquelin To: Tiwei Bie Cc: dev@dpdk.org References: <20180511105542.18395-1-tiwei.bie@intel.com> <57be7602-5699-33c3-8e0b-98902fdec673@redhat.com> Message-ID: <76c5fac0-0273-2fce-dd77-0a5f0671cdf7@redhat.com> Date: Wed, 16 May 2018 16:36:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <57be7602-5699-33c3-8e0b-98902fdec673@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Wed, 16 May 2018 14:36:53 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Wed, 16 May 2018 14:36:53 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH] net/virtio-user: strip VIRTIO_NET_F_MAC when MAC isn't specified X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 May 2018 14:36:54 -0000 On 05/16/2018 01:08 PM, Maxime Coquelin wrote: > > > On 05/11/2018 12:55 PM, Tiwei Bie wrote: >> Currently VIRTIO_NET_F_MAC is set unconditionally when server >> mode is used. It should be stripped when MAC isn't specified. >> >> Fixes: bd8f50a45d0f ("net/virtio-user: support server mode") >> >> Signed-off-by: Tiwei Bie >> --- >>   drivers/net/virtio/virtio_user/virtio_user_dev.c | 2 ++ >>   1 file changed, 2 insertions(+) > > Reviewed-by: Maxime Coquelin Applied to dpdk-next-virtio/master with commit message reworded to: net/virtio-user: strip MAC feature when none specified Thanks, Maxime