From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7CABAA04B5; Thu, 29 Oct 2020 13:43:15 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 58075CB03; Thu, 29 Oct 2020 13:43:14 +0100 (CET) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by dpdk.org (Postfix) with ESMTP id 79828CAFC; Thu, 29 Oct 2020 13:43:11 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 3FD8E871; Thu, 29 Oct 2020 08:43:10 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 29 Oct 2020 08:43:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= p2D3iODX9IhJKK/AQ1KMr8PhFmvM+AdTzHS9UQ4slGM=; b=ShW7tgRJGM7uZEu4 XzeWgWlBmRGGGiYW8ne1chWHcdrvSIQHbiNBamT+LEsuZHKqcVah1xIkGSDGlaxQ 5TzykjesZeQ+6Np/O8OJ9fGH9hfKYFNZ40X7y27SCgA/iEH2czDwH8NkxpwmtmE2 Tq8kCTLAIov0cy9ZgabCU6jjvT0FR+aKIYWD7cQ98Om6d26O/QWj4U4gFSBjrHS/ 8MgShFKYL4dE9BWMfTVk8f0n26lXNlrSKJSp1IY3pN2aRmuq4VTH0bijkAKpTqZm k/2o1+tC3Go95M1sWDs7FyDvIpuMO7o2s3V2jE72lWQk/LyAjAntIneGIH0A0LwB FFL8vA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=p2D3iODX9IhJKK/AQ1KMr8PhFmvM+AdTzHS9UQ4sl GM=; b=Pw7BUS556qtdbAiTC5njvs6ZxJRZAt2yCFMpgFQGU8PhRPcS/mkszeb0C asuk7dSBtkZKTHQzM++Bq2c22DwJ+cPPPt8clOYB2EkPm7GxFv6ZisK4GsGZE/2A JqK/Vz2tvJDtBP4XwR4TKCXFCGuuybDO3MX3yetK4E0OamO68d14yeJUbt8U6+hB LbvNi1MbUuu9/KKgkLPWPE56vAF/qMWcBlZr1+73/iLHSaIIpJdndd+9Ardwl8gO WjsBnWU/3tywYfhzSsMxftVVaIZsdEeB4Oco9MQt6W5T9VpjI//utXtUoLYBkf9y 4w8rywB61+vAMR9x4bw2mh4zFGkAQ== X-ME-Sender: <xms:3biaX5duL3BVWmwzwD_wF3d5HnEMFwbF6NdTt-xkyDfAr6xufxcL4Q> <xme:3biaX3Pct47wAxhtsfrty9bCZl_sEHpBEwjJkb9Y9WtuOQBHf3ljTKej5D0gnbYWI CflV0zZYVAHipP8kQ> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrleefgdegfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: <xmx:3biaXyiHvN8j2vNZTZzz3PSGxdB0VYr1zEUc80HZBIsfUFBK-IA_zQ> <xmx:3biaXy_odjJN7JubQfFauEliUUYFbzkYmyU874Yt0w0lZ1JZxrSCWg> <xmx:3biaX1va0lo76jFk2MhNturDD8CLe-BKGr5zNlxLKWjIoHA8eLyoXw> <xmx:3biaX_LNqCnjz8UqUpjXb4dttYW9T_h0Ad-PzirhFas6IxtSyEIaJg> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 460EE3280063; Thu, 29 Oct 2020 08:43:08 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: wangyunjian <wangyunjian@huawei.com> Cc: "dev@dpdk.org" <dev@dpdk.org>, "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>, "andrew.rybchenko@oktetlabs.ru" <andrew.rybchenko@oktetlabs.ru>, "Lilijun (Jerry)" <jerry.lilijun@huawei.com>, xudingke <xudingke@huawei.com>, "stable@dpdk.org" <stable@dpdk.org> Date: Thu, 29 Oct 2020 13:43:05 +0100 Message-ID: <7712554.Tb5vVfulvr@thomas> In-Reply-To: <34EFBCA9F01B0748BEB6B629CE643AE60DADDBEB@DGGEMM533-MBX.china.huawei.com> References: <e17cf818a98e4dd5109acacd8c2bd754a0c1abda.1603713753.git.wangyunjian@huawei.com> <3015812.jyVNu9Cn7i@thomas> <34EFBCA9F01B0748BEB6B629CE643AE60DADDBEB@DGGEMM533-MBX.china.huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] ethdev: fix data type for port id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 29/10/2020 13:18, wangyunjian: > What about following: > > --- a/lib/librte_eal/freebsd/eal.c > +++ b/lib/librte_eal/freebsd/eal.c > @@ -672,6 +672,8 @@ rte_eal_init(int argc, char **argv) > struct internal_config *internal_conf = > eal_get_internal_configuration(); > > + RTE_BUILD_BUG_ON(RTE_MAX_ETHPORTS >= UINT16_MAX); > + This is an ethdev value, so I would prefer having this test inside librte_ethdev.