DPDK patches and discussions
 help / color / mirror / Atom feed
From: Olivier MATZ <olivier.matz@6wind.com>
To: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Hayato Momma <h-momma@ce.jp.nec.com>
Subject: Re: [dpdk-dev] [memnic PATCH v2] pmd: fix race condition
Date: Fri, 11 Apr 2014 16:41:42 +0200	[thread overview]
Message-ID: <7724767.rVnlBRSiNS@platinum> (raw)
In-Reply-To: <7F861DC0615E0C47A872E6F3C5FCDDBD0109D398@BPXM14GP.gisp.nec.co.jp>

On Thursday, April 03, 2014 06:35:06 AM Hiroshi Shimamoto wrote:
> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
> 
> There is a race condition, on transmit to host.
> 
> Guest PMD                 Host
> Thread-A     Thread-B     vSwitch
> 
>    |idx=0       |idx=0       |p[0] st!=2
>    |cmpxchg     |            |
>    |p[0] st->1  |            |
>    |idx=1       |            |
>    |fill data   |            |
>    |p[0] st->2  |            |p[0] st==2
>    |
>    |            |            |receive data
>    |            |            |p[0] st->0
>    |            |
>    |            |cmpxchg     |
>    |            |success     |p[1] st!=2
>    |            |p[0] st->1  |
> 
>                   This is BAD
> 
> That causes traffic stop.
> 
> We have to take care about that race condition with checking
> whether current index is correct.
> 
> Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
> Reviewed-by: Hayato Momma <h-momma@ce.jp.nec.com>
> ---
>  pmd/pmd_memnic.c | 9 +++++++++
>  1 file changed, 9 insertions(+)

Reviewed-by: Olivier Matz <olivier.matz@6wind.com>

  reply	other threads:[~2014-04-11 14:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-03  6:35 Hiroshi Shimamoto
2014-04-11 14:41 ` Olivier MATZ [this message]
2014-04-11 15:46   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7724767.rVnlBRSiNS@platinum \
    --to=olivier.matz@6wind.com \
    --cc=dev@dpdk.org \
    --cc=h-momma@ce.jp.nec.com \
    --cc=h-shimamoto@ct.jp.nec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).