DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Panu Matilainen <pmatilai@redhat.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mk: crypto pmds can only be built if librte_cryptodev is enabled
Date: Fri, 11 Mar 2016 10:28:10 +0100	[thread overview]
Message-ID: <7728480.8SZanX4UKp@xps13> (raw)
In-Reply-To: <9127451bf67ce08532a327cb66aefbcf7ed5b39f.1457687628.git.pmatilai@redhat.com>

2016-03-11 11:13, Panu Matilainen:
> If the experimental CONFIG_RTE_LIBRTE_CRYPTODEV is disabled,
> build of any crypto pmds will fail because of the missing dependency.
> This has been present for a while now but hidden until the addition
> of null_crypto since all the other crypto pmds have been disabled
> by default.

Good catch, thanks.

> +ifeq ($(CONFIG_RTE_LIBRTE_CRYPTODEV),y)
>  DIRS-y += crypto
> +endif

Why not 
DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += crypto ?

  reply	other threads:[~2016-03-11  9:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-11  9:13 Panu Matilainen
2016-03-11  9:28 ` Thomas Monjalon [this message]
2016-03-11  9:38   ` Panu Matilainen
2016-03-11  9:40 ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7728480.8SZanX4UKp@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=pmatilai@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).