From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0055.outbound.protection.outlook.com [104.47.42.55]) by dpdk.org (Postfix) with ESMTP id 0C0BD374E for ; Thu, 7 Sep 2017 10:28:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ZPgTTNdawRN6SRHU//wlBU7tw93mc+zjF/YSY/h3k0w=; b=OTQWUii9YPNIBk+/DpTtsWtoyKeEZc66Gqm29lDedKZq4spCiv2C+lANnn0ckp+e60hLzkCSvhvB4Khryqk3l+nJmPlei1O5VP7vI+OOIA/8e2VBtXGInKK3l3VrSHyaSdehLbGRGqGpw53DICx0lkSh3JPFFgfNs51Pnu1cIRg= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Santosh.Shukla@cavium.com; Received: from [192.168.0.105] (103.76.56.167) by CY4PR07MB3096.namprd07.prod.outlook.com (10.172.115.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10; Thu, 7 Sep 2017 08:28:12 +0000 To: Olivier MATZ References: <20170815060743.21076-1-santosh.shukla@caviumnetworks.com> <20170906112834.32378-1-santosh.shukla@caviumnetworks.com> <20170906112834.32378-8-santosh.shukla@caviumnetworks.com> <20170907081349.nznr2qv6f5pgs3ti@neon> Cc: dev@dpdk.org, thomas@monjalon.net, jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com From: santosh Message-ID: <772eb46d-77ed-918f-7b9e-6fbd2d804b2c@caviumnetworks.com> Date: Thu, 7 Sep 2017 13:57:57 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170907081349.nznr2qv6f5pgs3ti@neon> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Originating-IP: [103.76.56.167] X-ClientProxiedBy: HK2PR04CA0068.apcprd04.prod.outlook.com (10.170.154.140) To CY4PR07MB3096.namprd07.prod.outlook.com (10.172.115.10) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d6a3c15a-d618-479c-b03d-08d4f5ca61dc X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:CY4PR07MB3096; X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3096; 3:+0gaNlajHj4idGAgT4LMc458vocXo7gZvivsJrCikqwO/TRPcRAgpEdjRB6DcLvDwfKPohgPPpOw000hwyJWuqdUaApHTvAnfbSdDF3SQUINYC8tgjYlL/SYtV3vPdhyZEBG6RcEKFhA+x1hPXtbwWCWt3oCkMntwoxgVJqTKByiag6uFSWvO/1gvBNAmqEoY2t9+6rNAagOmcBoT3XAEG0/3pETUP4FhDejYQQn1AkiU58QQfNuFpcyBBYRXzLF; 25:8gff10s+3LKucMkF/JT2m1CE3yYBIpe0MK3+Vxq/0o7dRmyQqO7Emztxco6MQxAHpoAzjTD9GFw+eW9L1N0dI3lRnvOMJ/VFFUVkT3KpozZMAeIBN1eylg+YyYeEgWgGF6wbj5Yfsb3qef35U4VD68Mntpv2FJjJ0cfDvNXVJSe123/0oj6eG4LUzsIcwo0wzlEBq7HcMtqpv2SgLa4Jgayepj13yOVLYS5EnsCXxFwQPEtwKNaIOyUcxfSw+f8CImtDRs/xxJOBABU8sZh2CVZfj+whkc1SIdR+oLYKxNKB+A4+9uoaA+pNG0zr4JnF6s/U6Boh2XJYnCHu6xUJvw==; 31:UgC10rkhZEpG7mGEaxDuL8UTrQqzHzdAIq5JIUuRafCtVebz/mTGltHWko0C6lgYl/cN8RekUbrfUykTGYTx2D8eo5PctvzLOUdJeUw6YS5+jOxZUgGFXDrRnaLA3kMvCWK7AcHcMPwdwTYGxCGdfYklLC9Hk0TAVChDwfuDOTbNYwgz9OkGMcBkgJoZFCEx2gdU5fNawLOBbybSdEglG0aG9Y2ovSyUpAKKn7YjW/A= X-MS-TrafficTypeDiagnostic: CY4PR07MB3096: X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3096; 20:wbyUGcsmrAE/VIP/o5dz6sloL9DNG720zwav1LGt+eEUANrqb3Uk07U4Z8PCUCB2o8m9FCsLeaE2DbUOz9JR4TdED4WWjO2P3du4yBA7Dvd2A/uxgm9oRAxvMvOaz8Hj0IAlWtG8aMjBf/qOO4nUZdiVV+QJGhJwJYjBg7zhmNRbysJKaVWfogjJ1VJbUt/Tk2BsCxBKTvW9t3BVLyJC9ol6gE/oqXDt2xzj8OlNcs0qtny4bTOAESc/fRxbbe3+StOwKkokEdMY62wwCMCsoAvgl5OG+QqWxWDuhCxY4ARMYA06xT07E12mgnmMChCa8N5/X/mwGsBeqkcdIBMMQmu4CUHwzoSWebmWqsFXf8Lf+x9s3maKLAxkqg4qmka7lNkZHPkR0yQZ7nPgHwVX7X/GQsfqyi51HgGx0xHmKro5IADrUc+JxcBGSSNskBLfUNtYacg1ckcCM8esQtGVK6g+0pLp2FPOn+PzRZznFPV+LSs6Qrz50cLQlooxVh/XzokRCNRQf3qmpp+Gigf1BPvk4Ra3W5e0QQeNJN692HeibMofj24zqOJ9Ad9TJuimWAmQbcBNi7G5w2gvZQOrmijRThBYEax57Su1FHpsNOw=; 4:lPTHWanwq4HsnfUbI3dJvjH/q5JLlMXOau7zYb83u5QRHNHIVESTF8DNCfO/PAosQkHxFhQJGBKFhZFnyzEwzXynLviaCPCsjbO9EpPQ7x/3+pb9YXAaPmmlGl2bKk9ya2dIJ5MFx8wifffm1Tzp8PKMcBhxMvGSy+KYxYjngjy3YBex+lBKTTSV/U/nIm9siHQSCHzHPcK2vyQjKACf5lwqyHXQ6eaBOVIwzeH6rBjgup4W9gEeGYZHxMQyYeXK X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(3002001)(10201501046)(100000703101)(100105400095)(6041248)(20161123564025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123558100)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY4PR07MB3096; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY4PR07MB3096; X-Forefront-PRVS: 04238CD941 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(6049001)(377454003)(24454002)(189002)(199003)(110136004)(93886005)(4001350100001)(5660300001)(65826007)(8656003)(105586002)(106356001)(6116002)(33646002)(83506001)(42882006)(8936002)(2950100002)(230700001)(6916009)(31696002)(68736007)(77096006)(76176999)(4326008)(3846002)(97736004)(189998001)(6486002)(25786009)(117156002)(50986999)(54356999)(90366009)(64126003)(47776003)(6666003)(66066001)(7736002)(65806001)(42186005)(53936002)(6246003)(2906002)(53376002)(305945005)(23746002)(229853002)(50466002)(65956001)(31686004)(6306002)(101416001)(8676002)(966005)(36756003)(72206003)(86152003)(81156014)(478600001)(81166006); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR07MB3096; H:[192.168.0.105]; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; CY4PR07MB3096; 23:IHtOiFn3WT20Qh13uON0c7G6Py2QG4+V4zvEM?= =?Windows-1252?Q?t+Ch258SlbiHuVr2XtHM3Q+omMREPu2/K/qIvBLgH2ef3yHCICiCFh0R?= =?Windows-1252?Q?vZ7UDxMK1QieJLSJD5spMDMEOrMdiTWAnZSRpSyyuV1I/LFgZNjJJvCK?= =?Windows-1252?Q?R/1TSSN/ZsJYm9eMoV/bcfAhvQfkdF++b9S+YAuOZP3N69ap4igKRbnY?= =?Windows-1252?Q?CgqexSr5JprewaczL7T/Ri91R0YgPnLhZjtp09N58nh7zM+zKdkVEo76?= =?Windows-1252?Q?+4sR43iTU5nUBTIJ5vVG9ebRLTfhLNdZNx81Ff1PhZ4A4yW3TGrrWcS5?= =?Windows-1252?Q?YMuyJz0h6JWNembsV+9xARaTUVAXVVbNHNnIDLVlmPH3qSoQHtWQ2zf+?= =?Windows-1252?Q?Wng4AUFR+Xy1+r7kCCJBFbFcW9Fxs3GF0pz2/Z++JdbYqOGqnvtan+15?= =?Windows-1252?Q?iU3mhdKqmZjggkQ6RfjLA81dy1356x8Iyin7oNEAnky19yRTySNJ2v/0?= =?Windows-1252?Q?SuPjGucACPZYQ7y1yKmt8aZvQZrtc74aSYFe6IzhHhTeAgpFO0tBScVa?= =?Windows-1252?Q?arQsxl8KndD9/gKfKl3WA3wBc6NqirmT46WKwrXLRF7Ewv42ZTlby5dF?= =?Windows-1252?Q?J0R9+MR0jFJ/MszBJ3xVp5u+4uerz8eJCSC4Y0cM5HtMccNllscSeFgl?= =?Windows-1252?Q?qP1OCIL8o0i6ZjHXFByD7Vntfi8m6r5g9osK+1TL6lqq3uAQuy2g0/Wu?= =?Windows-1252?Q?FJpMvjqb1LlmlpoO3XnVcNMcXPVP4D97qhoXHnXpmcXGxbV44I/NVGBT?= =?Windows-1252?Q?5LWPZz2eTBlV32SE/GNWeK04iQ3xXXVgCdzEnFyoMFbOn3QCEyO/iGYj?= =?Windows-1252?Q?MFOMRNewitrQYZIhMjmx7oEHaGiTYiERWuXGlB6aFJv6e2MNCif1PYvf?= =?Windows-1252?Q?QnuA9wVEhSjVsKWhSK5E2W677EbWCDpgKf6ehH3I61fvml6Nxad2S+6w?= =?Windows-1252?Q?g0jTPdnIBGqfqzBdv32s+CE4WtBlBwk9T+KMdoSWugBZtB+ELPEoSt68?= =?Windows-1252?Q?JNbAtRePtyWAkzHnfS8BDL9bcxEVcwTg16LT7YLJm00NQC5iEohfx/dy?= =?Windows-1252?Q?FtiFRbo8NWTlk6+MRm9DPAFCccA+RedlpJ6WYOxHcoFInwn7Jby+MXzK?= =?Windows-1252?Q?1Zp5qPR5cslx0KonaAD3gvTHcXRBh1KV7nkNe1Pb0HfQLL/yvanX28d2?= =?Windows-1252?Q?eebTf2AaBfJw4LmF/Bcs91OCZtetwSKX5F0NqeUiFKm1abVUMqRROXs8?= =?Windows-1252?Q?x8/peZGmxeqSICPCFDq5V+T4AC641Y3LYDWuomOTamBTJjaOaGkGC7MY?= =?Windows-1252?Q?NrQFoEGRASvv+cDOeQ0I7hPT4iP3tTv6+dflKHFZ81UA7rHEZ4mBY1kv?= =?Windows-1252?Q?IYoIfDqpCDWMOjybLKqkK6cUYnTMk3/8DVIptvyTu9dZi5GMsrln5G1c?= =?Windows-1252?Q?8mzLqi3aVdM7IeMGmkL3ScE/xYbd7YbDJZEo1Uqj1JiDhEXhOig4ZQWE?= =?Windows-1252?Q?DO3+jzaZtVQbARNCWgbd8BckdAEnHlxLv/v?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3096; 6:8uDATwcbaNcsObPr7e4CaxsjoU1U3JbH3Xgy7VVbhPuB+892g6NkwLkdGg53W5A/fY4E2JUEQMLg3S2+YuvE9632mdhjQ7ztw6LKRx0s+281FgloMJkWpI4ayp2BXKAzom9afiUSdeGP00lThYnT3FI3pYpbUBBP5pdua6OK/ZldsUwZ65zmE9c7TGe576MNJuVZOHOOlpnrK2EqBkvp17eNPllBzO3mOBjAOfnmL0kfwgrWtsPqdqAFmDFmrEdOxdbXnqR4P7KeBQDRslRpkY4aiuJBh7g0xoKTBEGzNPg9rpURqUjPe0fyUqRZTqZwk/8N7GQp5Nsde4V2pHIz7g==; 5:gwaygPNcslOpnuUd6S1NNO3qgeysD6zqSvE7czKZDnXgVPK51ZcjvNxiqqMk554eWH0jDh8nMSEViwUQXErNz+3gabU0G3xPV9jhn3QeBIjsJbPacBQNnYbltRQ5iwwAiokz4AHU/oV5hQb4+y9oUA==; 24:/Jp8tA+H/FxYAw8VkxfqvfDwDmZleZD3TKF3vpsrKBerBxjmP/yQZu/Mwn1h25KgYcyRjByAl02fc/5ZJiJF7wwB71ScNV1vcRBXiKMlTFw=; 7:+zfKXLWmutQmoVyXAK2ZpegSpuhrKa06F7cHrKBsXc6r2MEPE9UUotdiWmiOWyUgto0hpzDkAihW71um4tlttzAvKs8APDtvXOLW7RysfqGDoxWxR2fkMVRPIL/O+M0aKTRhCpOtREjjMRJsatva8lOWIa9JitKN5vHUU49eNNC/cDcOHs2DiH0E1pj+LNZtbjKrMItxU35QD9yYTWvAbwxdu4LzwEBN1FQI98Py0Fo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2017 08:28:12.0603 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB3096 Subject: Re: [dpdk-dev] [PATCH v5 7/8] mempool: introduce block size align flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Sep 2017 08:28:16 -0000 On Thursday 07 September 2017 01:43 PM, Olivier MATZ wrote: > On Wed, Sep 06, 2017 at 04:58:33PM +0530, Santosh Shukla wrote: >> --- a/lib/librte_mempool/rte_mempool.h >> +++ b/lib/librte_mempool/rte_mempool.h >> @@ -271,6 +271,10 @@ struct rte_mempool { >> * Note: This flag should not be passed by application. >> */ >> #define MEMPOOL_F_CAPA_PHYS_CONTIG 0x0040 >> +/** >> + * Align object start address to total elem size >> + */ >> +#define MEMPOOL_F_BLK_ALIGNED_OBJECTS 0x0080 > Same than with the other flag: since the meaning of this flag is not obvious > when we read the name, it has to be clearly described. > - say that it's virtual address > - say that it implies MEMPOOL_F_CAPA_PHYS_CONTIG > - say that it can be advertised by a driver and the application should > not pass it > > And, since it shall not be passed by an application, I suggest to add > _CAPA too (i.e. MEMPOOL_F_CAPA_BLK_ALIGNED_OBJECTS). > Ok, I will elaborate on FLAG description in v6, and Rename to MEMPOOL_F_CAPA_BLK_ALIGNED_OBJECTS. Can you please suggest are you ok with checking MEMPOOL_F_CAPA_BLK_ALIGNED_OBJECTS | _PHYS_CONTIG in _xmem_size()/_usage(), asked in v4 [1] for same patch. [1] http://dpdk.org/dev/patchwork/patch/27600/